[webkit-changes] [WebKit/WebKit] 55e6e1: [UnifiedPDF] Implement "Use Selection For Find"

[Abrar Rahman Protyasha]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 55e6e1431a97af802449405348e32c1ccbf089b5
      
https://github.com/WebKit/WebKit/commit/55e6e1431a97af802449405348e32c1ccbf089b5
  Author: Abrar Rahman Protyasha <a_protya...@apple.com>
  Date:   2024-02-10 (Sat, 10 Feb 2024)

  Changed paths:
    M Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.h
    M Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm
    M Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.h
    M Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.mm
    M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.h
    M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm

  Log Message:
  -----------
  [UnifiedPDF] Implement "Use Selection For Find"
https://bugs.webkit.org/show_bug.cgi?id=269104
rdar://122672464

Reviewed by Tim Horton.

This patch brings support for using the current selection in Find to
UnifiedPDF. To do so, we move writeItemsToPasteboard to PDFPluginBase
and have both the PDF plugin implementations call into it when they need
to set the selection string on the NSPasteboardNameFind pasteboard.

For IOS_FAMILY targets, we leverage the namesake functionality exposed by
EditorClient to achieve this.

* Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.h:
* Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm:
(WebKit::PDFPlugin::writeItemsToPasteboard): Deleted.
* Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.h:
* Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.mm:
(WebKit::PDFPluginBase::writeItemsToPasteboard):
* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.h:
* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm:
(WebKit::UnifiedPDFPlugin::handleEditingCommand):
(WebKit::UnifiedPDFPlugin::isEditingCommandEnabled):
(WebKit::UnifiedPDFPlugin::performCopyEditingOperation const):
(WebKit::UnifiedPDFPlugin::takeFindStringFromSelection):

Canonical link: https://commits.webkit.org/274430@main


_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes