Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 58665a490033b795545382de514811b7acb11082
https://github.com/WebKit/WebKit/commit/58665a490033b795545382de514811b7acb11082
Author: Dominic Mazzoni <dm_mazz...@apple.com>
Date: 2024-02-02 (Fri, 02 Feb 2024)
Changed paths:
M LayoutTests/accessibility/mac/scroll-to-visible-action.html
Log Message:
-----------
AX: accessibility/mac/scroll-to-visible-action.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=268660
rdar://problem/122202837
Reviewed by Tyler Wilcock.
The way this test works is that it gets the absolute x, y position of a button
in
a scrollable div, calls scrollToMakeVisible on the button, then checks that the
button's new location changed in the y direction but not the x direction.
The test was failing because it also changed in the x direction, and it was
timing out because the waitFor criteria was very strict.
In debugging, it turns out that the bounds were different because initially
they were fetched before the isolated tree loaded, and after, they were fetched
using the isolated tree.
So why are the bounds different in isolated tree mode? Are they wrong?
It turns out that in the specific case of a button element, when running a
layout test without the window showing, in isolated tree mode the bounds of
the button seem to be the inner bounds, of the button text - rather than the
outer bounds, including its padding/border.
However, this difference disappears when running the layout test with
--show-window, which makes me think it's an artifact of differences in
layout and painting when the window isn't visible. In particular, setting
appearance: none on the button fixes the test, indicating the differences
might have something to due with the default Mac button style.
Since this test is about scrolling and not about button bounds,
appearance: none is a reasonable workaround to make it deterministic.
This patch also changes the waitFor criteria so the test is more likely to
fail fast rather than timing out if something does go wrong.
* LayoutTests/accessibility/mac/scroll-to-visible-action.html:
Canonical link: https://commits.webkit.org/274024@main
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
