[webkit-changes] [248768] trunk/Tools

2019-08-16 Thread aakash_jain
Title: [248768] trunk/Tools Revision 248768 Author aakash_j...@apple.com Date 2019-08-16 07:33:41 -0700 (Fri, 16 Aug 2019) Log Message [ews] Report machine uptime in PrintConfiguration https://bugs.webkit.org/show_bug.cgi?id=200812 Reviewed by Jonathan Bedard. *

[webkit-changes] [248770] trunk/Tools

2019-08-16 Thread aakash_jain
Title: [248770] trunk/Tools Revision 248770 Author aakash_j...@apple.com Date 2019-08-16 07:39:18 -0700 (Fri, 16 Aug 2019) Log Message [ews] Add build steps for Windows Factory https://bugs.webkit.org/show_bug.cgi?id=200813 Reviewed by Jonathan Bedard. *

[webkit-changes] [248771] trunk/LayoutTests

2019-08-16 Thread commit-queue
Title: [248771] trunk/LayoutTests Revision 248771 Author commit-qu...@webkit.org Date 2019-08-16 08:04:39 -0700 (Fri, 16 Aug 2019) Log Message Update WebGL test expectations for WebKit WPE https://bugs.webkit.org/show_bug.cgi?id=200765 Patch by Chris Lord on 2019-08-16 Reviewed by

[webkit-changes] [248784] trunk/Source

2019-08-16 Thread rniwa
Title: [248784] trunk/Source Revision 248784 Author rn...@webkit.org Date 2019-08-16 12:43:34 -0700 (Fri, 16 Aug 2019) Log Message Split tabIndex computation for DOM and the rest of WebCore https://bugs.webkit.org/show_bug.cgi?id=200806 Reviewed by Chris Dumez. Source/WebCore: This

[webkit-changes] [248774] trunk/LayoutTests

2019-08-16 Thread drousso
Title: [248774] trunk/LayoutTests Revision 248774 Author drou...@apple.com Date 2019-08-16 09:59:58 -0700 (Fri, 16 Aug 2019) Log Message Unreviewed, fix test failure and add additional tests after r248753 * inspector/unit-tests/url-utilities.html: *

[webkit-changes] [248779] trunk/Source/WebKit

2019-08-16 Thread cdumez
Title: [248779] trunk/Source/WebKit Revision 248779 Author cdu...@apple.com Date 2019-08-16 11:15:21 -0700 (Fri, 16 Aug 2019) Log Message Clarify StorageManagerSet / StorageManager threading model after r248734 https://bugs.webkit.org/show_bug.cgi?id=200817 Reviewed by Geoffrey Garen.

[webkit-changes] [248773] trunk/Source/WebInspectorUI

2019-08-16 Thread drousso
Title: [248773] trunk/Source/WebInspectorUI Revision 248773 Author drou...@apple.com Date 2019-08-16 09:54:48 -0700 (Fri, 16 Aug 2019) Log Message Web Inspector: rename "Invalid Characters" to "Invisible Characters" for clarity https://bugs.webkit.org/show_bug.cgi?id=200808 Reviewed by

[webkit-changes] [248778] trunk/Source/WebKit

2019-08-16 Thread cdumez
Title: [248778] trunk/Source/WebKit Revision 248778 Author cdu...@apple.com Date 2019-08-16 10:55:25 -0700 (Fri, 16 Aug 2019) Log Message StorageManagerSet constructor should not be public https://bugs.webkit.org/show_bug.cgi?id=200816 Reviewed by Geoffrey Garen. StorageManagerSet

[webkit-changes] [248781] trunk/LayoutTests

2019-08-16 Thread russell_e
Title: [248781] trunk/LayoutTests Revision 248781 Author russel...@apple.com Date 2019-08-16 12:15:10 -0700 (Fri, 16 Aug 2019) Log Message Typo correction for han-quotes expectation entry. rdar://52594556 Unreviewed Test Gardening. * platform/mac/TestExpectations: Test is an

[webkit-changes] [248780] trunk/Source/WebKit

2019-08-16 Thread cdumez
Title: [248780] trunk/Source/WebKit Revision 248780 Author cdu...@apple.com Date 2019-08-16 11:22:16 -0700 (Fri, 16 Aug 2019) Log Message StorageManager does not need to subclass RefCounted https://bugs.webkit.org/show_bug.cgi?id=200818 Reviewed by Geoffrey Garen. StorageManager does

[webkit-changes] [248776] trunk

2019-08-16 Thread timothy
Title: [248776] trunk Revision 248776 Author timo...@apple.com Date 2019-08-16 10:23:27 -0700 (Fri, 16 Aug 2019) Log Message REGRESSION (r248436): WKWebView doesn’t respect isOpaque setting in NIB. https://bugs.webkit.org/show_bug.cgi?id=200802 rdar://problem/54357818 Reviewed by Tim

[webkit-changes] [248775] trunk/LayoutTests

2019-08-16 Thread russell_e
Title: [248775] trunk/LayoutTests Revision 248775 Author russel...@apple.com Date 2019-08-16 10:17:21 -0700 (Fri, 16 Aug 2019) Log Message rdar://52594556 (Layout test fast/text/international/system-language/han-quotes.html is failing) Unreviewed Test Gardening. *

[webkit-changes] [248783] trunk/Source

2019-08-16 Thread ross . kirsling
Title: [248783] trunk/Source Revision 248783 Author ross.kirsl...@sony.com Date 2019-08-16 12:38:21 -0700 (Fri, 16 Aug 2019) Log Message Unreviewed restabilization of non-unified build. Source/WebCore: * Modules/indexeddb/server/IDBSerializationContext.cpp: *

[webkit-changes] [248785] trunk

2019-08-16 Thread pecoraro
Title: [248785] trunk Revision 248785 Author pecor...@apple.com Date 2019-08-16 12:50:59 -0700 (Fri, 16 Aug 2019) Log Message Web Inspector: _javascript_ formatting of single statement arrow function can be poor https://bugs.webkit.org/show_bug.cgi?id=200800 Reviewed by Ross Kirsling.

[webkit-changes] [248772] trunk

2019-08-16 Thread antti
Title: [248772] trunk Revision 248772 Author an...@apple.com Date 2019-08-16 08:48:03 -0700 (Fri, 16 Aug 2019) Log Message Content in should override "touch-action" set in embedding document https://bugs.webkit.org/show_bug.cgi?id=200204 Reviewed by Antoine Quint. Source/WebCore:

[webkit-changes] [248777] trunk/LayoutTests

2019-08-16 Thread russell_e
Title: [248777] trunk/LayoutTests Revision 248777 Author russel...@apple.com Date 2019-08-16 10:47:44 -0700 (Fri, 16 Aug 2019) Log Message rdar://52557916 (REGRESSION: fast/css/paint-order.html and fast/css/paint-order-shadow.html are failing) Unreviewed Test Gardening. *

[webkit-changes] [248782] trunk/Source/WebInspectorUI

2019-08-16 Thread drousso
Title: [248782] trunk/Source/WebInspectorUI Revision 248782 Author drou...@apple.com Date 2019-08-16 12:35:45 -0700 (Fri, 16 Aug 2019) Log Message Web Inspector: there should be an opposite icon for Eye.svg when we want to hide things instead of showing them

[webkit-changes] [248786] trunk

2019-08-16 Thread ryanhaddad
Title: [248786] trunk Revision 248786 Author ryanhad...@apple.com Date 2019-08-16 13:09:15 -0700 (Fri, 16 Aug 2019) Log Message Unreviewed, rolling out r248709. Caused test/built-ins/Promise/prototype/finally/this-value- non-promise.js to fail on test262 bot Reverted changeset:

[webkit-changes] [248790] trunk

2019-08-16 Thread zalan
Title: [248790] trunk Revision 248790 Author za...@apple.com Date 2019-08-16 13:24:53 -0700 (Fri, 16 Aug 2019) Log Message [ContentChangeObserver] Add ContentChangeObserver::elementDidBecomeHidden https://bugs.webkit.org/show_bug.cgi?id=200819 Source/WebCore: Reviewed by Simon Fraser.

[webkit-changes] [248803] trunk/Tools

2019-08-16 Thread wilander
Title: [248803] trunk/Tools Revision 248803 Author wilan...@apple.com Date 2019-08-16 16:51:21 -0700 (Fri, 16 Aug 2019) Log Message Add John Wilander as WebKit Reviewer https://bugs.webkit.org/show_bug.cgi?id=200837 Unreviewed update to contributors.json to change my status to reviewer.

[webkit-changes] [248806] trunk/LayoutTests

2019-08-16 Thread ryanhaddad
Title: [248806] trunk/LayoutTests Revision 248806 Author ryanhad...@apple.com Date 2019-08-16 17:17:07 -0700 (Fri, 16 Aug 2019) Log Message [ContentChangeObserver] Keep track of all the visibility candidates. https://bugs.webkit.org/show_bug.cgi?id=200777 Unreviewed test gardening. *

[webkit-changes] [248800] trunk

2019-08-16 Thread mark . lam
Title: [248800] trunk Revision 248800 Author mark@apple.com Date 2019-08-16 15:49:26 -0700 (Fri, 16 Aug 2019) Log Message CodeBlock destructor should clear all of its watchpoints. https://bugs.webkit.org/show_bug.cgi?id=200792 Reviewed by Yusuke Suzuki. JSTests: *

[webkit-changes] [248789] branches/safari-608-branch/LayoutTests

2019-08-16 Thread russell_e
Title: [248789] branches/safari-608-branch/LayoutTests Revision 248789 Author russel...@apple.com Date 2019-08-16 13:17:17 -0700 (Fri, 16 Aug 2019) Log Message Landing TestExpectation Changes for rdar://52594556 and rdar://52557916. Unreviewed Test Gardening. *

[webkit-changes] [248794] trunk/Source/WebKit

2019-08-16 Thread cdumez
Title: [248794] trunk/Source/WebKit Revision 248794 Author cdu...@apple.com Date 2019-08-16 13:56:00 -0700 (Fri, 16 Aug 2019) Log Message LocalStorageDatabase does not need to subclass ThreadSafeRefCounted https://bugs.webkit.org/show_bug.cgi?id=200822 Reviewed by Geoff Garen.

[webkit-changes] [248797] trunk/Source/WebKit

2019-08-16 Thread commit-queue
Title: [248797] trunk/Source/WebKit Revision 248797 Author commit-qu...@webkit.org Date 2019-08-16 14:13:40 -0700 (Fri, 16 Aug 2019) Log Message Functions with no parameters in WebKit/Shared/API/c and WebKit/UIProcess/API/C are missing a "void" specifier in their argument list

[webkit-changes] [248798] trunk

2019-08-16 Thread justin_michaud
Title: [248798] trunk Revision 248798 Author justin_mich...@apple.com Date 2019-08-16 14:33:28 -0700 (Fri, 16 Aug 2019) Log Message Fix InBounds speculation of typed array PutByVal and add extra step to integer range optimization to search for equality relationships on the RHS value

[webkit-changes] [248805] trunk

2019-08-16 Thread sbarati
Title: [248805] trunk Revision 248805 Author sbar...@apple.com Date 2019-08-16 17:08:07 -0700 (Fri, 16 Aug 2019) Log Message [WHLSL] Add comparison operators for vectors and matrices https://bugs.webkit.org/show_bug.cgi?id=200823 Reviewed by Myles C. Maxfield. Source/WebCore: Tests:

[webkit-changes] [248763] trunk/Source/WebCore

2019-08-16 Thread ysuzuki
Title: [248763] trunk/Source/WebCore Revision 248763 Author ysuz...@apple.com Date 2019-08-16 00:46:06 -0700 (Fri, 16 Aug 2019) Log Message Unreviewed, speculative build fix for WinCairo https://bugs.webkit.org/show_bug.cgi?id=200526 *

[webkit-changes] [248764] trunk/Source/WebCore

2019-08-16 Thread ysuzuki
Title: [248764] trunk/Source/WebCore Revision 248764 Author ysuz...@apple.com Date 2019-08-16 00:54:43 -0700 (Fri, 16 Aug 2019) Log Message Unreviewed, speculative build fix for WinCairo, part 2 https://bugs.webkit.org/show_bug.cgi?id=200526 *

[webkit-changes] [248811] trunk/LayoutTests

2019-08-16 Thread mmaxfield
Title: [248811] trunk/LayoutTests Revision 248811 Author mmaxfi...@apple.com Date 2019-08-16 19:56:55 -0700 (Fri, 16 Aug 2019) Log Message [WHLSL] Add test for the interaction between setters and increments https://bugs.webkit.org/show_bug.cgi?id=200848 Reviewed by Saam Barati. As

[webkit-changes] [248812] trunk

2019-08-16 Thread mmaxfield
Title: [248812] trunk Revision 248812 Author mmaxfi...@apple.com Date 2019-08-16 20:03:37 -0700 (Fri, 16 Aug 2019) Log Message [WHLSL] Enums should be shadowed by local variables https://bugs.webkit.org/show_bug.cgi?id=200847 Reviewed by Saam Barati. Source/WebCore: Only cause

[webkit-changes] [248815] trunk

2019-08-16 Thread mmaxfield
Title: [248815] trunk Revision 248815 Author mmaxfi...@apple.com Date 2019-08-16 21:38:44 -0700 (Fri, 16 Aug 2019) Log Message [macOS] Emoji with variation selectors are rendered in text style, not emoji style https://bugs.webkit.org/show_bug.cgi?id=200830 Reviewed by Simon Fraser.

[webkit-changes] [248816] trunk

2019-08-16 Thread commit-queue
Title: [248816] trunk Revision 248816 Author commit-qu...@webkit.org Date 2019-08-16 22:19:47 -0700 (Fri, 16 Aug 2019) Log Message Unreviewed, rolling out r248772. https://bugs.webkit.org/show_bug.cgi?id=200853 Causes timeouts in some WebGL tests (Requested by anttik on #webkit).

[webkit-changes] [248817] trunk/Source/WebKit

2019-08-16 Thread cdumez
Title: [248817] trunk/Source/WebKit Revision 248817 Author cdu...@apple.com Date 2019-08-16 22:42:38 -0700 (Fri, 16 Aug 2019) Log Message Use strongly typed identifiers for StorageArea / StorageAreaImpl https://bugs.webkit.org/show_bug.cgi?id=200835 Reviewed by Alex Christensen. Use

[webkit-changes] [248796] trunk

2019-08-16 Thread mark . lam
Title: [248796] trunk Revision 248796 Author mark@apple.com Date 2019-08-16 14:03:44 -0700 (Fri, 16 Aug 2019) Log Message [Re-land] ProxyObject should not be allow to access its target's private properties. https://bugs.webkit.org/show_bug.cgi?id=200739 Reviewed by Yusuke Suzuki.

[webkit-changes] [248810] trunk/Source/WebInspectorUI

2019-08-16 Thread pecoraro
Title: [248810] trunk/Source/WebInspectorUI Revision 248810 Author pecor...@apple.com Date 2019-08-16 19:48:49 -0700 (Fri, 16 Aug 2019) Log Message Web Inspector: Syntax Highlight more CSS media queries https://bugs.webkit.org/show_bug.cgi?id=200824 Reviewed by Devin Rousso. *

[webkit-changes] [248813] trunk/Source/ThirdParty/ANGLE

2019-08-16 Thread krollin
Title: [248813] trunk/Source/ThirdParty/ANGLE Revision 248813 Author krol...@apple.com Date 2019-08-16 20:45:45 -0700 (Fri, 16 Aug 2019) Log Message Add XCBuild support to ANGLE https://bugs.webkit.org/show_bug.cgi?id=200836 Reviewed by Alex Christensen. The ANGLE Xcode project

[webkit-changes] [248814] trunk

2019-08-16 Thread sbarati
Title: [248814] trunk Revision 248814 Author sbar...@apple.com Date 2019-08-16 21:13:06 -0700 (Fri, 16 Aug 2019) Log Message [WHLSL] Make "operator cast" constructors native https://bugs.webkit.org/show_bug.cgi?id=200748 Reviewed by Myles C. Maxfield. Source/WebCore: Tests:

[webkit-changes] [248787] trunk

2019-08-16 Thread commit-queue
Title: [248787] trunk Revision 248787 Author commit-qu...@webkit.org Date 2019-08-16 13:09:39 -0700 (Fri, 16 Aug 2019) Log Message Promise constructor should check argument before [[Construct]] https://bugs.webkit.org/show_bug.cgi?id=198976 Patch by Alexey Shvayka on 2019-08-16

[webkit-changes] [248788] trunk

2019-08-16 Thread ross . kirsling
Title: [248788] trunk Revision 248788 Author ross.kirsl...@sony.com Date 2019-08-16 13:12:56 -0700 (Fri, 16 Aug 2019) Log Message [Win] WebCoreTestSupport is too big to link https://bugs.webkit.org/show_bug.cgi?id=200820 Reviewed by Don Olmstead. * Source/cmake/OptionsWin.cmake: As

[webkit-changes] [248793] trunk

2019-08-16 Thread ysuzuki
Title: [248793] trunk Revision 248793 Author ysuz...@apple.com Date 2019-08-16 13:44:37 -0700 (Fri, 16 Aug 2019) Log Message [JSC] Promise.prototype.finally should accept non-promise objects https://bugs.webkit.org/show_bug.cgi?id=200829 Reviewed by Mark Lam. JSTests: *

[webkit-changes] [248792] trunk/Source/WebKit

2019-08-16 Thread cdumez
Title: [248792] trunk/Source/WebKit Revision 248792 Author cdu...@apple.com Date 2019-08-16 13:43:45 -0700 (Fri, 16 Aug 2019) Log Message Many WebStorage classes do not need to subclass ThreadSafeRefCounted https://bugs.webkit.org/show_bug.cgi?id=200821 Reviewed by Geoffrey Garen. Many

[webkit-changes] [248801] trunk/Source/WebCore

2019-08-16 Thread sbarati
Title: [248801] trunk/Source/WebCore Revision 248801 Author sbar...@apple.com Date 2019-08-16 16:02:16 -0700 (Fri, 16 Aug 2019) Log Message Unreviewed. When I rebased to land r248795, I had a bad merge in WHLSLStandardLibrary.txt where the bool matrix constructors ended up in the wrong

[webkit-changes] [248807] trunk/Source

2019-08-16 Thread rniwa
Title: [248807] trunk/Source Revision 248807 Author rn...@webkit.org Date 2019-08-16 17:41:04 -0700 (Fri, 16 Aug 2019) Log Message Don't use union to store NodeRareData* and RenderObject* https://bugs.webkit.org/show_bug.cgi?id=200744 Reviewed by Antti Koivisto. Source/WebCore: This

[webkit-changes] [248809] trunk/Source/WebKit

2019-08-16 Thread cdumez
Title: [248809] trunk/Source/WebKit Revision 248809 Author cdu...@apple.com Date 2019-08-16 18:06:06 -0700 (Fri, 16 Aug 2019) Log Message Drop StorageArea::setWorkQueue() member function https://bugs.webkit.org/show_bug.cgi?id=200832 Reviewed by Alex Christensen. Drop

[webkit-changes] [248808] trunk/Source

2019-08-16 Thread cdumez
Title: [248808] trunk/Source Revision 248808 Author cdu...@apple.com Date 2019-08-16 18:04:53 -0700 (Fri, 16 Aug 2019) Log Message LocalStorageDatabaseTracker does not need to subclass ThreadSafeRefCounted https://bugs.webkit.org/show_bug.cgi?id=200825 Reviewed by Alex Christensen.

[webkit-changes] [248791] trunk/Source/WebKit

2019-08-16 Thread dino
Title: [248791] trunk/Source/WebKit Revision 248791 Author d...@apple.com Date 2019-08-16 13:33:06 -0700 (Fri, 16 Aug 2019) Log Message Long pressing images with transparent backgrounds in dark mode causes a black background to appear around the image content

[webkit-changes] [248795] trunk

2019-08-16 Thread sbarati
Title: [248795] trunk Revision 248795 Author sbar...@apple.com Date 2019-08-16 13:59:29 -0700 (Fri, 16 Aug 2019) Log Message [WHLSL] Make operator== native and add bool matrices https://bugs.webkit.org/show_bug.cgi?id=200749 Reviewed by Myles C. Maxfield. Source/WebCore: This patch

[webkit-changes] [248799] trunk/Source

2019-08-16 Thread alancoon
Title: [248799] trunk/Source Revision 248799 Author alanc...@apple.com Date 2019-08-16 15:14:26 -0700 (Fri, 16 Aug 2019) Log Message Versioning. Modified Paths trunk/Source/_javascript_Core/Configurations/Version.xcconfig

[webkit-changes] [248802] trunk

2019-08-16 Thread mark . lam
Title: [248802] trunk Revision 248802 Author mark@apple.com Date 2019-08-16 16:49:27 -0700 (Fri, 16 Aug 2019) Log Message More missing exception checks in string comparison operators. https://bugs.webkit.org/show_bug.cgi?id=200844 Reviewed by Saam Barati. JSTests: *

[webkit-changes] [248804] trunk/Source/WebKit

2019-08-16 Thread cdumez
Title: [248804] trunk/Source/WebKit Revision 248804 Author cdu...@apple.com Date 2019-08-16 17:04:00 -0700 (Fri, 16 Aug 2019) Log Message LocalStorageDatabase should use inline initialization for its data members https://bugs.webkit.org/show_bug.cgi?id=200828 Reviewed by John Wilander.

[webkit-changes] [248767] trunk/Tools

2019-08-16 Thread commit-queue
Title: [248767] trunk/Tools Revision 248767 Author commit-qu...@webkit.org Date 2019-08-16 02:22:18 -0700 (Fri, 16 Aug 2019) Log Message Add shared-mime-info to WPE WebKit jhbuild https://bugs.webkit.org/show_bug.cgi?id=200768 Patch by Chris Lord on 2019-08-16 Reviewed by Carlos

[webkit-changes] [248765] trunk/Source/WebInspectorUI

2019-08-16 Thread drousso
Title: [248765] trunk/Source/WebInspectorUI Revision 248765 Author drou...@apple.com Date 2019-08-16 01:45:41 -0700 (Fri, 16 Aug 2019) Log Message Web Inspector: Elements: setting a breakpoint on a specific listener should enable the event listener

[webkit-changes] [248766] trunk/Source/WebInspectorUI

2019-08-16 Thread nvasilyev
Title: [248766] trunk/Source/WebInspectorUI Revision 248766 Author nvasil...@apple.com Date 2019-08-16 02:14:00 -0700 (Fri, 16 Aug 2019) Log Message Web Inspector: RTL: Console should be always LTR https://bugs.webkit.org/show_bug.cgi?id=200482 Reviewed by Joseph Pecoraro. *