[webkit-changes] [179772] trunk

2015-02-06 Thread said
772) --- trunk/LayoutTests/ChangeLog 2015-02-07 01:11:07 UTC (rev 179771) +++ trunk/LayoutTests/ChangeLog 2015-02-07 01:24:48 UTC (rev 179772) @@ -1,3 +1,15 @@ +2015-02-06 Said Abou-Hallawa sabouhall...@apple.com + +Invalid cast in WebCore::SVGAnimateElement::calculateAnimatedValue. +ht

[webkit-changes] [180128] trunk

2015-02-15 Thread said
unk/LayoutTests/ChangeLog 2015-02-15 20:44:07 UTC (rev 180127) +++ trunk/LayoutTests/ChangeLog 2015-02-16 00:13:16 UTC (rev 180128) @@ -1,3 +1,15 @@ +2015-02-15 Said Abou-Hallawa sabouhall...@apple.com + +Crash when accessing an item in SVGLengthList and then replacing it with a previous i

[webkit-changes] [180129] trunk

2015-02-15 Thread said
/WebCore/svg/properties/SVGPropertyTearOff.h Diff Modified: trunk/LayoutTests/ChangeLog (180128 => 180129) --- trunk/LayoutTests/ChangeLog 2015-02-16 00:13:16 UTC (rev 180128) +++ trunk/LayoutTests/ChangeLog 2015-02-16 02:08:39 UTC (rev 180129) @@ -1,5 +1,17 @@ 2015-02-15 Said Abou-Hall

[webkit-changes] [180133] trunk/Source/WebCore

2015-02-15 Thread said
ich is not used anywhere else. We need +to change it to ASSERT_UNUSED(). + +2015-02-15 Said Abou-Hallawa sabouhall...@apple.com + +Crash when accessing an item in SVGTransformList and then removing a previous item from this list. +https://bugs.webkit.org/show_bug.cgi

[webkit-changes] [181401] trunk/LayoutTests

2015-03-11 Thread said
/TestExpectations trunk/LayoutTests/platform/mac/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (181400 => 181401) --- trunk/LayoutTests/ChangeLog 2015-03-11 19:16:20 UTC (rev 181400) +++ trunk/LayoutTests/ChangeLog 2015-03-11 20:08:26 UTC (rev 181401) @@ -1,3 +1,17 @@ +2015-03-11 Said A

[webkit-changes] [180523] trunk/Source/WebCore

2015-02-23 Thread said
23:04:53 UTC (rev 180523) @@ -1,3 +1,17 @@ +2015-02-23 Said Abou-Hallawa sabouhall...@apple.com + +Drawing an SVG image into a canvas using drawImage() ignores globalAlpha. +https://bugs.webkit.org/show_bug.cgi?id=141729. + +Reviewed by Daniel Bates. + +Fix a bu

[webkit-changes] [180643] trunk

2015-02-25 Thread said
/svg/clip-path/clip-path-line-use-before-defined.svg Diff Modified: trunk/LayoutTests/ChangeLog (180642 => 180643) --- trunk/LayoutTests/ChangeLog 2015-02-25 22:37:17 UTC (rev 180642) +++ trunk/LayoutTests/ChangeLog 2015-02-25 23:05:20 UTC (rev 180643) @@ -1,3 +1,16 @@ +2015-02-25 Said A

[webkit-changes] [182750] trunk

2015-04-13 Thread said
750) --- trunk/LayoutTests/ChangeLog 2015-04-13 19:52:11 UTC (rev 182749) +++ trunk/LayoutTests/ChangeLog 2015-04-13 19:53:14 UTC (rev 182750) @@ -1,3 +1,19 @@ +2015-04-13 Said Abou-Hallawa sabouhall...@apple.com + +Canvas drawImage() has a security hole when the image isn't yet fully loa

[webkit-changes] [182767] trunk/LayoutTests

2015-04-13 Thread said
-image.html Diff Modified: trunk/LayoutTests/ChangeLog (182766 => 182767) --- trunk/LayoutTests/ChangeLog 2015-04-13 23:41:17 UTC (rev 182766) +++ trunk/LayoutTests/ChangeLog 2015-04-13 23:51:36 UTC (rev 182767) @@ -1,3 +1,17 @@ +2015-04-13 Said Abou-Hallawa sabouhall...@apple.com + +

[webkit-changes] [183960] trunk/Source/WebCore

2015-05-07 Thread said
960) @@ -1,3 +1,36 @@ +2015-05-07 Said Abou-Hallawa sabouhall...@apple.com + +Applying a filter on an SVG element, which is larger than 4096 pixels, causes this element to be rendered shifted to the left +https://bugs.webkit.org/show_bug.cgi?id=144335 + +Reviewed by Daniel Ba

[webkit-changes] [183968] trunk/Source/WebKit/mac

2015-05-07 Thread said
rce/WebKit/mac/ChangeLog 2015-05-08 01:08:54 UTC (rev 183968) @@ -1,3 +1,13 @@ +2015-05-07 Said Abou-Hallawa sabouhall...@apple.com + +Fix iPhone 6 iOS simulator Build. +following http://trac.webkit.org/changeset/183954. + +Reviewed by Daniel Bates. + +* WebV

[webkit-changes] [182876] trunk

2015-04-15 Thread said
/LayoutTests/ChangeLog (182875 => 182876) --- trunk/LayoutTests/ChangeLog 2015-04-16 02:25:28 UTC (rev 182875) +++ trunk/LayoutTests/ChangeLog 2015-04-16 02:50:29 UTC (rev 182876) @@ -1,3 +1,24 @@ +2015-04-15 Said Abou-Hallawa s...@apple.com + +Minimum font size pref breaks SVG text very ba

[webkit-changes] [182955] trunk/Source/WebCore

2015-04-17 Thread said
Diff Modified: trunk/Source/WebCore/ChangeLog (182954 => 182955) --- trunk/Source/WebCore/ChangeLog 2015-04-17 17:07:18 UTC (rev 182954) +++ trunk/Source/WebCore/ChangeLog 2015-04-17 17:30:43 UTC (rev 182955) @@ -1,3 +1,17 @@ +2015-04-17 Said Abou-Hallawa sabouhall...@apple.com + +

[webkit-changes] [185228] trunk/LayoutTests

2015-06-04 Thread said
Log 2015-06-05 00:12:53 UTC (rev 185228) @@ -1,3 +1,13 @@ +2015-06-04 Said Abou-Hallawa sabouhall...@apple.com + +Skip failed layout tests following http://trac.webkit.org/changeset/185207 +and https://trac.webkit.org/changeset/185220 +(https://bugs.webkit.org/show_bug.cgi

[webkit-changes] [185181] trunk/LayoutTests

2015-06-03 Thread said
181) @@ -1,5 +1,14 @@ 2015-06-03 Said Abou-Hallawa sabouhall...@apple.com +Skip webgl/useWhilePending.html on WebKit 1 following: +http://trac.webkit.org/changeset/185172 + +Unreviewed. + +* platform/mac-wk1/TestExpectations: + +2015-06-03 Said Abou-Hallawa sabouh

[webkit-changes] [185254] trunk/LayoutTests

2015-06-05 Thread said
015-06-05 18:09:58 UTC (rev 185254) @@ -1,5 +1,12 @@ 2015-06-05 Said Abou-Hallawa sabouhall...@apple.com +Layout test http/tests/misc/acid3.html times out on Yosemite WK2 Debug. +https://bugs.webkit.org/show_bug.cgi?id=145702 + +* platform/mac-wk2/TestExpectations: Mark

[webkit-changes] [185253] trunk/LayoutTests

2015-06-05 Thread said
unk/LayoutTests/ChangeLog 2015-06-05 17:19:47 UTC (rev 185252) +++ trunk/LayoutTests/ChangeLog 2015-06-05 17:41:55 UTC (rev 185253) @@ -1,3 +1,17 @@ +2015-06-05 Said Abou-Hallawa sabouhall...@apple.com + +[iOS] Rebaseline expected results for svg font tests + +Reviewed by Daniel Ba

[webkit-changes] [185119] trunk/LayoutTests

2015-06-02 Thread said
/text/font-weights-zh.html Diff Modified: trunk/LayoutTests/ChangeLog (185118 => 185119) --- trunk/LayoutTests/ChangeLog 2015-06-02 20:20:41 UTC (rev 185118) +++ trunk/LayoutTests/ChangeLog 2015-06-02 20:22:15 UTC (rev 185119) @@ -1,3 +1,23 @@ +2015-06-02 Said Abou-Hallawa sabouh

[webkit-changes] [185125] trunk/LayoutTests

2015-06-02 Thread said
sts/ChangeLog 2015-06-02 21:35:24 UTC (rev 185124) +++ trunk/LayoutTests/ChangeLog 2015-06-02 21:37:36 UTC (rev 185125) @@ -1,3 +1,12 @@ +2015-06-02 Said Abou-Hallawa sabouhall...@apple.com + +Fix Windows layout test failure following http://trac.webkit.org/changeset/185095 +(ht

[webkit-changes] [185157] trunk/LayoutTests

2015-06-03 Thread said
(185156 => 185157) --- trunk/LayoutTests/ChangeLog 2015-06-03 18:37:23 UTC (rev 185156) +++ trunk/LayoutTests/ChangeLog 2015-06-03 18:44:57 UTC (rev 185157) @@ -1,3 +1,15 @@ +2015-06-03 Said Abou-Hallawa sabouhall...@apple.com + +Add missing expected result files for GTK and EFL ports follow

[webkit-changes] [187504] trunk

2015-07-28 Thread said
-28 20:10:03 UTC (rev 187504) @@ -1,3 +1,17 @@ +2015-07-28 Said Abou-Hallawa sabouhall...@apple.com + +Crash happens when calling removeEventListener for an SVG element which has an instance inside a defs element of shadow tree +https://bugs.webkit.org/show_bug.cgi?id=147

[webkit-changes] [191731] trunk

2015-10-29 Thread said
-29 17:12:43 UTC (rev 191731) @@ -1,3 +1,17 @@ +2015-10-29 Said Abou-Hallawa <sabouhall...@apple.com> + +Exploitable crash happens when an SVG contains an indirect resource inheritance cycle +https://bugs.webkit.org/show_bug.cgi?id=150203 + +Reviewed by Bren

[webkit-changes] [191975] trunk/Tools

2015-11-03 Thread said
/webkitpy/common/config/watchlist Diff Modified: trunk/Tools/ChangeLog (191974 => 191975) --- trunk/Tools/ChangeLog 2015-11-03 21:40:20 UTC (rev 191974) +++ trunk/Tools/ChangeLog 2015-11-03 21:52:42 UTC (rev 191975) @@ -1,3 +1,9 @@ +2015-11-03 Said Abou-Hallawa <sabouhall...@app

[webkit-changes] [192550] trunk/PerformanceTests

2015-11-17 Thread said
boundaries. +this._position.y = 0; } } } Modified: trunk/PerformanceTests/ChangeLog (192549 => 192550) --- trunk/PerformanceTests/ChangeLog 2015-11-18 00:08:38 UTC (rev 192549) +++ trunk/PerformanceTests/ChangeLog 2015-11-18 00:16:56 UTC (rev 192550) @@ -1

[webkit-changes] [189741] trunk/LayoutTests

2015-09-14 Thread said
sts/ChangeLog 2015-09-14 17:38:48 UTC (rev 189741) @@ -1,3 +1,10 @@ +2015-09-14 Said Abou-Hallawa <sabouhall...@apple.com> + +Unreviewed, expect css3/flexbox/image-percent-max-height.html to fail on iOS. +The test is already expected to fail on mac, windows and gtk. + +* pla

[webkit-changes] [189742] trunk/LayoutTests

2015-09-14 Thread said
-09-14 17:57:27 UTC (rev 189742) @@ -1,5 +1,12 @@ 2015-09-14 Said Abou-Hallawa <sabouhall...@apple.com> +Unreviewed, skip fast/text/international/system-language for now. +WebKitTestRunner declarative language setting is broken for iOS. + +* platform/ios-

[webkit-changes] [190273] trunk/Source/WebCore

2015-09-27 Thread said
Title: [190273] trunk/Source/WebCore Revision 190273 Author s...@apple.com Date 2015-09-27 20:43:00 -0700 (Sun, 27 Sep 2015) Log Message Rename all the variables and parameters of type HTMLImageElement in CanvasRenderingContext2D.cpp from 'image' to 'imageElement' Patch by Said Abou

[webkit-changes] [189548] trunk/LayoutTests

2015-09-09 Thread said
:22 UTC (rev 189547) +++ trunk/LayoutTests/ChangeLog 2015-09-09 20:58:44 UTC (rev 189548) @@ -1,3 +1,12 @@ +2015-09-09 Said Abou-Hallawa <sabouhall...@apple.com> + +Mark http/tests/css/link-css-disabled-value-with-slow-loading-sheet.html as flaky on Windows + +This test

[webkit-changes] [192714] trunk/Tools

2015-11-20 Thread said
trunk/Tools/Scripts/webkitpy/common/config/watchlist Diff Modified: trunk/Tools/ChangeLog (192713 => 192714) --- trunk/Tools/ChangeLog 2015-11-21 02:29:23 UTC (rev 192713) +++ trunk/Tools/ChangeLog 2015-11-21 02:51:51 UTC (rev 192714) @@ -1,3 +1,9 @@ +2015-11-20 Said Abou-Hallawa <sab

[webkit-changes] [196381] trunk/PerformanceTests

2016-02-10 Thread said
return filterList[this.randomInt(0, filterList.length)]; +}, + rotatingColor: function(cycleLengthMs, saturation, lightness) { return "hsl(" Modified: trunk/PerformanceTests/ChangeLog (196380 => 196381) --- trunk/PerformanceTests/ChangeLog 2016-02-10 20:33

[webkit-changes] [197125] trunk/Source/WebCore

2016-02-25 Thread said
properties/SVGAnimatedPathSegListPropertyTearOff.h Diff Modified: trunk/Source/WebCore/ChangeLog (197124 => 197125) --- trunk/Source/WebCore/ChangeLog 2016-02-25 19:36:52 UTC (rev 197124) +++ trunk/Source/WebCore/ChangeLog 2016-02-25 19:55:55 UTC (rev 197125) @@ -1,3 +1,49 @@ +2016-02-25 Said Abou-Hallawa <sabouh

[webkit-changes] [196669] trunk

2016-02-16 Thread said
016-02-16 23:47:06 UTC (rev 196668) +++ trunk/LayoutTests/ChangeLog 2016-02-16 23:59:25 UTC (rev 196669) @@ -1,3 +1,16 @@ +2016-02-16 Said Abou-Hallawa <sabouhall...@apple.com> + +REGRESSION (r190430): WTFCrashWithSecurityImplication in:void SVGRootInlineBox::layoutCharactersIn

[webkit-changes] [196670] trunk/Source/WebCore

2016-02-16 Thread said
-16 23:59:25 UTC (rev 196669) +++ trunk/Source/WebCore/ChangeLog 2016-02-17 00:00:54 UTC (rev 196670) @@ -1,5 +1,26 @@ 2016-02-16 Said Abou-Hallawa <sabouhall...@apple.com> +REGRESSION(r196268): WTFCrashWithSecurityImplication on SVG path animation tests +https://bugs.w

[webkit-changes] [197967] trunk/Source/WebCore

2016-03-10 Thread said
Title: [197967] trunk/Source/WebCore Revision 197967 Author s...@apple.com Date 2016-03-10 16:32:51 -0800 (Thu, 10 Mar 2016) Log Message REGRESSION: GuardMallloc crash in SVGListPropertyTearOff::processIncomingListItemWrapper https://bugs.webkit.org/show_bug.cgi?id=154969 Patch by Said

[webkit-changes] [199243] trunk/Source/WebCore

2016-04-08 Thread said
Title: [199243] trunk/Source/WebCore Revision 199243 Author s...@apple.com Date 2016-04-08 13:07:51 -0700 (Fri, 08 Apr 2016) Log Message Timing attack on SVG feComposite filter circumvents same-origin policy https://bugs.webkit.org/show_bug.cgi?id=154338 Patch by Said Abou-Hallawa

[webkit-changes] [206635] trunk

2016-09-30 Thread said
Diff Modified: trunk/LayoutTests/ChangeLog (206634 => 206635) --- trunk/LayoutTests/ChangeLog 2016-09-30 14:20:25 UTC (rev 206634) +++ trunk/LayoutTests/ChangeLog 2016-09-30 16:01:36 UTC (rev 206635) @@ -1,3 +1,13 @@ +2016-09-30 Said Abou-Hallawa <sabouhall...@apple.com> + +

[webkit-changes] [206637] trunk/Source/WebCore

2016-09-30 Thread said
-30 Said Abou-Hallawa <sabouhall...@apple.com> + +Unreviewed, fix 32-bit build. + +* loader/cache/CachedImage.cpp: +(WebCore::CachedImage::decodedSizeChanged): + 2016-09-30 Youenn Fablet <you...@apple.com> FetchBody should use UTF8Encoding to e

[webkit-changes] [207471] trunk

2016-10-18 Thread said
Log 2016-10-18 17:41:14 UTC (rev 207471) @@ -1,3 +1,18 @@ +2016-10-18 Said Abou-Hallawa <sabouhall...@apple.com> + +SVGCSSParser: m_implicitShorthand value is not reset after adding the shorthand property +https://bugs.webkit.org/show_bug.cgi?id=116470 + +

[webkit-changes] [208156] trunk/Tools

2016-10-31 Thread said
/Scripts/webkitpy/common/config/contributors.json Diff Modified: trunk/Tools/ChangeLog (208155 => 208156) --- trunk/Tools/ChangeLog 2016-10-31 16:58:47 UTC (rev 208155) +++ trunk/Tools/ChangeLog 2016-10-31 17:07:39 UTC (rev 208156) @@ -1,3 +1,9 @@ +2016-10-31 Said Abou-Hallawa <sab

[webkit-changes] [207216] trunk/Source/WebCore

2016-10-12 Thread said
-12 Said Abou-Hallawa <sabouhall...@apple.com> + +Unreviewed, fix Windows build break after r207182. + +* platform/graphics/cg/ImageDecoderCG.cpp: + 2016-10-12 Chris Dumez <cdu...@apple.com> Update remaining DOM events to stop using legacy [Constructo

[webkit-changes] [214125] trunk/Source

2017-03-17 Thread said
/filters/FilterEffect.h Diff Modified: trunk/Source/WTF/ChangeLog (214124 => 214125) --- trunk/Source/WTF/ChangeLog 2017-03-17 21:31:49 UTC (rev 214124) +++ trunk/Source/WTF/ChangeLog 2017-03-17 21:51:03 UTC (rev 214125) @@ -1,3 +1,19 @@ +2017-03-17 Said Abou-Hallawa <sabouhall...@app

[webkit-changes] [219125] trunk/Source/WebCore

2017-07-04 Thread said
1,3 +1,10 @@ +2017-07-04 Said Abou-Hallawa <sabouhall...@apple.com> + +Unreviewed, review follow-up after r218961 + +* platform/graphics/BitmapImage.cpp: +(WebCore::BitmapImage::updateFromSettings): + 2017-07-04 Antti Koivisto <an...@apple.com> R

[webkit-changes] [215804] trunk/Source/WebCore

2017-04-26 Thread said
-26 16:13:02 UTC (rev 215803) +++ trunk/Source/WebCore/ChangeLog 2017-04-26 16:24:34 UTC (rev 215804) @@ -1,3 +1,15 @@ +2017-04-26 Said Abou-Hallawa <sabouhall...@apple.com> + +Attempt to fix a PLT regression. + +Unreviewed. + +Disable async decoding for large im

[webkit-changes] [215851] trunk/Source/WebCore

2017-04-26 Thread said
01:17:01 UTC (rev 215850) +++ trunk/Source/WebCore/ChangeLog 2017-04-27 01:26:08 UTC (rev 215851) @@ -1,3 +1,16 @@ +2017-04-26 Said Abou-Hallawa <sabouhall...@apple.com> + +Attempt to fix a PLT regression. + + +Unreviewed. + +Disable passing the TypeIdent

[webkit-changes] [215905] trunk/Source/WebCore

2017-04-27 Thread said
-04-27 23:24:58 UTC (rev 215904) +++ trunk/Source/WebCore/ChangeLog 2017-04-27 23:36:45 UTC (rev 215905) @@ -1,3 +1,16 @@ +2017-04-27 Said Abou-Hallawa <sabouhall...@apple.com> + +Attempt to fix a PLT regression on Mac + + +Unreviewed. + +Disabl

[webkit-changes] [217316] trunk/Source/WebCore

2017-05-23 Thread said
Log 2017-05-24 00:33:23 UTC (rev 217315) +++ trunk/Source/WebCore/ChangeLog 2017-05-24 01:06:25 UTC (rev 217316) @@ -1,3 +1,16 @@ +2017-05-23 Said Abou-Hallawa <sabouhall...@apple.com> + +[iOS] Speculative fix for a PLT regression + + +Unreviewed. + +

[webkit-changes] [216273] trunk/Source/WebCore

2017-05-05 Thread said
Modified: trunk/Source/WebCore/ChangeLog (216272 => 216273) --- trunk/Source/WebCore/ChangeLog 2017-05-05 21:15:51 UTC (rev 216272) +++ trunk/Source/WebCore/ChangeLog 2017-05-05 21:35:54 UTC (rev 216273) @@ -1,3 +1,27 @@ +2017-05-05 Said Abou-Hallawa <sabouhall...@apple.com> + +

[webkit-changes] [216305] trunk/Source/WebCore

2017-05-05 Thread said
/graphics/BitmapImage.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (216304 => 216305) --- trunk/Source/WebCore/ChangeLog 2017-05-06 01:59:14 UTC (rev 216304) +++ trunk/Source/WebCore/ChangeLog 2017-05-06 03:27:16 UTC (rev 216305) @@ -1,3 +1,23 @@ +2017-05-05 Said Abou-Hallawa <sab

[webkit-changes] [216192] trunk/LayoutTests

2017-05-04 Thread said
1,3 +1,9 @@ +2017-05-04 Said Abou-Hallawa <sabouhall...@apple.com> + +Unreviewed: Replace Windows line ending (CRLF) by Unix line ending (CR). + +* compositing/video/video-with-invalid-source.html: + 2017-05-04 Ryan Haddad <ryanhad...@apple.com> Skip med

[webkit-changes] [216194] trunk/LayoutTests

2017-05-04 Thread said
,12 @@ Unreviewed: Replace Windows line ending (CRLF) by Unix line ending (CR). +* plugins/windowless_plugin_paint_test.html: + +2017-05-04 Said Abou-Hallawa <sabouhall...@apple.com> + +Unreviewed: Replace Windows line ending (CRLF) by Unix line ending (CR). + * co

[webkit-changes] [216471] trunk/Source/WebCore

2017-05-08 Thread said
1,3 +1,21 @@ +2017-05-08 Said Abou-Hallawa <sabouhall...@apple.com> + +The Incomplete asynchronously decoded image frame should be decoded every time it's drawn +https://bugs.webkit.org/show_bug.cgi?id=170836 + +Reviewed by Tim Horton. + +The asynchronously deco

[webkit-changes] [222304] trunk

2017-09-20 Thread said
304) @@ -1,3 +1,13 @@ +2017-09-20 Said Abou-Hallawa <sabouhall...@apple.com> + +REGRESSION(r191731): SVGPatternElement can only reference another SVGPatternElement in the same SVG document +https://bugs.webkit.org/show_bug.cgi?id=176221 + +Reviewed by Tim Horton. + +

[webkit-changes] [225586] trunk/Source/WebCore/ChangeLog

2017-12-06 Thread said
Title: [225586] trunk/Source/WebCore/ChangeLog Revision 225586 Author s...@apple.com Date 2017-12-06 11:56:13 -0800 (Wed, 06 Dec 2017) Log Message Storage Access API: Make document.hasStorageAccess a function and always allow access for same-origin iframes

[webkit-changes] [232941] trunk

2018-06-18 Thread said
940) +++ trunk/LayoutTests/ChangeLog 2018-06-18 19:28:33 UTC (rev 232941) @@ -1,3 +1,13 @@ +2018-06-18 Said Abou-Hallawa + +Document should not be mutated under SMILTimeContainer::updateAnimations() +https://bugs.webkit.org/show_bug.cgi?id=186658 + +Reviewed by Simon Fra

[webkit-changes] [232780] trunk/LayoutTests

2018-06-12 Thread said
-target.html Diff Modified: trunk/LayoutTests/ChangeLog (232779 => 232780) --- trunk/LayoutTests/ChangeLog 2018-06-12 22:10:01 UTC (rev 232779) +++ trunk/LayoutTests/ChangeLog 2018-06-12 22:28:25 UTC (rev 232780) @@ -1,3 +1,14 @@ +2018-06-12 Said Abou-Hallawa + +Unreviewed follo

[webkit-changes] [233366] trunk

2018-06-29 Thread said
-06-25 Said Abou-Hallawa + +Infinite loop if a element references its ancestor and the DOMNodeInserted event handler of one its ancestor's descents updates the document style +https://bugs.webkit.org/show_bug.cgi?id=186925 + +Reviewed by Antti Koivisto. + +* svg/

[webkit-changes] [228256] trunk/LayoutTests

2018-02-07 Thread said
rev 228256) @@ -1,3 +1,12 @@ +2018-02-07 Said Abou-Hallawa <sabouhall...@apple.com> + +[iOS] Skip webgl/webgl-texture-image-buffer-reuse.html +https://bugs.webkit.org/show_bug.cgi?id=182592 + +Unreviewed test gardening. + +* platform/ios/TestExpectations: + 2

[webkit-changes] [233056] trunk

2018-06-21 Thread said
3056) @@ -1,3 +1,13 @@ +2018-06-20 Said Abou-Hallawa + +RenderSVGInline has to be inline always regardless of its css display value +https://bugs.webkit.org/show_bug.cgi?id=186656 + +Reviewed by Zalan Bujtas. + +* svg/dom/svg-inline-text-display-block-crash-expect

[webkit-changes] [230552] trunk/Source/WTF

2018-04-11 Thread said
3:26 UTC (rev 230551) +++ trunk/Source/WTF/ChangeLog 2018-04-12 01:09:15 UTC (rev 230552) @@ -1,3 +1,16 @@ +2018-04-11 Said Abou-Hallawa <sabouhall...@apple.com> + +Unreviewed, rolling out r230523. + +Introduced MotionMark regression + +Reverted changeset: + +

[webkit-changes] [230063] trunk/Source/WebCore

2018-03-28 Thread said
:13 UTC (rev 230063) @@ -1,3 +1,17 @@ +2018-03-28 Said Abou-Hallawa <sabouhall...@apple.com> + +The SVGAnimatedProperty wrappers have to be detached from the referenced values before the SVGAnimatedType is deleted +https://bugs.webkit.org/show_bug.cgi?id=183972 + +

[webkit-changes] [230172] trunk/LayoutTests

2018-04-02 Thread said
:42:18 UTC (rev 230172) @@ -1,3 +1,15 @@ +2018-04-02 Said Abou-Hallawa <sabouhall...@apple.com> + +Followup(r230063): Add test a layout test for https://bugs.webkit.org/show_bug.cgi?id=183972 +https://bugs.webkit.org/show_bug.cgi?id=184162 + +Reviewed by Dan

[webkit-changes] [236991] trunk

2018-10-09 Thread said
(236990 => 236991) --- trunk/LayoutTests/ChangeLog 2018-10-09 23:46:12 UTC (rev 236990) +++ trunk/LayoutTests/ChangeLog 2018-10-09 23:59:52 UTC (rev 236991) @@ -1,3 +1,13 @@ +2018-10-09 Said Abou-Hallawa + +REGRESSION(r234620): SVGLangSpace::svgAttributeChanged() should invalid

[webkit-changes] [239873] trunk/Source/WTF

2019-01-11 Thread said
873) --- trunk/Source/WTF/ChangeLog 2019-01-11 21:57:46 UTC (rev 239872) +++ trunk/Source/WTF/ChangeLog 2019-01-11 22:01:07 UTC (rev 239873) @@ -1,3 +1,21 @@ +2019-01-11 Said Abou-Hallawa + +WorkQueue::concurrentApply() passes a raw pointer to a temporary String to Thread::cre

[webkit-changes] [243259] trunk/Source/WebCore

2019-03-20 Thread said
(rev 243259) @@ -1,3 +1,110 @@ +2019-03-20 Said Abou-Hallawa + +Remove the SVG tear off objects for SVGColorAnimator +https://bugs.webkit.org/show_bug.cgi?id=196025 + +Reviewed by Simon Fraser. + +SVG attributes like "fill" and "stroke"

[webkit-changes] [243532] trunk/Source/WebCore

2019-03-26 Thread said
:05:32 UTC (rev 243532) @@ -1,3 +1,12 @@ +2019-03-26 Said Abou-Hallawa + +Unreviewed Windows build fix +https://bugs.webkit.org/show_bug.cgi?id=196083 + + +* svg/SVGAnimatorFactory.h: +(WebCore::SVGAnimatorFactory::isSupportedAttributeType): + 2019-03

[webkit-changes] [242515] trunk

2019-03-05 Thread said
-animPathSegList.svg Diff Modified: trunk/LayoutTests/ChangeLog (242514 => 242515) --- trunk/LayoutTests/ChangeLog 2019-03-05 22:19:59 UTC (rev 242514) +++ trunk/LayoutTests/ChangeLog 2019-03-05 23:12:51 UTC (rev 242515) @@ -1,3 +1,14 @@ +2019-03-05 Said Abou-Hall

[webkit-changes] [243336] trunk

2019-03-21 Thread said
Title: [243336] trunk Revision 243336 Author s...@apple.com Date 2019-03-21 15:21:58 -0700 (Thu, 21 Mar 2019) Log Message Remove the SVG tear off objects for SVGPoint, SVGPointList and SVGAnimatedPointList https://bugs.webkit.org/show_bug.cgi?id=195905 Source/WebCore: Patch by Said

[webkit-changes] [240949] trunk

2019-02-04 Thread said
: trunk/Source/WebCore/ChangeLog (240948 => 240949) --- trunk/Source/WebCore/ChangeLog 2019-02-05 00:28:24 UTC (rev 240948) +++ trunk/Source/WebCore/ChangeLog 2019-02-05 00:47:17 UTC (rev 240949) @@ -1,3 +1,17 @@ +2019-02-04 Said Abou-Hallawa + +[CG] Enable setAdditionalSupportedImageTy

[webkit-changes] [244276] trunk

2019-04-15 Thread said
sts/ChangeLog 2019-04-15 18:47:38 UTC (rev 244275) +++ trunk/LayoutTests/ChangeLog 2019-04-15 18:54:21 UTC (rev 244276) @@ -1,3 +1,13 @@ +2019-04-15 Said Abou-Hallawa + +ASSERT fires when removing a disallowed clone from the shadow tree without reseting its corresponding element +ht

[webkit-changes] [245469] trunk

2019-05-17 Thread said
unk/LayoutTests/ChangeLog 2019-05-17 17:22:40 UTC (rev 245468) +++ trunk/LayoutTests/ChangeLog 2019-05-17 17:26:05 UTC (rev 245469) @@ -1,3 +1,13 @@ +2019-05-16 Said Abou-Hallawa + +SVGElement should detach itself from all its properties before it is deleted +https://bugs.webkit.

[webkit-changes] [246170] trunk

2019-06-06 Thread said
rev 246170) @@ -1,3 +1,14 @@ +2019-06-05 Said Abou-Hallawa + +REGRESSION (r243121): Load event should not be fired while animating the 'externalResourcesRequired' attribute +https://bugs.webkit.org/show_bug.cgi?id=198576 + +Reviewed by Simon Fraser. + +* svg/animati

[webkit-changes] [245292] trunk/LayoutTests

2019-05-14 Thread said
sts/ChangeLog 2019-05-14 18:27:14 UTC (rev 245292) @@ -1,3 +1,11 @@ +2019-05-14 Said Abou-Hallawa + +Unreviewed: fix test failures after r245280. + +* platform/mac-wk2/TestExpectations: +Animating HEICS images is supported only on post macOS Mojave. So these +te

[webkit-changes] [247121] trunk/Source/WebCore

2019-07-03 Thread said
/WebCore/ChangeLog (247120 => 247121) --- trunk/Source/WebCore/ChangeLog 2019-07-04 00:42:30 UTC (rev 247120) +++ trunk/Source/WebCore/ChangeLog 2019-07-04 00:49:01 UTC (rev 247121) @@ -1,3 +1,24 @@ +2019-07-03 Said Abou-Hallawa + +The destructor of CSSAnimationControllerPrivate m

[webkit-changes] [244491] trunk

2019-04-20 Thread said
Modified: trunk/LayoutTests/ChangeLog (244490 => 244491) --- trunk/LayoutTests/ChangeLog 2019-04-20 23:46:25 UTC (rev 244490) +++ trunk/LayoutTests/ChangeLog 2019-04-21 00:03:44 UTC (rev 244491) @@ -1,3 +1,13 @@ +2019-04-20 Said Abou-Hallawa + +REGRESSION (r243

[webkit-changes] [244503] trunk/Source/WebCore

2019-04-22 Thread said
Title: [244503] trunk/Source/WebCore Revision 244503 Author s...@apple.com Date 2019-04-22 11:17:33 -0700 (Mon, 22 Apr 2019) Log Message Mark SVGStringList properties '[SameObject]' in the IDL files Followup to https://bugs.webkit.org/show_bug.cgi?id=197137 Patch by Said Abou-Hallawa

[webkit-changes] [249187] trunk/Source/WebCore

2019-08-27 Thread said
rev 249186) +++ trunk/Source/WebCore/ChangeLog 2019-08-28 01:22:37 UTC (rev 249187) @@ -1,3 +1,13 @@ +2019-08-27 Said Abou-Hallawa + +Unreviewed. Build fix after r249175. + +Fix the condition which generates the declaration of vm in +GenerateGetOwnPropertySlotByIn

[webkit-changes] [249026] trunk

2019-08-22 Thread said
Log 2019-08-22 21:13:38 UTC (rev 249026) @@ -1,3 +1,16 @@ +2019-08-22 Said Abou-Hallawa + +Crash may happen when an SVG element references the root element +https://bugs.webkit.org/show_bug.cgi?id=201014 + +Reviewed by Ryosuke Niwa. + +Ensure the cyclic refere

[webkit-changes] [249579] trunk/LayoutTests

2019-09-06 Thread said
: trunk/LayoutTests/ChangeLog (249578 => 249579) --- trunk/LayoutTests/ChangeLog 2019-09-06 17:04:13 UTC (rev 249578) +++ trunk/LayoutTests/ChangeLog 2019-09-06 17:16:27 UTC (rev 249579) @@ -1,3 +1,13 @@ +2019-09-06 Said Abou-Hallawa + +Unreviewed, fix typo in r249216 + +Also cha

[webkit-changes] [250488] trunk

2019-09-28 Thread said
/ChangeLog (250487 => 250488) --- trunk/LayoutTests/ChangeLog 2019-09-29 01:59:27 UTC (rev 250487) +++ trunk/LayoutTests/ChangeLog 2019-09-29 05:16:58 UTC (rev 250488) @@ -1,3 +1,13 @@ +2019-09-28 Said Abou-Hallawa + +Crash when removing the target element while animating its attribu

[webkit-changes] [251994] trunk/LayoutTests

2019-11-04 Thread said
unk/LayoutTests/ChangeLog 2019-11-04 17:23:44 UTC (rev 251994) @@ -1,3 +1,13 @@ +2019-11-04 Said Abou-Hallawa + +Flaky Test: imported/w3c/web-platform-tests/svg/text/visualtests/text-inline-size-003-visual.svg +https://bugs.webkit.org/show_bug.cgi?id=203172 + +Unreviewed Test Garden

[webkit-changes] [251957] trunk

2019-11-01 Thread said
unk/LayoutTests/ChangeLog 2019-11-02 00:14:40 UTC (rev 251957) @@ -1,3 +1,13 @@ +2019-11-01 Said Abou-Hallawa + +SVG pair properties must be detached from their owner before it's deleted +https://bugs.webkit.org/show_bug.cgi?id=203545 + +Reviewed by Simon Fra

[webkit-changes] [256512] trunk

2020-02-13 Thread said
Title: [256512] trunk Revision 256512 Author s...@apple.com Date 2020-02-13 09:11:28 -0800 (Thu, 13 Feb 2020) Log Message Unreviewed, rolling out r255158, 255405 and r255486 Caused test flakiness and PLT regression. Patch by Said Abou-Hallawa on 2020-02-13 Source/WebCore

[webkit-changes] [256463] trunk

2020-02-12 Thread said
unk/LayoutTests/ChangeLog 2020-02-12 19:27:04 UTC (rev 256462) +++ trunk/LayoutTests/ChangeLog 2020-02-12 19:31:11 UTC (rev 256463) @@ -1,3 +1,20 @@ +2020-02-12 Said Abou-Hallawa + +REGRESSION (r255158): http/tests/frame-throttling/raf-throttle-in-cross-origin-subframe.html is a flaky fail

[webkit-changes] [256526] trunk/LayoutTests

2020-02-13 Thread said
1,3 +1,12 @@ +2020-02-13 Said Abou-Hallawa + +WebP image format is not supported +https://bugs.webkit.org/show_bug.cgi?id=192672 + +Unreviewed test gardening + +* platform/mac/TestExpectations: + 2020-02-13 Jacob Uphoff [ iOS ] imported/w3c/IndexedDB-priv

[webkit-changes] [256192] trunk

2020-02-10 Thread said
sts/ChangeLog 2020-02-10 18:21:56 UTC (rev 256192) @@ -1,3 +1,13 @@ +2020-02-10 Said Abou-Hallawa + +Unreachable code hit in WebCore::Shape::createShape +https://bugs.webkit.org/show_bug.cgi?id=207399 + +Reviewed by Darin Adler. + +* css3/shapes/shape-outside-p

[webkit-changes] [260120] trunk/Source/WebKit

2020-04-15 Thread said
cess.sb.in Diff Modified: trunk/Source/WebKit/ChangeLog (260119 => 260120) --- trunk/Source/WebKit/ChangeLog 2020-04-15 07:02:55 UTC (rev 260119) +++ trunk/Source/WebKit/ChangeLog 2020-04-15 08:53:39 UTC (rev 260120) @@ -1,3 +1,16 @@ +2020-04-15 Said Abou-Hallawa + +Unreviewed, reve

[webkit-changes] [258459] trunk

2020-03-13 Thread said
/ChangeLog (258458 => 258459) --- trunk/LayoutTests/ChangeLog 2020-03-14 02:10:54 UTC (rev 258458) +++ trunk/LayoutTests/ChangeLog 2020-03-14 03:11:34 UTC (rev 258459) @@ -1,3 +1,13 @@ +2020-03-13 Said Abou-Hallawa + +SVGMatrix should have the access right of its owner SVGTransform alw

[webkit-changes] [258993] trunk/LayoutTests

2020-03-25 Thread said
:35 UTC (rev 258992) +++ trunk/LayoutTests/ChangeLog 2020-03-25 17:15:12 UTC (rev 258993) @@ -1,3 +1,21 @@ +2020-03-25 Said Abou-Hallawa + +Layout Test fast/images/async-image-multiple-clients-repaint.html is flaky +https://bugs.webkit.org/show_bug.cgi?id=202

[webkit-changes] [259003] trunk/LayoutTests

2020-03-25 Thread said
003) --- trunk/LayoutTests/ChangeLog 2020-03-25 19:16:09 UTC (rev 259002) +++ trunk/LayoutTests/ChangeLog 2020-03-25 19:29:30 UTC (rev 259003) @@ -1,3 +1,16 @@ +2020-03-25 Said Abou-Hallawa + +Layout Test fast/images/async-image-multiple-clients-repaint.html is flaky +ht

[webkit-changes] [259434] trunk/LayoutTests

2020-04-02 Thread said
00:19:20 UTC (rev 259434) @@ -1,3 +1,15 @@ +2020-04-02 Said Abou-Hallawa + +[ iOS wk2 ] fast/images/exif-orientation-background-image-repeat.html is flaky failing. + + +Unreviewed test gardening. + +Add "image-rendering: pixelated;" to the elements which

[webkit-changes] [260870] trunk/Source/WebCore

2020-04-28 Thread said
/ScriptedAnimationController.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (260869 => 260870) --- trunk/Source/WebCore/ChangeLog 2020-04-29 05:29:28 UTC (rev 260869) +++ trunk/Source/WebCore/ChangeLog 2020-04-29 05:36:17 UTC (rev 260870) @@ -1,3 +1,16 @@ +2020-04-28 Said Abou-Hall

[webkit-changes] [261732] trunk/Source/WebCore

2020-05-15 Thread said
unk/Source/WebCore/ChangeLog 2020-05-15 07:00:19 UTC (rev 261732) @@ -1,3 +1,12 @@ +2020-05-14 Said Abou-Hallawa + +Unreviewed. Fix build warning after r261113 + +Remove unused variable. + +* dom/ScriptedAnimationController.cpp: +(WebCore::ScriptedAnimationControl

[webkit-changes] [258895] trunk/LayoutTests

2020-03-23 Thread said
unk/LayoutTests/ChangeLog 2020-03-24 01:31:38 UTC (rev 258894) +++ trunk/LayoutTests/ChangeLog 2020-03-24 01:40:53 UTC (rev 258895) @@ -1,3 +1,13 @@ +2020-03-23 Said Abou-Hallawa + +Layout Test imported/w3c/web-platform-tests/hr-time/test_cross_frame_start.html is a flaky failure +ht

[webkit-changes] [258960] trunk/LayoutTests

2020-03-24 Thread said
-24 Said Abou-Hallawa + +[ macOS ] fast/images/slower-decoding-than-animation-image.html is flaky failing +https://bugs.webkit.org/show_bug.cgi?id=207859 + +Unreviewed tiny follow-up to make the test more reliable on slow bots. + +* fast/images/slower-decoding-t

[webkit-changes] [266452] trunk/Source

2020-09-02 Thread said
m/graphics/cg/ImageDecoderCG.cpp Diff Modified: trunk/Source/WTF/ChangeLog (266451 => 266452) --- trunk/Source/WTF/ChangeLog 2020-09-02 06:57:07 UTC (rev 266451) +++ trunk/Source/WTF/ChangeLog 2020-09-02 08:04:12 UTC (rev 266452) @@ -1,3 +1,17 @@ +2020-09-02 Said Abou-Hallawa + +Unreviewed, r

[webkit-changes] [269084] trunk/Source

2020-10-27 Thread said
UTC (rev 269084) @@ -1,3 +1,39 @@ +2020-10-27 Said Abou-Hallawa + +Make RenderingMode a bool enum and remove ShouldAccelerate +https://bugs.webkit.org/show_bug.cgi?id=218264 + +Reviewed by Tim Horton. + +Convert RenderingMode back to be a bool enum. ShouldAcceler

[webkit-changes] [269123] trunk/Source/WebKit

2020-10-28 Thread said
/RemoteImageBufferProxy.h Diff Modified: trunk/Source/WebKit/ChangeLog (269122 => 269123) --- trunk/Source/WebKit/ChangeLog 2020-10-28 21:04:10 UTC (rev 269122) +++ trunk/Source/WebKit/ChangeLog 2020-10-28 21:09:12 UTC (rev 269123) @@ -1,3 +1,15 @@ +2020-10-28 Said Abou-Hallawa + +[GPU Proc

[webkit-changes] [270479] trunk/Source/WebCore

2020-12-05 Thread said
Modified: trunk/Source/WebCore/ChangeLog (270478 => 270479) --- trunk/Source/WebCore/ChangeLog 2020-12-05 22:17:10 UTC (rev 270478) +++ trunk/Source/WebCore/ChangeLog 2020-12-06 00:22:09 UTC (rev 270479) @@ -1,3 +1,15 @@ +2020-12-05 Said Abou-Hallawa + +REGRESSION(r270458): Crash load

[webkit-changes] [270444] trunk/Source

2020-12-04 Thread said
ngeLog (270443 => 270444) --- trunk/Source/WebCore/ChangeLog 2020-12-04 19:44:52 UTC (rev 270443) +++ trunk/Source/WebCore/ChangeLog 2020-12-04 19:47:56 UTC (rev 270444) @@ -1,3 +1,21 @@ +2020-12-04 Said Abou-Hallawa + +[GPU Process] Share the NativeImage with GPU Proces

[webkit-changes] [270470] trunk/Source/WebKit

2020-12-04 Thread said
Kit/ChangeLog 2020-12-05 05:59:55 UTC (rev 270470) @@ -1,3 +1,17 @@ +2020-12-04 Said Abou-Hallawa + +[GPU Process] Remove ConcreteShareableImageBuffer +https://bugs.webkit.org/show_bug.cgi?id=219563 + +Reviewed by Simon Fraser. + +Delete this class since the o

  1   2   3   4   5   >