Title: [187170] trunk/Source/WebCore
- Revision
- 187170
- Author
- wenson_hs...@apple.com
- Date
- 2015-07-22 11:47:12 -0700 (Wed, 22 Jul 2015)
Log Message
Search fields render placeholder text improperly.
https://bugs.webkit.org/show_bug.cgi?id=147192
<rdar://problem/21901076>
Reviewed by Alexey Proskuryakov.
Due to changes in the way AppKit renders search inputs, we must now explicitly
set the placeholder text of a search input rendered using the Mac theme to be
an empty string when rendering the search input box (not including the actual
placeholder text).
* rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::setSearchCellState): Force the placeholder text of
the NSSearchFieldCell for the Mac theme to be an empty string.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (187169 => 187170)
--- trunk/Source/WebCore/ChangeLog 2015-07-22 18:14:40 UTC (rev 187169)
+++ trunk/Source/WebCore/ChangeLog 2015-07-22 18:47:12 UTC (rev 187170)
@@ -1,3 +1,20 @@
+2015-07-22 Wenson Hsieh <wenson_hs...@apple.com>
+
+ Search fields render placeholder text improperly.
+ https://bugs.webkit.org/show_bug.cgi?id=147192
+ <rdar://problem/21901076>
+
+ Reviewed by Alexey Proskuryakov.
+
+ Due to changes in the way AppKit renders search inputs, we must now explicitly
+ set the placeholder text of a search input rendered using the Mac theme to be
+ an empty string when rendering the search input box (not including the actual
+ placeholder text).
+
+ * rendering/RenderThemeMac.mm:
+ (WebCore::RenderThemeMac::setSearchCellState): Force the placeholder text of
+ the NSSearchFieldCell for the Mac theme to be an empty string.
+
2015-07-22 Matthew Daiter <mdai...@apple.com>
Need the ability to give only best source UIDs to UserMedia request
Modified: trunk/Source/WebCore/rendering/RenderThemeMac.mm (187169 => 187170)
--- trunk/Source/WebCore/rendering/RenderThemeMac.mm 2015-07-22 18:14:40 UTC (rev 187169)
+++ trunk/Source/WebCore/rendering/RenderThemeMac.mm 2015-07-22 18:47:12 UTC (rev 187170)
@@ -1631,6 +1631,7 @@
{
NSSearchFieldCell* search = this->search();
+ [search setPlaceholderString:@""];
[search setControlSize:controlSizeForFont(o.style())];
// Update the various states we respond to.
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
