Title: [188570] trunk/Source/WebInspectorUI
- Revision
- 188570
- Author
- drou...@apple.com
- Date
- 2015-08-17 21:08:47 -0700 (Mon, 17 Aug 2015)
Log Message
Web Inspector: web fonts or unknown fonts show up as Times in visual sidebar
https://bugs.webkit.org/show_bug.cgi?id=148103
Reviewed by Timothy Hatcher.
* UserInterface/Views/VisualStyleFontFamilyTreeElement.js:
(WebInspector.VisualStyleFontFamilyTreeElement.prototype.updateMainTitle):
Fonts now fall back to sans-serif and -apple-system if they do not exist.
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (188569 => 188570)
--- trunk/Source/WebInspectorUI/ChangeLog 2015-08-18 02:44:14 UTC (rev 188569)
+++ trunk/Source/WebInspectorUI/ChangeLog 2015-08-18 04:08:47 UTC (rev 188570)
@@ -1,3 +1,14 @@
+2015-08-17 Devin Rousso <drou...@apple.com>
+
+ Web Inspector: web fonts or unknown fonts show up as Times in visual sidebar
+ https://bugs.webkit.org/show_bug.cgi?id=148103
+
+ Reviewed by Timothy Hatcher.
+
+ * UserInterface/Views/VisualStyleFontFamilyTreeElement.js:
+ (WebInspector.VisualStyleFontFamilyTreeElement.prototype.updateMainTitle):
+ Fonts now fall back to sans-serif and -apple-system if they do not exist.
+
2015-08-17 Myles C. Maxfield <mmaxfi...@apple.com>
Implement IntegerHasher
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/VisualStyleFontFamilyTreeElement.js (188569 => 188570)
--- trunk/Source/WebInspectorUI/UserInterface/Views/VisualStyleFontFamilyTreeElement.js 2015-08-18 02:44:14 UTC (rev 188569)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/VisualStyleFontFamilyTreeElement.js 2015-08-18 04:08:47 UTC (rev 188570)
@@ -51,7 +51,8 @@
updateMainTitle(text)
{
- this.mainTitle = this._listItemNode.style.fontFamily = this._keywordEditor.value = text;
+ this.mainTitle = this._keywordEditor.value = text;
+ this._listItemNode.style.fontFamily = text + ", " + WebInspector.VisualStyleFontFamilyTreeElement.FontFamilyFallback;
let hasText = text && text.length;
this._listItemNode.classList.toggle("no-value", !hasText);
@@ -160,6 +161,8 @@
}
};
+WebInspector.VisualStyleFontFamilyTreeElement.FontFamilyFallback = "-apple-system, sans-serif";
+
WebInspector.VisualStyleFontFamilyTreeElement.Event = {
KeywordChanged: "visual-style-font-family-tree-element-keyword-changed",
EditorKeyDown: "visual-style-font-family-tree-element-editor-key-down",
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
