Title: [205965] trunk/Source/WebCore
- Revision
- 205965
- Author
- commit-qu...@webkit.org
- Date
- 2016-09-15 02:24:56 -0700 (Thu, 15 Sep 2016)
Log Message
Fix build warnings in the mediastream code
https://bugs.webkit.org/show_bug.cgi?id=161957
Patch by Alejandro G. Castro <a...@igalia.com> on 2016-09-15
Reviewed by Philippe Normand.
* platform/mediastream/MediaConstraints.cpp:
(WebCore::MediaConstraint::create): Added assertion and mock return.
* platform/mediastream/RealtimeMediaSourceSupportedConstraints.cpp:
(WebCore::RealtimeMediaSourceSupportedConstraints::nameForConstraint):
Added assertion and mock return.
(WebCore::RealtimeMediaSourceSupportedConstraints::supportsConstraint):
Added assertion and mock return.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (205964 => 205965)
--- trunk/Source/WebCore/ChangeLog 2016-09-15 09:15:51 UTC (rev 205964)
+++ trunk/Source/WebCore/ChangeLog 2016-09-15 09:24:56 UTC (rev 205965)
@@ -1,3 +1,18 @@
+2016-09-15 Alejandro G. Castro <a...@igalia.com>
+
+ Fix build warnings in the mediastream code
+ https://bugs.webkit.org/show_bug.cgi?id=161957
+
+ Reviewed by Philippe Normand.
+
+ * platform/mediastream/MediaConstraints.cpp:
+ (WebCore::MediaConstraint::create): Added assertion and mock return.
+ * platform/mediastream/RealtimeMediaSourceSupportedConstraints.cpp:
+ (WebCore::RealtimeMediaSourceSupportedConstraints::nameForConstraint):
+ Added assertion and mock return.
+ (WebCore::RealtimeMediaSourceSupportedConstraints::supportsConstraint):
+ Added assertion and mock return.
+
2016-09-15 Youenn Fablet <you...@apple.com>
Rebase binding tests after r205953
Modified: trunk/Source/WebCore/platform/mediastream/MediaConstraints.cpp (205964 => 205965)
--- trunk/Source/WebCore/platform/mediastream/MediaConstraints.cpp 2016-09-15 09:15:51 UTC (rev 205964)
+++ trunk/Source/WebCore/platform/mediastream/MediaConstraints.cpp 2016-09-15 09:24:56 UTC (rev 205965)
@@ -60,6 +60,9 @@
case MediaConstraintType::Unknown:
return UnknownConstraint::create(name, constraintType);
}
+
+ ASSERT_NOT_REACHED();
+ return MediaConstraint::create(String());
}
Ref<MediaConstraint> MediaConstraint::copy() const
Modified: trunk/Source/WebCore/platform/mediastream/RealtimeMediaSourceSupportedConstraints.cpp (205964 => 205965)
--- trunk/Source/WebCore/platform/mediastream/RealtimeMediaSourceSupportedConstraints.cpp 2016-09-15 09:15:51 UTC (rev 205964)
+++ trunk/Source/WebCore/platform/mediastream/RealtimeMediaSourceSupportedConstraints.cpp 2016-09-15 09:24:56 UTC (rev 205965)
@@ -75,6 +75,9 @@
case MediaConstraintType::GroupId:
return groupIdConstraintName;
}
+
+ ASSERT_NOT_REACHED();
+ return emptyAtom;
}
MediaConstraintType RealtimeMediaSourceSupportedConstraints::constraintFromName(const String& constraintName)
@@ -126,6 +129,9 @@
case MediaConstraintType::GroupId:
return supportsGroupId();
}
+
+ ASSERT_NOT_REACHED();
+ return false;
}
} // namespace WebCore
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
