Title: [206038] trunk/Tools
- Revision
- 206038
- Author
- wenson_hs...@apple.com
- Date
- 2016-09-16 12:32:20 -0700 (Fri, 16 Sep 2016)
Log Message
RequiresUserActionForPlayback TestWebKitAPI tests are broken after r206033.
https://bugs.webkit.org/show_bug.cgi?id=162080
Reviewed by Jer Noble.
I renamed "playingHandler" to the more generalized "testHandler", but did not realize that the
RequiresUserActionForPlayback tests also used "playingHandler". Renames the handler to account for this change.
* TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
(RequiresUserActionForPlaybackTest::SetUp):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (206037 => 206038)
--- trunk/Tools/ChangeLog 2016-09-16 19:25:29 UTC (rev 206037)
+++ trunk/Tools/ChangeLog 2016-09-16 19:32:20 UTC (rev 206038)
@@ -1,3 +1,16 @@
+2016-09-16 Wenson Hsieh <wenson_hs...@apple.com>
+
+ RequiresUserActionForPlayback TestWebKitAPI tests are broken after r206033.
+ https://bugs.webkit.org/show_bug.cgi?id=162080
+
+ Reviewed by Jer Noble.
+
+ I renamed "playingHandler" to the more generalized "testHandler", but did not realize that the
+ RequiresUserActionForPlayback tests also used "playingHandler". Renames the handler to account for this change.
+
+ * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
+ (RequiresUserActionForPlaybackTest::SetUp):
+
2016-09-16 Alex Christensen <achristen...@webkit.org>
URLParser should percent encode the user and password according to spec
Modified: trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm (206037 => 206038)
--- trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm 2016-09-16 19:25:29 UTC (rev 206037)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm 2016-09-16 19:32:20 UTC (rev 206038)
@@ -61,7 +61,7 @@
{
handler = adoptNS([[RequiresUserActionForPlaybackMessageHandler alloc] init]);
configuration = adoptNS([[WKWebViewConfiguration alloc] init]);
- [[configuration userContentController] addScriptMessageHandler:handler.get() name:@"playingHandler"];
+ [[configuration userContentController] addScriptMessageHandler:handler.get() name:@"testHandler"];
configuration.get()._mediaDataLoadsAutomatically = YES;
#if TARGET_OS_IPHONE
configuration.get().allowsInlineMediaPlayback = YES;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
