Title: [206066] trunk/Source/WebKit2
Revision
206066
Author
carlo...@webkit.org
Date
2016-09-17 01:32:15 -0700 (Sat, 17 Sep 2016)

Log Message

[ThreadedCompositor] Scrolling artifacts on accelerated subframes
https://bugs.webkit.org/show_bug.cgi?id=149060

Reviewed by Michael Catanzaro.

The problem is that we are scrolling the main frame even when scrolling is not delegated.

* WebProcess/WebPage/CoordinatedGraphics/ThreadedCoordinatedLayerTreeHost.cpp:
(WebKit::ThreadedCoordinatedLayerTreeHost::scrollNonCompositedContents): Return early if main frame view doesn't
delegate scrolling.

Modified Paths

Diff

Modified: trunk/Source/WebKit2/ChangeLog (206065 => 206066)


--- trunk/Source/WebKit2/ChangeLog	2016-09-17 06:32:50 UTC (rev 206065)
+++ trunk/Source/WebKit2/ChangeLog	2016-09-17 08:32:15 UTC (rev 206066)
@@ -1,3 +1,16 @@
+2016-09-17  Carlos Garcia Campos  <cgar...@igalia.com>
+
+        [ThreadedCompositor] Scrolling artifacts on accelerated subframes
+        https://bugs.webkit.org/show_bug.cgi?id=149060
+
+        Reviewed by Michael Catanzaro.
+
+        The problem is that we are scrolling the main frame even when scrolling is not delegated.
+
+        * WebProcess/WebPage/CoordinatedGraphics/ThreadedCoordinatedLayerTreeHost.cpp:
+        (WebKit::ThreadedCoordinatedLayerTreeHost::scrollNonCompositedContents): Return early if main frame view doesn't
+        delegate scrolling.
+
 2016-09-16  Simon Fraser  <simon.fra...@apple.com>
 
         WKWebViewConfiguration's _incrementalRenderingSuppressionTimeout should be an NSTimeInterval

Modified: trunk/Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/ThreadedCoordinatedLayerTreeHost.cpp (206065 => 206066)


--- trunk/Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/ThreadedCoordinatedLayerTreeHost.cpp	2016-09-17 06:32:50 UTC (rev 206065)
+++ trunk/Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/ThreadedCoordinatedLayerTreeHost.cpp	2016-09-17 08:32:15 UTC (rev 206066)
@@ -79,6 +79,10 @@
 
 void ThreadedCoordinatedLayerTreeHost::scrollNonCompositedContents(const IntRect& rect)
 {
+    FrameView* frameView = m_webPage.mainFrameView();
+    if (!frameView || !frameView->delegatesScrolling())
+        return;
+
     m_viewportController.didScroll(rect.location());
     didChangeViewport();
 }
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to