Title: [206211] trunk/Source/WebCore
- Revision
- 206211
- Author
- jer.no...@apple.com
- Date
- 2016-09-21 09:25:14 -0700 (Wed, 21 Sep 2016)
Log Message
REGRESSION(r206127): ASSERTION FAILED: !isClosed() in WebCore::MediaSource::detachFromElement
https://bugs.webkit.org/show_bug.cgi?id=162307
Reviewed by Eric Carlson.
The test is crashing when the ScriptExecutionContext is calling stop() on the media element before
it's attached MediaSource has been open()ed, which is a valid state. Removing this ASSERT().
* Modules/mediasource/MediaSource.cpp:
(WebCore::MediaSource::detachFromElement):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (206210 => 206211)
--- trunk/Source/WebCore/ChangeLog 2016-09-21 16:16:01 UTC (rev 206210)
+++ trunk/Source/WebCore/ChangeLog 2016-09-21 16:25:14 UTC (rev 206211)
@@ -1,3 +1,16 @@
+2016-09-21 Jer Noble <jer.no...@apple.com>
+
+ REGRESSION(r206127): ASSERTION FAILED: !isClosed() in WebCore::MediaSource::detachFromElement
+ https://bugs.webkit.org/show_bug.cgi?id=162307
+
+ Reviewed by Eric Carlson.
+
+ The test is crashing when the ScriptExecutionContext is calling stop() on the media element before
+ it's attached MediaSource has been open()ed, which is a valid state. Removing this ASSERT().
+
+ * Modules/mediasource/MediaSource.cpp:
+ (WebCore::MediaSource::detachFromElement):
+
2016-09-19 Jer Noble <jer.no...@apple.com>
[media-source] Fix imported/w3c/web-platform-tests/media-source/mediasource-activesourcebuffers.html
Modified: trunk/Source/WebCore/Modules/mediasource/MediaSource.cpp (206210 => 206211)
--- trunk/Source/WebCore/Modules/mediasource/MediaSource.cpp 2016-09-21 16:16:01 UTC (rev 206210)
+++ trunk/Source/WebCore/Modules/mediasource/MediaSource.cpp 2016-09-21 16:25:14 UTC (rev 206211)
@@ -891,7 +891,6 @@
void MediaSource::detachFromElement(HTMLMediaElement& element)
{
ASSERT_UNUSED(element, m_mediaElement == &element);
- ASSERT(!isClosed());
// 2.4.2 Detaching from a media element
// https://rawgit.com/w3c/media-source/45627646344eea0170dd1cbc5a3d508ca751abb8/media-source-respec.html#mediasource-detach
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
