Title: [207323] trunk/Source/WebCore
Revision
207323
Author
achristen...@apple.com
Date
2016-10-13 22:39:07 -0700 (Thu, 13 Oct 2016)

Log Message

Fix API test after r207318.
https://bugs.webkit.org/show_bug.cgi?id=162951

This fixes the API test WebKit2.PendingAPIRequestURL which asserted when trying to hash a null String.

* loader/DocumentLoader.cpp:
(WebCore::isRemoteWebArchive):
If the mimeType is a null String, it is not in the set webArchiveMIMETypes, so return false instead of hashing it.

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (207322 => 207323)


--- trunk/Source/WebCore/ChangeLog	2016-10-14 05:29:02 UTC (rev 207322)
+++ trunk/Source/WebCore/ChangeLog	2016-10-14 05:39:07 UTC (rev 207323)
@@ -1,5 +1,16 @@
 2016-10-13  Alex Christensen  <achristen...@webkit.org>
 
+        Fix API test after r207318.
+        https://bugs.webkit.org/show_bug.cgi?id=162951
+
+        This fixes the API test WebKit2.PendingAPIRequestURL which asserted when trying to hash a null String.
+
+        * loader/DocumentLoader.cpp:
+        (WebCore::isRemoteWebArchive):
+        If the mimeType is a null String, it is not in the set webArchiveMIMETypes, so return false instead of hashing it.
+
+2016-10-13  Alex Christensen  <achristen...@webkit.org>
+
         Hosts of URLs with non-special schemes should be case-sensitive, and non-ASCII characters in such hosts should be punycode-encoded
         https://bugs.webkit.org/show_bug.cgi?id=163413
 

Modified: trunk/Source/WebCore/loader/DocumentLoader.cpp (207322 => 207323)


--- trunk/Source/WebCore/loader/DocumentLoader.cpp	2016-10-14 05:29:02 UTC (rev 207322)
+++ trunk/Source/WebCore/loader/DocumentLoader.cpp	2016-10-14 05:39:07 UTC (rev 207323)
@@ -763,7 +763,8 @@
     };
 
     const ResourceResponse& response = documentLoader.response();
-    if (!webArchiveMIMETypes.get().contains(response.mimeType()))
+    String mimeType = response.mimeType();
+    if (mimeType.isNull() || !webArchiveMIMETypes.get().contains(mimeType))
         return false;
 
 #if USE(QUICK_LOOK)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to