Title: [207329] trunk/Source/WebInspectorUI
- Revision
- 207329
- Author
- commit-qu...@webkit.org
- Date
- 2016-10-14 00:10:00 -0700 (Fri, 14 Oct 2016)
Log Message
Uncaught Exception: TypeError: this.positionToOffset is not a function - seen hovering expressions with Type Profiler enabled
https://bugs.webkit.org/show_bug.cgi?id=163405
<rdar://problem/28763953>
Patch by Joseph Pecoraro <pecor...@apple.com> on 2016-10-14
Reviewed by Matt Baker.
* UserInterface/Views/SourceCodeTextEditor.js:
Use correct method name, the old one must have gone away.
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (207328 => 207329)
--- trunk/Source/WebInspectorUI/ChangeLog 2016-10-14 06:58:28 UTC (rev 207328)
+++ trunk/Source/WebInspectorUI/ChangeLog 2016-10-14 07:10:00 UTC (rev 207329)
@@ -1,3 +1,14 @@
+2016-10-14 Joseph Pecoraro <pecor...@apple.com>
+
+ Uncaught Exception: TypeError: this.positionToOffset is not a function - seen hovering expressions with Type Profiler enabled
+ https://bugs.webkit.org/show_bug.cgi?id=163405
+ <rdar://problem/28763953>
+
+ Reviewed by Matt Baker.
+
+ * UserInterface/Views/SourceCodeTextEditor.js:
+ Use correct method name, the old one must have gone away.
+
2016-10-12 Joseph Pecoraro <pecor...@apple.com>
Web Inspector: Improve support for logging Proxy objects in console
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/SourceCodeTextEditor.js (207328 => 207329)
--- trunk/Source/WebInspectorUI/UserInterface/Views/SourceCodeTextEditor.js 2016-10-14 06:58:28 UTC (rev 207328)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/SourceCodeTextEditor.js 2016-10-14 07:10:00 UTC (rev 207329)
@@ -1516,7 +1516,7 @@
var sourceCode = this._sourceCode;
var sourceID = sourceCode instanceof WebInspector.Script ? sourceCode.id : sourceCode.scripts[0].id;
var range = candidate.hoveredTokenRange;
- var offset = this.positionToOffset({line: range.start.line, ch: range.start.ch});
+ var offset = this.currentPositionToOriginalOffset(range.start);
var allRequests = [{
typeInformationDescriptor: WebInspector.ScriptSyntaxTree.TypeProfilerSearchDescriptor.NormalExpression,
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
