Title: [207337] trunk/Source/WebCore
- Revision
- 207337
- Author
- commit-qu...@webkit.org
- Date
- 2016-10-14 07:09:45 -0700 (Fri, 14 Oct 2016)
Log Message
[Readable Streams API] Cleanup patch, fix small inconsistencies
https://bugs.webkit.org/show_bug.cgi?id=163329
Patch by Romain Bellessort <romain.belless...@crf.canon.fr> on 2016-10-14
Reviewed by Youenn Fablet.
Cleanup patch, fixed 3 small inconsistences between implementation and spec.
No change in behaviour.
* Modules/streams/ReadableStream.idl: Added optional parameter in getReader.
* Modules/streams/ReadableStreamDefaultController.js:
(error): Call readableStreamDefaultControllerError instead of readableStreamError.
* Modules/streams/ReadableStreamInternals.js: Added missing ASSERT in readableStreamDefaultControllerCallPullIfNeeded.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (207336 => 207337)
--- trunk/Source/WebCore/ChangeLog 2016-10-14 11:47:39 UTC (rev 207336)
+++ trunk/Source/WebCore/ChangeLog 2016-10-14 14:09:45 UTC (rev 207337)
@@ -1,3 +1,19 @@
+2016-10-14 Romain Bellessort <romain.belless...@crf.canon.fr>
+
+ [Readable Streams API] Cleanup patch, fix small inconsistencies
+ https://bugs.webkit.org/show_bug.cgi?id=163329
+
+ Reviewed by Youenn Fablet.
+
+ Cleanup patch, fixed 3 small inconsistences between implementation and spec.
+
+ No change in behaviour.
+
+ * Modules/streams/ReadableStream.idl: Added optional parameter in getReader.
+ * Modules/streams/ReadableStreamDefaultController.js:
+ (error): Call readableStreamDefaultControllerError instead of readableStreamError.
+ * Modules/streams/ReadableStreamInternals.js: Added missing ASSERT in readableStreamDefaultControllerCallPullIfNeeded.
+
2016-10-14 Youenn Fablet <you...@apple.com>
http://trac.webkit.org/changeset/207330 broke Mac Windows build
Modified: trunk/Source/WebCore/Modules/streams/ReadableStream.idl (207336 => 207337)
--- trunk/Source/WebCore/Modules/streams/ReadableStream.idl 2016-10-14 11:47:39 UTC (rev 207336)
+++ trunk/Source/WebCore/Modules/streams/ReadableStream.idl 2016-10-14 14:09:45 UTC (rev 207337)
@@ -36,7 +36,7 @@
PublicIdentifier
] interface ReadableStream {
[NotEnumerable] Promise cancel(optional any reason);
- [NotEnumerable] Object getReader();
+ [NotEnumerable] Object getReader(optional any options);
[NotEnumerable] Promise pipeTo(any streams, optional any options);
[NotEnumerable] Object pipeThrough(any dest, any options);
[NotEnumerable] Object tee();
Modified: trunk/Source/WebCore/Modules/streams/ReadableStreamDefaultController.js (207336 => 207337)
--- trunk/Source/WebCore/Modules/streams/ReadableStreamDefaultController.js 2016-10-14 11:47:39 UTC (rev 207336)
+++ trunk/Source/WebCore/Modules/streams/ReadableStreamDefaultController.js 2016-10-14 14:09:45 UTC (rev 207337)
@@ -52,7 +52,7 @@
if (stream.@state !== @streamReadable)
@throwTypeError("ReadableStream is not readable");
- @readableStreamError(stream, error);
+ @readableStreamDefaultControllerError(this, error);
}
function close()
Modified: trunk/Source/WebCore/Modules/streams/ReadableStreamInternals.js (207336 => 207337)
--- trunk/Source/WebCore/Modules/streams/ReadableStreamInternals.js 2016-10-14 11:47:39 UTC (rev 207336)
+++ trunk/Source/WebCore/Modules/streams/ReadableStreamInternals.js 2016-10-14 14:09:45 UTC (rev 207337)
@@ -299,6 +299,7 @@
return;
}
+ @assert(!controller.@pullAgain);
controller.@pulling = true;
@promiseInvokeOrNoop(controller.@underlyingSource, "pull", [controller]).@then(function() {
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
