Diff
Modified: trunk/Tools/ChangeLog (207349 => 207350)
--- trunk/Tools/ChangeLog 2016-10-14 18:26:40 UTC (rev 207349)
+++ trunk/Tools/ChangeLog 2016-10-14 18:26:44 UTC (rev 207350)
@@ -1,5 +1,22 @@
2016-10-14 Simon Fraser <simon.fra...@apple.com>
+ Annotate bots in contributors.json and don't show them on webkit.org/team
+ https://bugs.webkit.org/show_bug.cgi?id=163317
+
+ Reviewed by Daniel Bates.
+
+ Add "class" : "bot" for non-humans in contributors.json and round-trip it.
+
+ * Scripts/webkitpy/common/config/committers.py:
+ (Contributor.__init__):
+ (Contributor.as_dict):
+ (Bot):
+ (Bot.__init__):
+ (CommitterList.load_json):
+ * Scripts/webkitpy/common/config/contributors.json:
+
+2016-10-14 Simon Fraser <simon.fra...@apple.com>
+
Fix printing in WK2 MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=163455
Modified: trunk/Tools/Scripts/webkitpy/common/config/committers.py (207349 => 207350)
--- trunk/Tools/Scripts/webkitpy/common/config/committers.py 2016-10-14 18:26:40 UTC (rev 207349)
+++ trunk/Tools/Scripts/webkitpy/common/config/committers.py 2016-10-14 18:26:44 UTC (rev 207350)
@@ -62,6 +62,7 @@
self.expertise = expertise
self.can_commit = False
self.can_review = False
+ self.is_bot = False
def bugzilla_email(self):
# FIXME: We're assuming the first email is a valid bugzilla email,
@@ -146,6 +147,9 @@
if self.expertise:
info["expertise"] = self.expertise
+ if self.is_bot:
+ info["class"] = "bot"
+
return info
@@ -161,6 +165,11 @@
self.can_review = True
+class Bot(Contributor):
+ def __init__(self, name, email_or_emails, irc_nickname=None, alias_or_aliases=None, expertise=None):
+ Contributor.__init__(self, name, email_or_emails, irc_nickname, alias_or_aliases, expertise)
+ self.is_bot = True
+
class CommitterList(object):
# Committers and reviewers are passed in to allow easy testing
@@ -199,6 +208,8 @@
elif status == "committer":
contributor = Committer(name, data.get('emails'), data.get('nicks'), data.get('aliases'), data.get('expertise'))
self._committers.append(contributor)
+ elif data.get('class') == 'bot':
+ contributor = Bot(name, data.get('emails'), data.get('nicks'), data.get('aliases'), data.get('expertise'))
else:
contributor = Contributor(name, data.get('emails'), data.get('nicks'), data.get('aliases'), data.get('expertise'))
Modified: trunk/Tools/Scripts/webkitpy/common/config/contributors.json (207349 => 207350)
--- trunk/Tools/Scripts/webkitpy/common/config/contributors.json 2016-10-14 18:26:40 UTC (rev 207349)
+++ trunk/Tools/Scripts/webkitpy/common/config/contributors.json 2016-10-14 18:26:44 UTC (rev 207350)
@@ -149,6 +149,7 @@
"status" : "committer"
},
"Adobe Bug Tracker" : {
+ "class" : "bot",
"emails" : [
"webkitbugtrac...@adobe.com"
]
@@ -1258,6 +1259,7 @@
"status" : "committer"
},
"Commit Queue" : {
+ "class" : "bot",
"emails" : [
"commit-qu...@webkit.org"
]
@@ -4513,6 +4515,7 @@
"status" : "committer"
},
"Radar WebKit Bug Importer" : {
+ "class" : "bot",
"emails" : [
"webkit-bug-impor...@group.apple.com"
]
@@ -5460,6 +5463,7 @@
]
},
"WebKit Review Bot" : {
+ "class" : "bot",
"emails" : [
"webkit.review....@gmail.com"
],
@@ -5468,6 +5472,7 @@
]
},
"WebKitGTK+ Bugs" : {
+ "class" : "bot",
"emails" : [
"bugs-nore...@webkitgtk.org"
]
Modified: trunk/Websites/webkit.org/ChangeLog (207349 => 207350)
--- trunk/Websites/webkit.org/ChangeLog 2016-10-14 18:26:40 UTC (rev 207349)
+++ trunk/Websites/webkit.org/ChangeLog 2016-10-14 18:26:44 UTC (rev 207350)
@@ -1,3 +1,14 @@
+2016-10-14 Simon Fraser <simon.fra...@apple.com>
+
+ Annotate bots in contributors.json and don't show them on webkit.org/team
+ https://bugs.webkit.org/show_bug.cgi?id=163317
+
+ Reviewed by Daniel Bates.
+
+ Don't show bots.
+
+ * wp-content/themes/webkit/team.php:
+
2016-10-12 Keith Miller <keith_mil...@apple.com>
B3 needs a special WasmBoundsCheck Opcode
Modified: trunk/Websites/webkit.org/wp-content/themes/webkit/team.php (207349 => 207350)
--- trunk/Websites/webkit.org/wp-content/themes/webkit/team.php 2016-10-14 18:26:40 UTC (rev 207349)
+++ trunk/Websites/webkit.org/wp-content/themes/webkit/team.php 2016-10-14 18:26:44 UTC (rev 207350)
@@ -135,6 +135,8 @@
for (var contributor in contributorsJSON) {
var data = ""
+ if (data.class == "bot")
+ continue;
contributors.push({
name: contributor,
kind: data.status ? data.status : 'contributor',
