Title: [207351] trunk
- Revision
- 207351
- Author
- mcatanz...@igalia.com
- Date
- 2016-10-14 11:29:16 -0700 (Fri, 14 Oct 2016)
Log Message
[CMake] Private/unsupported build options should be marked as advanced
https://bugs.webkit.org/show_bug.cgi?id=163451
Reviewed by Carlos Garcia Campos.
When checking to decide whether to mark an option as advanced, the conditional checks
whether _WEBKIT_AVAILABLE_OPTIONS_IS_PUBLIC_${_name} is defined. It is always defined. We
need to check its value instead.
* Source/cmake/WebKitFeatures.cmake:
Modified Paths
Diff
Modified: trunk/ChangeLog (207350 => 207351)
--- trunk/ChangeLog 2016-10-14 18:26:44 UTC (rev 207350)
+++ trunk/ChangeLog 2016-10-14 18:29:16 UTC (rev 207351)
@@ -1,3 +1,16 @@
+2016-10-14 Michael Catanzaro <mcatanz...@igalia.com>
+
+ [CMake] Private/unsupported build options should be marked as advanced
+ https://bugs.webkit.org/show_bug.cgi?id=163451
+
+ Reviewed by Carlos Garcia Campos.
+
+ When checking to decide whether to mark an option as advanced, the conditional checks
+ whether _WEBKIT_AVAILABLE_OPTIONS_IS_PUBLIC_${_name} is defined. It is always defined. We
+ need to check its value instead.
+
+ * Source/cmake/WebKitFeatures.cmake:
+
2016-10-13 Brian Burg <bb...@apple.com>
[CMake] Split the definition of CODE_GENERATOR_PREPROCESSOR so it can be used in a custom command
Modified: trunk/Source/cmake/WebKitFeatures.cmake (207350 => 207351)
--- trunk/Source/cmake/WebKitFeatures.cmake 2016-10-14 18:26:44 UTC (rev 207350)
+++ trunk/Source/cmake/WebKitFeatures.cmake 2016-10-14 18:29:16 UTC (rev 207351)
@@ -268,7 +268,7 @@
endif ()
option(${_name} "${_WEBKIT_AVAILABLE_OPTIONS_DESCRIPTION_${_name}}" ${_WEBKIT_AVAILABLE_OPTIONS_INITIAL_VALUE_${_name}})
- if (NOT _WEBKIT_AVAILABLE_OPTIONS_IS_PUBLIC_${_name})
+ if (NOT ${_WEBKIT_AVAILABLE_OPTIONS_IS_PUBLIC_${_name}})
mark_as_advanced(FORCE ${_name})
endif ()
endforeach ()
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
