Title: [207356] trunk/Source/WebInspectorUI
- Revision
- 207356
- Author
- commit-qu...@webkit.org
- Date
- 2016-10-14 15:25:09 -0700 (Fri, 14 Oct 2016)
Log Message
Web Inspector: Unused Breakpoint getter/setter for "id" - should be "identifier"
https://bugs.webkit.org/show_bug.cgi?id=163395
Patch by Joseph Pecoraro <pecor...@apple.com> on 2016-10-14
Reviewed by Timothy Hatcher.
* UserInterface/Models/Breakpoint.js:
(WebInspector.Breakpoint.prototype.get identifier): Renamed.
(WebInspector.Breakpoint.prototype.set identifier): Renamed.
The only user is DebuggerManager which sets and gets. Previously
it was unexpectedly setting a direct property on the Breakpoint
instead of using these methods to set the member variable.
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (207355 => 207356)
--- trunk/Source/WebInspectorUI/ChangeLog 2016-10-14 22:16:34 UTC (rev 207355)
+++ trunk/Source/WebInspectorUI/ChangeLog 2016-10-14 22:25:09 UTC (rev 207356)
@@ -1,5 +1,19 @@
2016-10-14 Joseph Pecoraro <pecor...@apple.com>
+ Web Inspector: Unused Breakpoint getter/setter for "id" - should be "identifier"
+ https://bugs.webkit.org/show_bug.cgi?id=163395
+
+ Reviewed by Timothy Hatcher.
+
+ * UserInterface/Models/Breakpoint.js:
+ (WebInspector.Breakpoint.prototype.get identifier): Renamed.
+ (WebInspector.Breakpoint.prototype.set identifier): Renamed.
+ The only user is DebuggerManager which sets and gets. Previously
+ it was unexpectedly setting a direct property on the Breakpoint
+ instead of using these methods to set the member variable.
+
+2016-10-14 Joseph Pecoraro <pecor...@apple.com>
+
Web Inspector: Remove uses of delete in SourceCodeTextEditor
https://bugs.webkit.org/show_bug.cgi?id=163379
Modified: trunk/Source/WebInspectorUI/UserInterface/Models/Breakpoint.js (207355 => 207356)
--- trunk/Source/WebInspectorUI/UserInterface/Models/Breakpoint.js 2016-10-14 22:16:34 UTC (rev 207355)
+++ trunk/Source/WebInspectorUI/UserInterface/Models/Breakpoint.js 2016-10-14 22:25:09 UTC (rev 207356)
@@ -67,12 +67,12 @@
// Public
- get id()
+ get identifier()
{
return this._id;
}
- set id(id)
+ set identifier(id)
{
this._id = id || null;
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
