Title: [207403] trunk/Source/WebCore
- Revision
- 207403
- Author
- be...@igalia.com
- Date
- 2016-10-17 02:06:17 -0700 (Mon, 17 Oct 2016)
Log Message
[GTK] gobject-introspection on package build with webkit2gtk fails without active X session
https://bugs.webkit.org/show_bug.cgi?id=163105
Reviewed by Carlos Garcia Campos.
Don't call XCompositeQueryExtension() or XDamageQueryExtension()
if m_display is NULL.
* platform/graphics/x11/PlatformDisplayX11.cpp:
(WebCore::PlatformDisplayX11::supportsXComposite):
(WebCore::PlatformDisplayX11::supportsXDamage):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (207402 => 207403)
--- trunk/Source/WebCore/ChangeLog 2016-10-17 07:23:07 UTC (rev 207402)
+++ trunk/Source/WebCore/ChangeLog 2016-10-17 09:06:17 UTC (rev 207403)
@@ -1,3 +1,17 @@
+2016-10-17 Alberto Garcia <be...@igalia.com>
+
+ [GTK] gobject-introspection on package build with webkit2gtk fails without active X session
+ https://bugs.webkit.org/show_bug.cgi?id=163105
+
+ Reviewed by Carlos Garcia Campos.
+
+ Don't call XCompositeQueryExtension() or XDamageQueryExtension()
+ if m_display is NULL.
+
+ * platform/graphics/x11/PlatformDisplayX11.cpp:
+ (WebCore::PlatformDisplayX11::supportsXComposite):
+ (WebCore::PlatformDisplayX11::supportsXDamage):
+
2016-10-16 Nan Wang <n_w...@apple.com>
AX: [Mac] roleDescription for AXTextField input types
Modified: trunk/Source/WebCore/platform/graphics/x11/PlatformDisplayX11.cpp (207402 => 207403)
--- trunk/Source/WebCore/platform/graphics/x11/PlatformDisplayX11.cpp 2016-10-17 07:23:07 UTC (rev 207402)
+++ trunk/Source/WebCore/platform/graphics/x11/PlatformDisplayX11.cpp 2016-10-17 09:06:17 UTC (rev 207403)
@@ -76,8 +76,11 @@
bool PlatformDisplayX11::supportsXComposite() const
{
if (!m_supportsXComposite) {
- int eventBase, errorBase;
- m_supportsXComposite = XCompositeQueryExtension(m_display, &eventBase, &errorBase);
+ if (m_display) {
+ int eventBase, errorBase;
+ m_supportsXComposite = XCompositeQueryExtension(m_display, &eventBase, &errorBase);
+ } else
+ m_supportsXComposite = false;
}
return m_supportsXComposite.value();
}
@@ -85,13 +88,14 @@
bool PlatformDisplayX11::supportsXDamage(Optional<int>& damageEventBase) const
{
if (!m_supportsXDamage) {
+ m_supportsXDamage = false;
#if PLATFORM(GTK)
- int eventBase, errorBase;
- m_supportsXDamage = XDamageQueryExtension(m_display, &eventBase, &errorBase);
- if (m_supportsXDamage.value())
- m_damageEventBase = eventBase;
-#else
- m_supportsXDamage = false;
+ if (m_display) {
+ int eventBase, errorBase;
+ m_supportsXDamage = XDamageQueryExtension(m_display, &eventBase, &errorBase);
+ if (m_supportsXDamage.value())
+ m_damageEventBase = eventBase;
+ }
#endif
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
