Title: [207412] trunk/Source/WebCore
- Revision
- 207412
- Author
- commit-qu...@webkit.org
- Date
- 2016-10-17 10:32:18 -0700 (Mon, 17 Oct 2016)
Log Message
preprocessor.pm: cl.exe outputs processing filenames if Windows Perl is used
https://bugs.webkit.org/show_bug.cgi?id=163435
Patch by Fujii Hironori <hironori.fu...@sony.com> on 2016-10-17
Reviewed by Alex Christensen.
cl.exe outputs processing filenames to stderr. Suppress this
annoying messages by using open3 instead of open2.
* bindings/scripts/preprocessor.pm:
(applyPreprocessor): Use open3 in case of Windows Perl.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (207411 => 207412)
--- trunk/Source/WebCore/ChangeLog 2016-10-17 16:59:06 UTC (rev 207411)
+++ trunk/Source/WebCore/ChangeLog 2016-10-17 17:32:18 UTC (rev 207412)
@@ -1,3 +1,16 @@
+2016-10-17 Fujii Hironori <hironori.fu...@sony.com>
+
+ preprocessor.pm: cl.exe outputs processing filenames if Windows Perl is used
+ https://bugs.webkit.org/show_bug.cgi?id=163435
+
+ Reviewed by Alex Christensen.
+
+ cl.exe outputs processing filenames to stderr. Suppress this
+ annoying messages by using open3 instead of open2.
+
+ * bindings/scripts/preprocessor.pm:
+ (applyPreprocessor): Use open3 in case of Windows Perl.
+
2016-10-17 Mark Lam <mark....@apple.com>
Use the reject() helper function for conditionally throwing TypeErrors.
Modified: trunk/Source/WebCore/bindings/scripts/preprocessor.pm (207411 => 207412)
--- trunk/Source/WebCore/bindings/scripts/preprocessor.pm 2016-10-17 16:59:06 UTC (rev 207411)
+++ trunk/Source/WebCore/bindings/scripts/preprocessor.pm 2016-10-17 17:32:18 UTC (rev 207412)
@@ -99,7 +99,10 @@
}
};
} elsif ($Config::Config{"osname"} eq "MSWin32") {
- $pid = open2(\*PP_OUT, \*PP_IN, $preprocessor, @args, @macros, $fileName);
+ # Suppress STDERR so that if we're using cl.exe, the output
+ # name isn't needlessly echoed.
+ use Symbol 'gensym'; my $err = gensym;
+ $pid = open3(\*PP_IN, \*PP_OUT, $err, $preprocessor, @args, @macros, $fileName);
} else {
$pid = open2(\*PP_OUT, \*PP_IN, split(' ', $preprocessor), @args, @macros, $fileName);
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
