Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (209231 => 209232)
--- trunk/Source/_javascript_Core/ChangeLog 2016-12-02 05:31:07 UTC (rev 209231)
+++ trunk/Source/_javascript_Core/ChangeLog 2016-12-02 06:08:30 UTC (rev 209232)
@@ -1,3 +1,24 @@
+2016-12-01 Brian Burg <bb...@apple.com>
+
+ Remote Inspector: fix weird typo in generated ObjC protocol type initializer implementations
+ https://bugs.webkit.org/show_bug.cgi?id=165295
+ <rdar://problem/29427778>
+
+ Reviewed by Joseph Pecoraro.
+
+ Remove a stray semicolon appended after custom initializer signatures.
+ This is a syntax error when building with less lenient compiler warnings.
+
+ * inspector/scripts/codegen/generate_objc_protocol_types_implementation.py:
+ (ObjCProtocolTypesImplementationGenerator._generate_init_method_for_required_members):
+ * inspector/scripts/tests/expected/commands-with-async-attribute.json-result:
+ * inspector/scripts/tests/expected/commands-with-optional-call-return-parameters.json-result:
+ * inspector/scripts/tests/expected/events-with-optional-parameters.json-result:
+ * inspector/scripts/tests/expected/generate-domains-with-feature-guards.json-result:
+ * inspector/scripts/tests/expected/shadowed-optional-type-setters.json-result:
+ * inspector/scripts/tests/expected/type-declaration-object-type.json-result:
+ * inspector/scripts/tests/expected/type-requiring-runtime-casts.json-result:
+
2016-12-01 Saam Barati <sbar...@apple.com>
Rename CallFrame::callee() to CallFrame::jsCallee()
Modified: trunk/Source/_javascript_Core/inspector/scripts/codegen/generate_objc_protocol_types_implementation.py (209231 => 209232)
--- trunk/Source/_javascript_Core/inspector/scripts/codegen/generate_objc_protocol_types_implementation.py 2016-12-02 05:31:07 UTC (rev 209231)
+++ trunk/Source/_javascript_Core/inspector/scripts/codegen/generate_objc_protocol_types_implementation.py 2016-12-02 06:08:30 UTC (rev 209232)
@@ -147,7 +147,7 @@
pairs.append('%s:(%s)%s' % (var_name, objc_type, var_name))
pairs[0] = ucfirst(pairs[0])
lines = []
- lines.append('- (instancetype)initWith%s;' % ' '.join(pairs))
+ lines.append('- (instancetype)initWith%s' % ' '.join(pairs))
lines.append('{')
lines.append(' if (!(self = [super init]))')
lines.append(' return nil;')
Modified: trunk/Source/_javascript_Core/inspector/scripts/tests/expected/commands-with-async-attribute.json-result (209231 => 209232)
--- trunk/Source/_javascript_Core/inspector/scripts/tests/expected/commands-with-async-attribute.json-result 2016-12-02 05:31:07 UTC (rev 209231)
+++ trunk/Source/_javascript_Core/inspector/scripts/tests/expected/commands-with-async-attribute.json-result 2016-12-02 06:08:30 UTC (rev 209232)
@@ -1715,7 +1715,7 @@
return self;
}
-- (instancetype)initWithMessage:(NSString *)message code:(int)code;
+- (instancetype)initWithMessage:(NSString *)message code:(int)code
{
if (!(self = [super init]))
return nil;
Modified: trunk/Source/_javascript_Core/inspector/scripts/tests/expected/commands-with-optional-call-return-parameters.json-result (209231 => 209232)
--- trunk/Source/_javascript_Core/inspector/scripts/tests/expected/commands-with-optional-call-return-parameters.json-result 2016-12-02 05:31:07 UTC (rev 209231)
+++ trunk/Source/_javascript_Core/inspector/scripts/tests/expected/commands-with-optional-call-return-parameters.json-result 2016-12-02 06:08:30 UTC (rev 209232)
@@ -1570,7 +1570,7 @@
return self;
}
-- (instancetype)initWithMessage:(NSString *)message code:(int)code;
+- (instancetype)initWithMessage:(NSString *)message code:(int)code
{
if (!(self = [super init]))
return nil;
Modified: trunk/Source/_javascript_Core/inspector/scripts/tests/expected/events-with-optional-parameters.json-result (209231 => 209232)
--- trunk/Source/_javascript_Core/inspector/scripts/tests/expected/events-with-optional-parameters.json-result 2016-12-02 05:31:07 UTC (rev 209231)
+++ trunk/Source/_javascript_Core/inspector/scripts/tests/expected/events-with-optional-parameters.json-result 2016-12-02 06:08:30 UTC (rev 209232)
@@ -1144,7 +1144,7 @@
return self;
}
-- (instancetype)initWithMessage:(NSString *)message code:(int)code;
+- (instancetype)initWithMessage:(NSString *)message code:(int)code
{
if (!(self = [super init]))
return nil;
Modified: trunk/Source/_javascript_Core/inspector/scripts/tests/expected/generate-domains-with-feature-guards.json-result (209231 => 209232)
--- trunk/Source/_javascript_Core/inspector/scripts/tests/expected/generate-domains-with-feature-guards.json-result 2016-12-02 05:31:07 UTC (rev 209231)
+++ trunk/Source/_javascript_Core/inspector/scripts/tests/expected/generate-domains-with-feature-guards.json-result 2016-12-02 06:08:30 UTC (rev 209232)
@@ -1190,7 +1190,7 @@
return self;
}
-- (instancetype)initWithMessage:(NSString *)message code:(int)code;
+- (instancetype)initWithMessage:(NSString *)message code:(int)code
{
if (!(self = [super init]))
return nil;
Modified: trunk/Source/_javascript_Core/inspector/scripts/tests/expected/shadowed-optional-type-setters.json-result (209231 => 209232)
--- trunk/Source/_javascript_Core/inspector/scripts/tests/expected/shadowed-optional-type-setters.json-result 2016-12-02 05:31:07 UTC (rev 209231)
+++ trunk/Source/_javascript_Core/inspector/scripts/tests/expected/shadowed-optional-type-setters.json-result 2016-12-02 06:08:30 UTC (rev 209232)
@@ -1047,7 +1047,7 @@
return self;
}
-- (instancetype)initWithType:(TestProtocolRuntimeKeyPathType)type;
+- (instancetype)initWithType:(TestProtocolRuntimeKeyPathType)type
{
if (!(self = [super init]))
return nil;
Modified: trunk/Source/_javascript_Core/inspector/scripts/tests/expected/type-declaration-object-type.json-result (209231 => 209232)
--- trunk/Source/_javascript_Core/inspector/scripts/tests/expected/type-declaration-object-type.json-result 2016-12-02 05:31:07 UTC (rev 209231)
+++ trunk/Source/_javascript_Core/inspector/scripts/tests/expected/type-declaration-object-type.json-result 2016-12-02 06:08:30 UTC (rev 209232)
@@ -1473,7 +1473,7 @@
return self;
}
-- (instancetype)initWithMessage:(NSString *)message code:(int)code;
+- (instancetype)initWithMessage:(NSString *)message code:(int)code
{
if (!(self = [super init]))
return nil;
@@ -1650,7 +1650,7 @@
return self;
}
-- (instancetype)initWithColumnNames:(NSArray/*<NSString>*/ *)columnNames notes:(NSString *)notes timestamp:(double)timestamp values:(RWIProtocolJSONObject *)values payload:(RWIProtocolJSONObject *)payload error:(TestProtocolDatabaseError *)error errorList:(NSArray/*<TestProtocolDatabaseError>*/ *)errorList;
+- (instancetype)initWithColumnNames:(NSArray/*<NSString>*/ *)columnNames notes:(NSString *)notes timestamp:(double)timestamp values:(RWIProtocolJSONObject *)values payload:(RWIProtocolJSONObject *)payload error:(TestProtocolDatabaseError *)error errorList:(NSArray/*<TestProtocolDatabaseError>*/ *)errorList
{
if (!(self = [super init]))
return nil;
@@ -1779,7 +1779,7 @@
return self;
}
-- (instancetype)initWithInteger:(NSString *)integer array:(NSString *)array string:(NSString *)string value:(NSString *)value object:(NSString *)object;
+- (instancetype)initWithInteger:(NSString *)integer array:(NSString *)array string:(NSString *)string value:(NSString *)value object:(NSString *)object
{
if (!(self = [super init]))
return nil;
@@ -1906,7 +1906,7 @@
return self;
}
-- (instancetype)initWithColumnNames:(NSArray/*<NSString>*/ *)columnNames notes:(NSString *)notes timestamp:(double)timestamp values:(RWIProtocolJSONObject *)values payload:(RWIProtocolJSONObject *)payload error:(TestProtocolDatabaseError *)error;
+- (instancetype)initWithColumnNames:(NSArray/*<NSString>*/ *)columnNames notes:(NSString *)notes timestamp:(double)timestamp values:(RWIProtocolJSONObject *)values payload:(RWIProtocolJSONObject *)payload error:(TestProtocolDatabaseError *)error
{
if (!(self = [super init]))
return nil;
Modified: trunk/Source/_javascript_Core/inspector/scripts/tests/expected/type-requiring-runtime-casts.json-result (209231 => 209232)
--- trunk/Source/_javascript_Core/inspector/scripts/tests/expected/type-requiring-runtime-casts.json-result 2016-12-02 05:31:07 UTC (rev 209231)
+++ trunk/Source/_javascript_Core/inspector/scripts/tests/expected/type-requiring-runtime-casts.json-result 2016-12-02 06:08:30 UTC (rev 209232)
@@ -1453,7 +1453,7 @@
return self;
}
-- (instancetype)initWithString:(NSString *)string number:(int)number animals:(TestProtocolTestCastedAnimals)animals identifier:(int)identifier tree:(TestProtocolTestRecursiveObject1 *)tree;
+- (instancetype)initWithString:(NSString *)string number:(int)number animals:(TestProtocolTestCastedAnimals)animals identifier:(int)identifier tree:(TestProtocolTestRecursiveObject1 *)tree
{
if (!(self = [super init]))
return nil;
