Title: [211242] trunk/Source/WebCore
- Revision
- 211242
- Author
- commit-qu...@webkit.org
- Date
- 2017-01-26 16:57:36 -0800 (Thu, 26 Jan 2017)
Log Message
Unreviewed, rolling out r210328.
https://bugs.webkit.org/show_bug.cgi?id=167476
Blocking bug is fixed <rdar://problem/29957753> (Requested by
keith_miller on #webkit).
Reverted changeset:
"Disable smooth playhead animation for main content media in
the Touch Bar"
https://bugs.webkit.org/show_bug.cgi?id=166715
http://trac.webkit.org/changeset/210328
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (211241 => 211242)
--- trunk/Source/WebCore/ChangeLog 2017-01-27 00:56:44 UTC (rev 211241)
+++ trunk/Source/WebCore/ChangeLog 2017-01-27 00:57:36 UTC (rev 211242)
@@ -1,3 +1,18 @@
+2017-01-26 Commit Queue <commit-qu...@webkit.org>
+
+ Unreviewed, rolling out r210328.
+ https://bugs.webkit.org/show_bug.cgi?id=167476
+
+ Blocking bug is fixed <rdar://problem/29957753> (Requested by
+ keith_miller on #webkit).
+
+ Reverted changeset:
+
+ "Disable smooth playhead animation for main content media in
+ the Touch Bar"
+ https://bugs.webkit.org/show_bug.cgi?id=166715
+ http://trac.webkit.org/changeset/210328
+
2017-01-26 Joseph Pecoraro <pecor...@apple.com>
Web Inspector: iOS: Memory timeline shows impossible values for Page size (underflowed)
Modified: trunk/Source/WebCore/platform/mac/WebPlaybackSessionInterfaceMac.mm (211241 => 211242)
--- trunk/Source/WebCore/platform/mac/WebPlaybackSessionInterfaceMac.mm 2017-01-27 00:56:44 UTC (rev 211241)
+++ trunk/Source/WebCore/platform/mac/WebPlaybackSessionInterfaceMac.mm 2017-01-27 00:57:36 UTC (rev 211242)
@@ -220,10 +220,7 @@
|| (manager.rate < 0 && model->playbackStartedTime() <= currentTime))
effectivePlaybackRate = 0;
- // FIXME: The timing value should ideally use the effective playback rate, but this causes AVKit to indefinitely fire a repeating timer.
- // More investigation will be required before we re-enable smooth playhead animation -- for now, we should just pretend that the playback
- // rate is always 0.
- manager.timing = [getAVValueTimingClass() valueTimingWithAnchorValue:currentTime anchorTimeStamp:effectiveAnchorTime rate:0];
+ manager.timing = [getAVValueTimingClass() valueTimingWithAnchorValue:currentTime anchorTimeStamp:effectiveAnchorTime rate:effectivePlaybackRate];
}
#endif // ENABLE(WEB_PLAYBACK_CONTROLS_MANAGER)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes