Title: [220466] trunk/Tools
Revision
220466
Author
wei...@apple.com
Date
2017-08-09 11:03:11 -0700 (Wed, 09 Aug 2017)

Log Message

Update for https://bugs.webkit.org/show_bug.cgi?id=175244.

* TestWebKitAPI/Tests/WTF/Function.cpp:
Remove tests of null Functions, as they are no longer supported.

Modified Paths

Diff

Modified: trunk/Tools/ChangeLog (220465 => 220466)


--- trunk/Tools/ChangeLog	2017-08-09 17:58:12 UTC (rev 220465)
+++ trunk/Tools/ChangeLog	2017-08-09 18:03:11 UTC (rev 220466)
@@ -1,3 +1,10 @@
+2017-08-09  Sam Weinig  <s...@webkit.org>
+
+        Update for https://bugs.webkit.org/show_bug.cgi?id=175244.
+
+        * TestWebKitAPI/Tests/WTF/Function.cpp:
+        Remove tests of null Functions, as they are no longer supported.
+
 2017-08-09  Daniel Bates  <daba...@apple.com>
 
         REGRESSION (r219013): OAuth flows are broken when redirecting back to application after authentication

Modified: trunk/Tools/TestWebKitAPI/Tests/WTF/Function.cpp (220465 => 220466)


--- trunk/Tools/TestWebKitAPI/Tests/WTF/Function.cpp	2017-08-09 17:58:12 UTC (rev 220465)
+++ trunk/Tools/TestWebKitAPI/Tests/WTF/Function.cpp	2017-08-09 18:03:11 UTC (rev 220466)
@@ -149,10 +149,6 @@
     EXPECT_TRUE(static_cast<bool>(a));
     EXPECT_EQ(1U, a());
 
-    a = nullptr;
-    EXPECT_FALSE(static_cast<bool>(a));
-    EXPECT_EQ(0U, a());
-
     a = MoveOnly { 2 };
     EXPECT_TRUE(static_cast<bool>(a));
     EXPECT_EQ(2U, a());
@@ -175,10 +171,6 @@
     EXPECT_EQ(3U, b());
     EXPECT_FALSE(static_cast<bool>(c));
     EXPECT_EQ(0U, c());
-
-    Function<unsigned()> d = nullptr;
-    EXPECT_FALSE(static_cast<bool>(d));
-    EXPECT_EQ(0U, d());
 }
 
 struct FunctionDestructionChecker {
@@ -222,15 +214,6 @@
     FunctionDestructionChecker::functionResult = std::nullopt;
 
     a = FunctionDestructionChecker(a);
-    a = nullptr;
-    EXPECT_TRUE(static_cast<bool>(FunctionDestructionChecker::functionAsBool));
-    EXPECT_TRUE(static_cast<bool>(FunctionDestructionChecker::functionResult));
-    EXPECT_FALSE(FunctionDestructionChecker::functionAsBool.value());
-    EXPECT_EQ(0U, FunctionDestructionChecker::functionResult.value());
-    FunctionDestructionChecker::functionAsBool = std::nullopt;
-    FunctionDestructionChecker::functionResult = std::nullopt;
-
-    a = FunctionDestructionChecker(a);
     a = MoveOnly { 2 };
     EXPECT_TRUE(static_cast<bool>(FunctionDestructionChecker::functionAsBool));
     EXPECT_TRUE(static_cast<bool>(FunctionDestructionChecker::functionResult));
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to