Title: [220531] trunk/Source/WebCore
- Revision
- 220531
- Author
- mmaxfi...@apple.com
- Date
- 2017-08-10 09:59:28 -0700 (Thu, 10 Aug 2017)
Log Message
Addressing post-review comments after r219173.
https://bugs.webkit.org/show_bug.cgi?id=174149
Unreviewed.
* css/CSSFontStyleValue.h:
* editing/EditingStyle.cpp:
(WebCore::identifierForStyleProperty):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (220530 => 220531)
--- trunk/Source/WebCore/ChangeLog 2017-08-10 16:53:08 UTC (rev 220530)
+++ trunk/Source/WebCore/ChangeLog 2017-08-10 16:59:28 UTC (rev 220531)
@@ -1,3 +1,14 @@
+2017-08-10 Myles C. Maxfield <mmaxfi...@apple.com>
+
+ Addressing post-review comments after r219173.
+ https://bugs.webkit.org/show_bug.cgi?id=174149
+
+ Unreviewed.
+
+ * css/CSSFontStyleValue.h:
+ * editing/EditingStyle.cpp:
+ (WebCore::identifierForStyleProperty):
+
2017-08-10 Antti Koivisto <an...@apple.com>
Try to fix windows build.
Modified: trunk/Source/WebCore/css/CSSFontStyleValue.h (220530 => 220531)
--- trunk/Source/WebCore/css/CSSFontStyleValue.h 2017-08-10 16:53:08 UTC (rev 220530)
+++ trunk/Source/WebCore/css/CSSFontStyleValue.h 2017-08-10 16:59:28 UTC (rev 220531)
@@ -46,7 +46,7 @@
bool equals(const CSSFontStyleValue&) const;
- bool isItalic() const
+ bool isItalicOrOblique() const
{
if (!obliqueValue) {
auto valueID = fontStyleValue->valueID();
Modified: trunk/Source/WebCore/editing/EditingStyle.cpp (220530 => 220531)
--- trunk/Source/WebCore/editing/EditingStyle.cpp 2017-08-10 16:53:08 UTC (rev 220530)
+++ trunk/Source/WebCore/editing/EditingStyle.cpp 2017-08-10 16:59:28 UTC (rev 220531)
@@ -142,7 +142,7 @@
int identifierForStyleProperty(T& style, CSSPropertyID propertyID)
{
RefPtr<CSSValue> value = extractPropertyValue(style, propertyID);
- if (propertyID == CSSPropertyFontStyle && is<CSSFontStyleValue>(value.get()) && downcast<CSSFontStyleValue>(value.get())->isItalic())
+ if (propertyID == CSSPropertyFontStyle && is<CSSFontStyleValue>(value.get()) && downcast<CSSFontStyleValue>(value.get())->isItalicOrOblique())
return CSSValueItalic;
if (!is<CSSPrimitiveValue>(value.get()))
return 0;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
