Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (220537 => 220538)
--- trunk/Source/_javascript_Core/ChangeLog 2017-08-10 18:57:22 UTC (rev 220537)
+++ trunk/Source/_javascript_Core/ChangeLog 2017-08-10 19:05:51 UTC (rev 220538)
@@ -1,3 +1,14 @@
+2017-08-10 Tim Horton <timothy_hor...@apple.com>
+
+ Remove some unused lambda captures so that WebKit builds with -Wunused-lambda-capture
+ https://bugs.webkit.org/show_bug.cgi?id=175436
+ <rdar://problem/33667497>
+
+ Reviewed by Simon Fraser.
+
+ * interpreter/Interpreter.cpp:
+ (JSC::Interpreter::Interpreter):
+
2017-08-10 Michael Catanzaro <mcatanz...@igalia.com>
Remove ENABLE_GAMEPAD_DEPRECATED
Modified: trunk/Source/_javascript_Core/interpreter/Interpreter.cpp (220537 => 220538)
--- trunk/Source/_javascript_Core/interpreter/Interpreter.cpp 2017-08-10 18:57:22 UTC (rev 220537)
+++ trunk/Source/_javascript_Core/interpreter/Interpreter.cpp 2017-08-10 19:05:51 UTC (rev 220538)
@@ -322,7 +322,7 @@
{
#if !ASSERT_DISABLED
static std::once_flag assertOnceKey;
- std::call_once(assertOnceKey, [this] {
+ std::call_once(assertOnceKey, [] {
for (unsigned i = 0; i < NUMBER_OF_BYTECODE_IDS; ++i) {
OpcodeID opcodeID = static_cast<OpcodeID>(i);
RELEASE_ASSERT(getOpcodeID(getOpcode(opcodeID)) == opcodeID);
Modified: trunk/Source/WebCore/ChangeLog (220537 => 220538)
--- trunk/Source/WebCore/ChangeLog 2017-08-10 18:57:22 UTC (rev 220537)
+++ trunk/Source/WebCore/ChangeLog 2017-08-10 19:05:51 UTC (rev 220538)
@@ -1,3 +1,16 @@
+2017-08-10 Tim Horton <timothy_hor...@apple.com>
+
+ Remove some unused lambda captures so that WebKit builds with -Wunused-lambda-capture
+ https://bugs.webkit.org/show_bug.cgi?id=175436
+ <rdar://problem/33667497>
+
+ Reviewed by Simon Fraser.
+
+ * platform/audio/cocoa/MediaSessionManagerCocoa.cpp:
+ (PlatformMediaSessionManager::updateSessionState):
+ * platform/graphics/cocoa/WebCoreDecompressionSession.mm:
+ (WebCore::WebCoreDecompressionSession::handleDecompressionOutput):
+
2017-08-10 Commit Queue <commit-qu...@webkit.org>
Unreviewed, rolling out r220463.
Modified: trunk/Source/WebCore/platform/audio/cocoa/MediaSessionManagerCocoa.cpp (220537 => 220538)
--- trunk/Source/WebCore/platform/audio/cocoa/MediaSessionManagerCocoa.cpp 2017-08-10 18:57:22 UTC (rev 220537)
+++ trunk/Source/WebCore/platform/audio/cocoa/MediaSessionManagerCocoa.cpp 2017-08-10 19:05:51 UTC (rev 220538)
@@ -62,7 +62,7 @@
bool hasWebAudioType = false;
bool hasAudibleAudioOrVideoMediaType = false;
- bool hasAudioCapture = anyOfSessions([this, &hasWebAudioType, &hasAudibleAudioOrVideoMediaType] (PlatformMediaSession& session, size_t) mutable {
+ bool hasAudioCapture = anyOfSessions([&hasWebAudioType, &hasAudibleAudioOrVideoMediaType] (PlatformMediaSession& session, size_t) mutable {
auto type = session.mediaType();
if (type == PlatformMediaSession::WebAudio)
hasWebAudioType = true;
Modified: trunk/Source/WebCore/platform/graphics/cocoa/WebCoreDecompressionSession.mm (220537 => 220538)
--- trunk/Source/WebCore/platform/graphics/cocoa/WebCoreDecompressionSession.mm 2017-08-10 18:57:22 UTC (rev 220537)
+++ trunk/Source/WebCore/platform/graphics/cocoa/WebCoreDecompressionSession.mm 2017-08-10 19:05:51 UTC (rev 220538)
@@ -224,6 +224,9 @@
void WebCoreDecompressionSession::handleDecompressionOutput(bool displaying, OSStatus status, VTDecodeInfoFlags infoFlags, CVImageBufferRef rawImageBuffer, CMTime presentationTimeStamp, CMTime presentationDuration)
{
+ UNUSED_PARAM(status);
+ UNUSED_PARAM(infoFlags);
+
CMVideoFormatDescriptionRef rawImageBufferDescription = nullptr;
if (noErr != CMVideoFormatDescriptionCreateForImageBuffer(kCFAllocatorDefault, rawImageBuffer, &rawImageBufferDescription))
return;
@@ -240,8 +243,7 @@
return;
RefPtr<WebCoreDecompressionSession> protectedThis { this };
RetainPtr<CMSampleBufferRef> imageSampleBuffer = adoptCF(rawImageSampleBuffer);
- dispatch_async(m_enqueingQueue.get(), [protectedThis, status, imageSampleBuffer, infoFlags, displaying] {
- UNUSED_PARAM(infoFlags);
+ dispatch_async(m_enqueingQueue.get(), [protectedThis, imageSampleBuffer, displaying] {
protectedThis->enqueueDecodedSample(imageSampleBuffer.get(), displaying);
});
}
Modified: trunk/Source/WebKit/ChangeLog (220537 => 220538)
--- trunk/Source/WebKit/ChangeLog 2017-08-10 18:57:22 UTC (rev 220537)
+++ trunk/Source/WebKit/ChangeLog 2017-08-10 19:05:51 UTC (rev 220538)
@@ -1,3 +1,16 @@
+2017-08-10 Tim Horton <timothy_hor...@apple.com>
+
+ Remove some unused lambda captures so that WebKit builds with -Wunused-lambda-capture
+ https://bugs.webkit.org/show_bug.cgi?id=175436
+ <rdar://problem/33667497>
+
+ Reviewed by Simon Fraser.
+
+ * UIProcess/UserMediaPermissionRequestManagerProxy.cpp:
+ (WebKit::UserMediaPermissionRequestManagerProxy::requestUserMediaPermissionForFrame):
+ * UIProcess/WebsiteData/WebsiteDataStore.cpp:
+ (WebKit::WebsiteDataStore::topPrivatelyControlledDomainsWithWebsiteData):
+
2017-08-10 Michael Catanzaro <mcatanz...@igalia.com>
Remove ENABLE_GAMEPAD_DEPRECATED
Modified: trunk/Source/WebKit/UIProcess/UserMediaPermissionRequestManagerProxy.cpp (220537 => 220538)
--- trunk/Source/WebKit/UIProcess/UserMediaPermissionRequestManagerProxy.cpp 2017-08-10 18:57:22 UTC (rev 220537)
+++ trunk/Source/WebKit/UIProcess/UserMediaPermissionRequestManagerProxy.cpp 2017-08-10 19:05:51 UTC (rev 220538)
@@ -305,7 +305,7 @@
userMediaAccessWasDenied(userMediaID, UserMediaPermissionRequestProxy::UserMediaAccessDenialReason::UserMediaDisabled);
};
- auto haveDeviceSaltHandler = [this, userMediaID, validHandler = WTFMove(validHandler), invalidHandler = WTFMove(invalidHandler), audioConstraints = WebCore::MediaConstraints(audioConstraints), videoConstraints = WebCore::MediaConstraints(videoConstraints)](uint64_t userMediaID, String&& deviceIdentifierHashSalt, bool originHasPersistentAccess) mutable {
+ auto haveDeviceSaltHandler = [this, validHandler = WTFMove(validHandler), invalidHandler = WTFMove(invalidHandler), audioConstraints = WebCore::MediaConstraints(audioConstraints), videoConstraints = WebCore::MediaConstraints(videoConstraints)](uint64_t userMediaID, String&& deviceIdentifierHashSalt, bool originHasPersistentAccess) mutable {
auto request = m_pendingDeviceRequests.take(userMediaID);
if (!request)
Modified: trunk/Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp (220537 => 220538)
--- trunk/Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp 2017-08-10 18:57:22 UTC (rev 220537)
+++ trunk/Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp 2017-08-10 19:05:51 UTC (rev 220538)
@@ -538,7 +538,7 @@
void WebsiteDataStore::topPrivatelyControlledDomainsWithWebsiteData(OptionSet<WebsiteDataType> dataTypes, OptionSet<WebsiteDataFetchOption> fetchOptions, Function<void(HashSet<String>&&)>&& completionHandler)
{
- fetchData(dataTypes, fetchOptions, [completionHandler = WTFMove(completionHandler), this, protectedThis = makeRef(*this)](auto&& existingDataRecords) {
+ fetchData(dataTypes, fetchOptions, [completionHandler = WTFMove(completionHandler), protectedThis = makeRef(*this)](auto&& existingDataRecords) {
HashSet<String> domainsWithDataRecords;
for (auto&& dataRecord : existingDataRecords) {
String domain = dataRecord.topPrivatelyControlledDomain();
Modified: trunk/Tools/ChangeLog (220537 => 220538)
--- trunk/Tools/ChangeLog 2017-08-10 18:57:22 UTC (rev 220537)
+++ trunk/Tools/ChangeLog 2017-08-10 19:05:51 UTC (rev 220538)
@@ -1,3 +1,14 @@
+2017-08-10 Tim Horton <timothy_hor...@apple.com>
+
+ Remove some unused lambda captures so that WebKit builds with -Wunused-lambda-capture
+ https://bugs.webkit.org/show_bug.cgi?id=175436
+ <rdar://problem/33667497>
+
+ Reviewed by Simon Fraser.
+
+ * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
+ (TestWebKitAPI::TEST_F):
+
2017-08-10 Lucas Forschler <lforsch...@apple.com>
Fix duplicated code in r220534.
Modified: trunk/Tools/TestWebKitAPI/Tests/WebCore/FileMonitor.cpp (220537 => 220538)
--- trunk/Tools/TestWebKitAPI/Tests/WebCore/FileMonitor.cpp 2017-08-10 18:57:22 UTC (rev 220537)
+++ trunk/Tools/TestWebKitAPI/Tests/WebCore/FileMonitor.cpp 2017-08-10 19:05:51 UTC (rev 220538)
@@ -149,7 +149,7 @@
auto testQueue = WorkQueue::create("Test Work Queue");
- auto monitor = std::make_unique<FileMonitor>(tempFilePath(), testQueue.copyRef(), [this] (FileMonitor::FileChangeType type) {
+ auto monitor = std::make_unique<FileMonitor>(tempFilePath(), testQueue.copyRef(), [] (FileMonitor::FileChangeType type) {
ASSERT(!RunLoop::isMain());
switch (type) {
case FileMonitor::FileChangeType::Modification:
@@ -191,7 +191,7 @@
auto testQueue = WorkQueue::create("Test Work Queue");
- auto monitor = std::make_unique<FileMonitor>(tempFilePath(), testQueue.copyRef(), [this] (FileMonitor::FileChangeType type) {
+ auto monitor = std::make_unique<FileMonitor>(tempFilePath(), testQueue.copyRef(), [] (FileMonitor::FileChangeType type) {
ASSERT(!RunLoop::isMain());
switch (type) {
case FileMonitor::FileChangeType::Modification:
@@ -251,7 +251,7 @@
auto testQueue = WorkQueue::create("Test Work Queue");
- auto monitor = std::make_unique<FileMonitor>(tempFilePath(), testQueue.copyRef(), [this] (FileMonitor::FileChangeType type) {
+ auto monitor = std::make_unique<FileMonitor>(tempFilePath(), testQueue.copyRef(), [] (FileMonitor::FileChangeType type) {
ASSERT(!RunLoop::isMain());
switch (type) {
case FileMonitor::FileChangeType::Modification:
@@ -290,7 +290,7 @@
auto testQueue = WorkQueue::create("Test Work Queue");
- auto monitor = std::make_unique<FileMonitor>(tempFilePath(), testQueue.copyRef(), [this] (FileMonitor::FileChangeType type) {
+ auto monitor = std::make_unique<FileMonitor>(tempFilePath(), testQueue.copyRef(), [] (FileMonitor::FileChangeType type) {
ASSERT(!RunLoop::isMain());
switch (type) {
case FileMonitor::FileChangeType::Modification:
@@ -347,7 +347,7 @@
auto testQueue = WorkQueue::create("Test Work Queue");
- auto monitor = std::make_unique<FileMonitor>(tempFilePath(), testQueue.copyRef(), [this] (FileMonitor::FileChangeType type) {
+ auto monitor = std::make_unique<FileMonitor>(tempFilePath(), testQueue.copyRef(), [] (FileMonitor::FileChangeType type) {
ASSERT(!RunLoop::isMain());
switch (type) {
case FileMonitor::FileChangeType::Modification:
