Title: [228034] trunk/Source/WebCore
- Revision
- 228034
- Author
- commit-qu...@webkit.org
- Date
- 2018-02-02 16:39:31 -0800 (Fri, 02 Feb 2018)
Log Message
Clearing all service worker registrations should wait for importing service worker registration to finish
https://bugs.webkit.org/show_bug.cgi?id=182407
<rdar://problem/37167523>
Patch by Youenn Fablet <you...@apple.com> on 2018-02-02
Reviewed by Chris Dumez.
* workers/service/server/SWServer.cpp:
(WebCore::SWServer::clear): ensure completion handler is called on early exit case.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (228033 => 228034)
--- trunk/Source/WebCore/ChangeLog 2018-02-03 00:36:20 UTC (rev 228033)
+++ trunk/Source/WebCore/ChangeLog 2018-02-03 00:39:31 UTC (rev 228034)
@@ -2,9 +2,20 @@
Clearing all service worker registrations should wait for importing service worker registration to finish
https://bugs.webkit.org/show_bug.cgi?id=182407
+ <rdar://problem/37167523>
Reviewed by Chris Dumez.
+ * workers/service/server/SWServer.cpp:
+ (WebCore::SWServer::clear): ensure completion handler is called on early exit case.
+
+2018-02-02 Youenn Fablet <you...@apple.com>
+
+ Clearing all service worker registrations should wait for importing service worker registration to finish
+ https://bugs.webkit.org/show_bug.cgi?id=182407
+
+ Reviewed by Chris Dumez.
+
Covered by existing tests and the service worker API test being no longer flaky.
* workers/service/server/SWServer.cpp:
Modified: trunk/Source/WebCore/workers/service/server/SWServer.cpp (228033 => 228034)
--- trunk/Source/WebCore/workers/service/server/SWServer.cpp 2018-02-03 00:36:20 UTC (rev 228033)
+++ trunk/Source/WebCore/workers/service/server/SWServer.cpp 2018-02-03 00:39:31 UTC (rev 228034)
@@ -230,8 +230,10 @@
return contextData.registration.key.relatesToOrigin(origin);
});
- if (registrationsToRemove.isEmpty())
+ if (registrationsToRemove.isEmpty()) {
+ completionHandler();
return;
+ }
// Calling SWServerRegistration::clear() takes care of updating m_registrations, m_originStore and m_registrationStore.
for (auto* registration : registrationsToRemove)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
