Title: [228405] branches/safari-605-branch/Source/WebCore
Revision
228405
Author
jmarc...@apple.com
Date
2018-02-12 17:00:06 -0800 (Mon, 12 Feb 2018)

Log Message

Apply patch. rdar://problem/37470882

    CoreAudioCaptureSourceIOSListener should be a WebProcess singleton

Modified Paths

Diff

Modified: branches/safari-605-branch/Source/WebCore/ChangeLog (228404 => 228405)


--- branches/safari-605-branch/Source/WebCore/ChangeLog	2018-02-13 00:59:14 UTC (rev 228404)
+++ branches/safari-605-branch/Source/WebCore/ChangeLog	2018-02-13 01:00:06 UTC (rev 228405)
@@ -1,5 +1,26 @@
 2018-02-12  Jason Marcell  <jmarc...@apple.com>
 
+        Apply patch. rdar://problem/37470882
+
+    CoreAudioCaptureSourceIOSListener should be a WebProcess singleton
+
+    2018-02-12  Youenn Fablet  <you...@apple.com>
+
+            CoreAudioCaptureSourceIOSListener should be a WebProcess singleton
+            https://bugs.webkit.org/show_bug.cgi?id=182606
+            <rdar://problem/37470882>
+
+            Reviewed by Eric Carlson.
+
+            Covered by manual testing.
+            In case shared unit is suspended, unsuspend it when creating a new audio source.
+            This creation should only happen when WebKit iOS is foregrounded.
+
+            * platform/mediastream/mac/CoreAudioCaptureSource.cpp:
+            (WebCore::CoreAudioCaptureSource::CoreAudioCaptureSource):
+
+2018-02-12  Jason Marcell  <jmarc...@apple.com>
+
         Cherry-pick r228231. rdar://problem/37408885
 
     2018-02-07  Daniel Bates  <daba...@apple.com>

Modified: branches/safari-605-branch/Source/WebCore/platform/mediastream/mac/CoreAudioCaptureSource.cpp (228404 => 228405)


--- branches/safari-605-branch/Source/WebCore/platform/mediastream/mac/CoreAudioCaptureSource.cpp	2018-02-13 00:59:14 UTC (rev 228404)
+++ branches/safari-605-branch/Source/WebCore/platform/mediastream/mac/CoreAudioCaptureSource.cpp	2018-02-13 01:00:06 UTC (rev 228405)
@@ -724,6 +724,13 @@
     initializeVolume(unit.volume());
 
     unit.addClient(*this);
+
+#if PLATFORM(IOS)
+    // We ensure that we unsuspend ourselves on the constructor as a capture source
+    // is created when getUserMedia grants access which only happens when the process is foregrounded.
+    if (unit.isSuspended())
+        unit.reconfigureAudioUnit();
+#endif
 }
 
 CoreAudioCaptureSource::~CoreAudioCaptureSource()
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to