Title: [228927] trunk/Source/WebCore
- Revision
- 228927
- Author
- commit-qu...@webkit.org
- Date
- 2018-02-22 11:41:18 -0800 (Thu, 22 Feb 2018)
Log Message
[Curl] Fix warning on clang.
https://bugs.webkit.org/show_bug.cgi?id=182986
Patch by Basuke Suzuki <basuke.suz...@sony.com> on 2018-02-22
Reviewed by Konstantin Tokarev.
No new tests because there's no behaviro changes.
* platform/network/curl/CurlResourceHandleDelegate.cpp:
(WebCore::CurlResourceHandleDelegate::curlDidSendData):
(WebCore::CurlResourceHandleDelegate::curlDidReceiveBuffer):
(WebCore::CurlResourceHandleDelegate::curlDidFailWithError):
* platform/network/curl/CurlResourceHandleDelegate.h:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (228926 => 228927)
--- trunk/Source/WebCore/ChangeLog 2018-02-22 18:54:07 UTC (rev 228926)
+++ trunk/Source/WebCore/ChangeLog 2018-02-22 19:41:18 UTC (rev 228927)
@@ -1,3 +1,18 @@
+2018-02-22 Basuke Suzuki <basuke.suz...@sony.com>
+
+ [Curl] Fix warning on clang.
+ https://bugs.webkit.org/show_bug.cgi?id=182986
+
+ Reviewed by Konstantin Tokarev.
+
+ No new tests because there's no behaviro changes.
+
+ * platform/network/curl/CurlResourceHandleDelegate.cpp:
+ (WebCore::CurlResourceHandleDelegate::curlDidSendData):
+ (WebCore::CurlResourceHandleDelegate::curlDidReceiveBuffer):
+ (WebCore::CurlResourceHandleDelegate::curlDidFailWithError):
+ * platform/network/curl/CurlResourceHandleDelegate.h:
+
2018-02-22 Youenn Fablet <you...@apple.com>
WorkerCacheStorageConnection::doRemove can assert in case two frames try to delete the same cache at the same time
Modified: trunk/Source/WebCore/platform/network/curl/CurlResourceHandleDelegate.cpp (228926 => 228927)
--- trunk/Source/WebCore/platform/network/curl/CurlResourceHandleDelegate.cpp 2018-02-22 18:54:07 UTC (rev 228926)
+++ trunk/Source/WebCore/platform/network/curl/CurlResourceHandleDelegate.cpp 2018-02-22 19:41:18 UTC (rev 228927)
@@ -76,6 +76,7 @@
void CurlResourceHandleDelegate::curlDidSendData(CurlRequest& request, unsigned long long bytesSent, unsigned long long totalBytesToBeSent)
{
+ UNUSED_PARAM(request);
ASSERT(isMainThread());
if (cancelledOrClientless())
@@ -144,6 +145,7 @@
void CurlResourceHandleDelegate::curlDidReceiveBuffer(CurlRequest& request, Ref<SharedBuffer>&& buffer)
{
+ UNUSED_PARAM(request);
ASSERT(isMainThread());
if (cancelledOrClientless())
@@ -168,6 +170,7 @@
void CurlResourceHandleDelegate::curlDidFailWithError(CurlRequest& request, const ResourceError& resourceError)
{
+ UNUSED_PARAM(request);
ASSERT(isMainThread());
if (cancelledOrClientless())
Modified: trunk/Source/WebCore/platform/network/curl/CurlResourceHandleDelegate.h (228926 => 228927)
--- trunk/Source/WebCore/platform/network/curl/CurlResourceHandleDelegate.h 2018-02-22 18:54:07 UTC (rev 228926)
+++ trunk/Source/WebCore/platform/network/curl/CurlResourceHandleDelegate.h 2018-02-22 19:41:18 UTC (rev 228927)
@@ -39,7 +39,7 @@
class ResourceHandleClient;
class ResourceHandleInternal;
-class CurlResourceHandleDelegate : public CurlRequestClient {
+class CurlResourceHandleDelegate final : public CurlRequestClient {
WTF_MAKE_NONCOPYABLE(CurlResourceHandleDelegate); WTF_MAKE_FAST_ALLOCATED;
public:
CurlResourceHandleDelegate(ResourceHandle&);
@@ -48,14 +48,14 @@
// CurlRequestClient methods
- void ref();
- void deref();
+ void ref() final;
+ void deref() final;
- void curlDidSendData(CurlRequest&, unsigned long long bytesSent, unsigned long long totalBytesToBeSent) override;
- void curlDidReceiveResponse(CurlRequest&, const CurlResponse&) override;
- void curlDidReceiveBuffer(CurlRequest&, Ref<SharedBuffer>&&) override;
- void curlDidComplete(CurlRequest&) override;
- void curlDidFailWithError(CurlRequest&, const ResourceError&) override;
+ void curlDidSendData(CurlRequest&, unsigned long long bytesSent, unsigned long long totalBytesToBeSent) final;
+ void curlDidReceiveResponse(CurlRequest&, const CurlResponse&) final;
+ void curlDidReceiveBuffer(CurlRequest&, Ref<SharedBuffer>&&) final;
+ void curlDidComplete(CurlRequest&) final;
+ void curlDidFailWithError(CurlRequest&, const ResourceError&) final;
private:
ResourceHandle& m_handle;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
