Title: [228934] trunk/Source/WebCore
Revision
228934
Author
cdu...@apple.com
Date
2018-02-22 14:36:47 -0800 (Thu, 22 Feb 2018)

Log Message

ResourceRequestBase::isolatedCopy() fails to isolate copy the cachePartition
https://bugs.webkit.org/show_bug.cgi?id=183059
<rdar://problem/37800202>

Reviewed by Youenn Fablet.

Update ResourceRequestBase::setAsIsolatedCopy() to call isolatedCopy() on the cachePartition as well,
given that it is a String and it would not be safe to send it to another thread otherwise.

* platform/network/ResourceRequestBase.cpp:
(WebCore::ResourceRequestBase::setAsIsolatedCopy):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (228933 => 228934)


--- trunk/Source/WebCore/ChangeLog	2018-02-22 22:05:06 UTC (rev 228933)
+++ trunk/Source/WebCore/ChangeLog	2018-02-22 22:36:47 UTC (rev 228934)
@@ -1,5 +1,19 @@
 2018-02-22  Chris Dumez  <cdu...@apple.com>
 
+        ResourceRequestBase::isolatedCopy() fails to isolate copy the cachePartition
+        https://bugs.webkit.org/show_bug.cgi?id=183059
+        <rdar://problem/37800202>
+
+        Reviewed by Youenn Fablet.
+
+        Update ResourceRequestBase::setAsIsolatedCopy() to call isolatedCopy() on the cachePartition as well,
+        given that it is a String and it would not be safe to send it to another thread otherwise.
+
+        * platform/network/ResourceRequestBase.cpp:
+        (WebCore::ResourceRequestBase::setAsIsolatedCopy):
+
+2018-02-22  Chris Dumez  <cdu...@apple.com>
+
         ServiceWorkerContainer::startScriptFetchForJob() fails to isolate copy the registrationKey before passing it to the main thread
         https://bugs.webkit.org/show_bug.cgi?id=183050
         <rdar://problem/37796881>

Modified: trunk/Source/WebCore/platform/network/ResourceRequestBase.cpp (228933 => 228934)


--- trunk/Source/WebCore/platform/network/ResourceRequestBase.cpp	2018-02-22 22:05:06 UTC (rev 228933)
+++ trunk/Source/WebCore/platform/network/ResourceRequestBase.cpp	2018-02-22 22:36:47 UTC (rev 228934)
@@ -64,7 +64,7 @@
     setPriority(other.priority());
     setRequester(other.requester());
     setInitiatorIdentifier(other.initiatorIdentifier().isolatedCopy());
-    setCachePartition(other.cachePartition());
+    setCachePartition(other.cachePartition().isolatedCopy());
 
     updateResourceRequest();
     m_httpHeaderFields = other.httpHeaderFields().isolatedCopy();
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to