Title: [229381] trunk/Tools
- Revision
- 229381
- Author
- jbed...@apple.com
- Date
- 2018-03-07 16:16:54 -0800 (Wed, 07 Mar 2018)
Log Message
webkitpy: Allow apple_additions() to define additional ports
https://bugs.webkit.org/show_bug.cgi?id=183412
<rdar://problem/38232353>
Reviewed by Aakash Jain.
* Scripts/webkitpy/port/factory.py:
(PortFactory.get): Allow apple_additions to define port classes to be used
in run-webkit-tests.
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (229380 => 229381)
--- trunk/Tools/ChangeLog 2018-03-08 00:13:29 UTC (rev 229380)
+++ trunk/Tools/ChangeLog 2018-03-08 00:16:54 UTC (rev 229381)
@@ -1,5 +1,17 @@
2018-03-07 Jonathan Bedard <jbed...@apple.com>
+ webkitpy: Allow apple_additions() to define additional ports
+ https://bugs.webkit.org/show_bug.cgi?id=183412
+ <rdar://problem/38232353>
+
+ Reviewed by Aakash Jain.
+
+ * Scripts/webkitpy/port/factory.py:
+ (PortFactory.get): Allow apple_additions to define port classes to be used
+ in run-webkit-tests.
+
+2018-03-07 Jonathan Bedard <jbed...@apple.com>
+
webkitpy: Remove obsolete function from MockAppleAdditions
https://bugs.webkit.org/show_bug.cgi?id=183415
<rdar://problem/38236407>
Modified: trunk/Tools/Scripts/webkitpy/port/factory.py (229380 => 229381)
--- trunk/Tools/Scripts/webkitpy/port/factory.py 2018-03-08 00:13:29 UTC (rev 229380)
+++ trunk/Tools/Scripts/webkitpy/port/factory.py 2018-03-08 00:16:54 UTC (rev 229381)
@@ -118,10 +118,16 @@
appropriate port on this platform."""
port_name = port_name or self._default_port(options)
+ classes = []
for port_class in self.PORT_CLASSES:
module_name, class_name = port_class.rsplit('.', 1)
module = __import__(module_name, globals(), locals(), [], -1)
cls = module.__dict__[class_name]
+ classes.append(cls)
+ if config.apple_additions() and hasattr(config.apple_additions(), 'ports'):
+ classes += config.apple_additions().ports()
+
+ for cls in classes:
if port_name.startswith(cls.port_name):
port_name = cls.determine_full_port_name(self._host, options, port_name)
return cls(self._host, port_name, options=options, **kwargs)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
