Title: [230377] trunk/Source/_javascript_Core
- Revision
- 230377
- Author
- utatane....@gmail.com
- Date
- 2018-04-08 09:47:21 -0700 (Sun, 08 Apr 2018)
Log Message
[JSC] Fix incorrect assertion for VM's regexp buffer lock
https://bugs.webkit.org/show_bug.cgi?id=184398
Reviewed by Mark Lam.
isLocked check before taking a lock is incorrect.
* runtime/VM.cpp:
(JSC::VM::acquireRegExpPatternContexBuffer):
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (230376 => 230377)
--- trunk/Source/_javascript_Core/ChangeLog 2018-04-08 16:21:38 UTC (rev 230376)
+++ trunk/Source/_javascript_Core/ChangeLog 2018-04-08 16:47:21 UTC (rev 230377)
@@ -1,5 +1,17 @@
2018-04-08 Yusuke Suzuki <utatane....@gmail.com>
+ [JSC] Fix incorrect assertion for VM's regexp buffer lock
+ https://bugs.webkit.org/show_bug.cgi?id=184398
+
+ Reviewed by Mark Lam.
+
+ isLocked check before taking a lock is incorrect.
+
+ * runtime/VM.cpp:
+ (JSC::VM::acquireRegExpPatternContexBuffer):
+
+2018-04-08 Yusuke Suzuki <utatane....@gmail.com>
+
[JSC] Introduce op_get_by_id_direct
https://bugs.webkit.org/show_bug.cgi?id=183970
Modified: trunk/Source/_javascript_Core/runtime/VM.cpp (230376 => 230377)
--- trunk/Source/_javascript_Core/runtime/VM.cpp 2018-04-08 16:21:38 UTC (rev 230376)
+++ trunk/Source/_javascript_Core/runtime/VM.cpp 2018-04-08 16:47:21 UTC (rev 230377)
@@ -901,9 +901,8 @@
#if ENABLE(YARR_JIT_ALL_PARENS_EXPRESSIONS)
char* VM::acquireRegExpPatternContexBuffer()
{
- ASSERT(!m_regExpPatternContextLock.isLocked());
-
m_regExpPatternContextLock.lock();
+ ASSERT(m_regExpPatternContextLock.isLocked());
if (!m_regExpPatternContexBuffer)
m_regExpPatternContexBuffer = makeUniqueArray<char>(VM::patternContextBufferSize);
return m_regExpPatternContexBuffer.get();
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
