Title: [230499] trunk/LayoutTests
- Revision
- 230499
- Author
- krol...@apple.com
- Date
- 2018-04-10 16:06:05 -0700 (Tue, 10 Apr 2018)
Log Message
http/tests/security/shape-image-cors-redirect-error-message-logging-*.html tests are flaky
https://bugs.webkit.org/show_bug.cgi?id=155634
<rdar://problem/39326489>
Reviewed by Youenn Fablet.
These tests no longer appear to be flaky. I believe they were
addressed in <https://trac.webkit.org/changeset/217069/webkit>. After
enabling the test and rebasing the results, I ran run-webkit-tests
with --repeat-each=20 --iterations=20, and then I wrapped the
run-webkit-tests command in a loop that invoked it 20 times.
* TestExpectations:
* http/tests/security/shape-image-cors-redirect-error-message-logging-1-expected.txt:
* http/tests/security/shape-image-cors-redirect-error-message-logging-2-expected.txt:
* http/tests/security/shape-image-cors-redirect-error-message-logging-3-expected.txt:
* http/tests/security/shape-image-cors-redirect-error-message-logging-4-expected.txt:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (230498 => 230499)
--- trunk/LayoutTests/ChangeLog 2018-04-10 22:48:49 UTC (rev 230498)
+++ trunk/LayoutTests/ChangeLog 2018-04-10 23:06:05 UTC (rev 230499)
@@ -1,3 +1,23 @@
+2018-04-10 Keith Rollin <krol...@apple.com>
+
+ http/tests/security/shape-image-cors-redirect-error-message-logging-*.html tests are flaky
+ https://bugs.webkit.org/show_bug.cgi?id=155634
+ <rdar://problem/39326489>
+
+ Reviewed by Youenn Fablet.
+
+ These tests no longer appear to be flaky. I believe they were
+ addressed in <https://trac.webkit.org/changeset/217069/webkit>. After
+ enabling the test and rebasing the results, I ran run-webkit-tests
+ with --repeat-each=20 --iterations=20, and then I wrapped the
+ run-webkit-tests command in a loop that invoked it 20 times.
+
+ * TestExpectations:
+ * http/tests/security/shape-image-cors-redirect-error-message-logging-1-expected.txt:
+ * http/tests/security/shape-image-cors-redirect-error-message-logging-2-expected.txt:
+ * http/tests/security/shape-image-cors-redirect-error-message-logging-3-expected.txt:
+ * http/tests/security/shape-image-cors-redirect-error-message-logging-4-expected.txt:
+
2018-04-10 Youenn Fablet <you...@apple.com>
Beacon redirect responses should be CORS validated
Modified: trunk/LayoutTests/TestExpectations (230498 => 230499)
--- trunk/LayoutTests/TestExpectations 2018-04-10 22:48:49 UTC (rev 230498)
+++ trunk/LayoutTests/TestExpectations 2018-04-10 23:06:05 UTC (rev 230499)
@@ -1176,11 +1176,6 @@
webkit.org/b/52185 fast/css/vertical-align-baseline-rowspan-010.html [ ImageOnlyFailure ]
-webkit.org/b/155634 http/tests/security/shape-image-cors-redirect-error-message-logging-1.html [ Pass Failure ]
-webkit.org/b/155634 http/tests/security/shape-image-cors-redirect-error-message-logging-2.html [ Pass Failure ]
-webkit.org/b/155634 http/tests/security/shape-image-cors-redirect-error-message-logging-3.html [ Pass Failure ]
-webkit.org/b/155634 http/tests/security/shape-image-cors-redirect-error-message-logging-4.html [ Pass Failure ]
-
# Content Security Policy failures
webkit.org/b/111869 http/tests/security/contentSecurityPolicy/eval-blocked-and-sends-report.html
webkit.org/b/153148 http/tests/security/contentSecurityPolicy/eval-allowed-in-report-only-mode-and-sends-report.php
Modified: trunk/LayoutTests/http/tests/security/shape-image-cors-redirect-error-message-logging-1-expected.txt (230498 => 230499)
--- trunk/LayoutTests/http/tests/security/shape-image-cors-redirect-error-message-logging-1-expected.txt 2018-04-10 22:48:49 UTC (rev 230498)
+++ trunk/LayoutTests/http/tests/security/shape-image-cors-redirect-error-message-logging-1-expected.txt 2018-04-10 23:06:05 UTC (rev 230499)
@@ -1,4 +1,4 @@
-CONSOLE MESSAGE: Unsafe attempt to load URL http://127.0.0.1:8000/resources/redirect.php?url=""
+CONSOLE MESSAGE: Origin http://127.0.0.1:8000 is not allowed by Access-Control-Allow-Origin.
Verify the error message in console in case of CORS failing checks.
Modified: trunk/LayoutTests/http/tests/security/shape-image-cors-redirect-error-message-logging-2-expected.txt (230498 => 230499)
--- trunk/LayoutTests/http/tests/security/shape-image-cors-redirect-error-message-logging-2-expected.txt 2018-04-10 22:48:49 UTC (rev 230498)
+++ trunk/LayoutTests/http/tests/security/shape-image-cors-redirect-error-message-logging-2-expected.txt 2018-04-10 23:06:05 UTC (rev 230499)
@@ -1,4 +1,4 @@
-CONSOLE MESSAGE: Unsafe attempt to load URL http://localhost:8080/security/resources/redirect-allow-star.php?url=""
+CONSOLE MESSAGE: Origin http://127.0.0.1:8000 is not allowed by Access-Control-Allow-Origin.
Verify the error message in console in case of CORS failing checks.
Modified: trunk/LayoutTests/http/tests/security/shape-image-cors-redirect-error-message-logging-3-expected.txt (230498 => 230499)
--- trunk/LayoutTests/http/tests/security/shape-image-cors-redirect-error-message-logging-3-expected.txt 2018-04-10 22:48:49 UTC (rev 230498)
+++ trunk/LayoutTests/http/tests/security/shape-image-cors-redirect-error-message-logging-3-expected.txt 2018-04-10 23:06:05 UTC (rev 230499)
@@ -1,4 +1,4 @@
-CONSOLE MESSAGE: Cross-origin redirection denied by Cross-Origin Resource Sharing policy: Origin http://127.0.0.1:8000 is not allowed by Access-Control-Allow-Origin.
+CONSOLE MESSAGE: Cross-origin redirection to http://localhost:8080/security/resources/image-access-control.php?file=../../resources/square100.png&allow=true denied by Cross-Origin Resource Sharing policy: Origin http://127.0.0.1:8000 is not allowed by Access-Control-Allow-Origin.
Verify the error message in console in case of CORS failing checks.
Modified: trunk/LayoutTests/http/tests/security/shape-image-cors-redirect-error-message-logging-4-expected.txt (230498 => 230499)
--- trunk/LayoutTests/http/tests/security/shape-image-cors-redirect-error-message-logging-4-expected.txt 2018-04-10 22:48:49 UTC (rev 230498)
+++ trunk/LayoutTests/http/tests/security/shape-image-cors-redirect-error-message-logging-4-expected.txt 2018-04-10 23:06:05 UTC (rev 230499)
@@ -1,4 +1,4 @@
-CONSOLE MESSAGE: Cross-origin redirection denied by Cross-Origin Resource Sharing policy: Redirected to either a non-HTTP URL or a URL that contains credentials.
+CONSOLE MESSAGE: Cross-origin redirection to mailto://example.com denied by Cross-Origin Resource Sharing policy: URL is either a non-HTTP URL or contains credentials.
Verify the error message in console in case of CORS failing checks.
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
