Title: [230616] trunk/Source/WebCore
- Revision
- 230616
- Author
- dba...@webkit.org
- Date
- 2018-04-12 17:11:06 -0700 (Thu, 12 Apr 2018)
Log Message
Attmept to fix the Windows build following <https://trac.webkit.org/changeset/230602/>
(https://bugs.webkit.org/show_bug.cgi?id=184386)
Visual Studio cannot prove that all cases in the switch are covered :(
So, add an ASSERT_NOT_REACHED() and a return a value outside of the switch block.
* loader/cache/CachedResourceLoader.cpp:
(WebCore::destinationForType):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (230615 => 230616)
--- trunk/Source/WebCore/ChangeLog 2018-04-13 00:02:48 UTC (rev 230615)
+++ trunk/Source/WebCore/ChangeLog 2018-04-13 00:11:06 UTC (rev 230616)
@@ -1,3 +1,14 @@
+2018-04-12 Daniel Bates <daba...@apple.com>
+
+ Attmept to fix the Windows build following <https://trac.webkit.org/changeset/230602/>
+ (https://bugs.webkit.org/show_bug.cgi?id=184386)
+
+ Visual Studio cannot prove that all cases in the switch are covered :(
+ So, add an ASSERT_NOT_REACHED() and a return a value outside of the switch block.
+
+ * loader/cache/CachedResourceLoader.cpp:
+ (WebCore::destinationForType):
+
2018-04-12 Chris Dumez <cdu...@apple.com>
Introduce remote variants of Frame / DOMWindow classes
Modified: trunk/Source/WebCore/loader/cache/CachedResourceLoader.cpp (230615 => 230616)
--- trunk/Source/WebCore/loader/cache/CachedResourceLoader.cpp 2018-04-13 00:02:48 UTC (rev 230615)
+++ trunk/Source/WebCore/loader/cache/CachedResourceLoader.cpp 2018-04-13 00:11:06 UTC (rev 230616)
@@ -766,6 +766,8 @@
// The caller is responsible for setting the appropriate destination.
return FetchOptions::Destination::EmptyString;
}
+ ASSERT_NOT_REACHED();
+ return FetchOptions::Destination::EmptyString;
}
ResourceErrorOr<CachedResourceHandle<CachedResource>> CachedResourceLoader::requestResource(CachedResource::Type type, CachedResourceRequest&& request, ForPreload forPreload, DeferOption defer)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
