Title: [230633] trunk/Source/WebKit
- Revision
- 230633
- Author
- bfulg...@apple.com
- Date
- 2018-04-13 09:17:44 -0700 (Fri, 13 Apr 2018)
Log Message
REGRESSION(r230468): Improper assertion firing under STP
<rdar://problem/39411676>
Unreviewed, rolling out an improper assertion.
I added an assertion in Bug 184322 that should not have been added. I did not notice that this
call stack was always used in builds where NSApp is still active. Builds where we stop relying
on AppKit runloops uses a different code path to shut down.
* Shared/mac/ChildProcessMac.mm:
(WebKit::ChildProcess::stopNSAppRunLoop):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (230632 => 230633)
--- trunk/Source/WebKit/ChangeLog 2018-04-13 16:02:11 UTC (rev 230632)
+++ trunk/Source/WebKit/ChangeLog 2018-04-13 16:17:44 UTC (rev 230633)
@@ -1,3 +1,17 @@
+2018-04-13 Brent Fulgham <bfulg...@apple.com>
+
+ REGRESSION(r230468): Improper assertion firing under STP
+ <rdar://problem/39411676>
+
+ Unreviewed, rolling out an improper assertion.
+
+ I added an assertion in Bug 184322 that should not have been added. I did not notice that this
+ call stack was always used in builds where NSApp is still active. Builds where we stop relying
+ on AppKit runloops uses a different code path to shut down.
+
+ * Shared/mac/ChildProcessMac.mm:
+ (WebKit::ChildProcess::stopNSAppRunLoop):
+
2018-04-12 Antoine Quint <grao...@apple.com>
[Web Animations] Turn CSS Animations and CSS Transitions as Web Animations on by default
Modified: trunk/Source/WebKit/Shared/mac/ChildProcessMac.mm (230632 => 230633)
--- trunk/Source/WebKit/Shared/mac/ChildProcessMac.mm 2018-04-13 16:02:11 UTC (rev 230632)
+++ trunk/Source/WebKit/Shared/mac/ChildProcessMac.mm 2018-04-13 16:17:44 UTC (rev 230633)
@@ -38,7 +38,6 @@
#import <pwd.h>
#import <stdlib.h>
#import <sysexits.h>
-#import <wtf/ProcessPrivilege.h>
#import <wtf/Scope.h>
#import <wtf/spi/darwin/SandboxSPI.h>
@@ -206,7 +205,6 @@
void ChildProcess::stopNSAppRunLoop()
{
ASSERT([NSApp isRunning]);
- RELEASE_ASSERT(hasProcessPrivilege(ProcessPrivilege::CanCommunicateWithWindowServer));
[NSApp stop:nil];
NSEvent *event = [NSEvent otherEventWithType:NSEventTypeApplicationDefined location:NSMakePoint(0, 0) modifierFlags:0 timestamp:0.0 windowNumber:0 context:nil subtype:0 data1:0 data2:0];
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
