Title: [230674] trunk/Source/WebCore
- Revision
- 230674
- Author
- commit-qu...@webkit.org
- Date
- 2018-04-16 11:33:13 -0700 (Mon, 16 Apr 2018)
Log Message
[GStreamer] Set *TrackPrivateGStreamer::active based on GstStream default select in constructor
https://bugs.webkit.org/show_bug.cgi?id=184652
Patch by Thibault Saunier <tsaun...@igalia.com> on 2018-04-16
Reviewed by Philippe Normand.
In the constructor we should mark selected streams based on the default values from GstStream,
if the user changes them, they will be updated as required later on.
No new tests are added as we already have a few ones that are currently disabled in
the mediastream testsuite. This patch is part of the work to enable them.
* platform/graphics/gstreamer/AudioTrackPrivateGStreamer.cpp:
(WebCore::AudioTrackPrivateGStreamer::AudioTrackPrivateGStreamer):
* platform/graphics/gstreamer/VideoTrackPrivateGStreamer.cpp:
(WebCore::VideoTrackPrivateGStreamer::VideoTrackPrivateGStreamer):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (230673 => 230674)
--- trunk/Source/WebCore/ChangeLog 2018-04-16 18:29:19 UTC (rev 230673)
+++ trunk/Source/WebCore/ChangeLog 2018-04-16 18:33:13 UTC (rev 230674)
@@ -1,5 +1,23 @@
2018-04-16 Thibault Saunier <tsaun...@igalia.com>
+ [GStreamer] Set *TrackPrivateGStreamer::active based on GstStream default select in constructor
+ https://bugs.webkit.org/show_bug.cgi?id=184652
+
+ Reviewed by Philippe Normand.
+
+ In the constructor we should mark selected streams based on the default values from GstStream,
+ if the user changes them, they will be updated as required later on.
+
+ No new tests are added as we already have a few ones that are currently disabled in
+ the mediastream testsuite. This patch is part of the work to enable them.
+
+ * platform/graphics/gstreamer/AudioTrackPrivateGStreamer.cpp:
+ (WebCore::AudioTrackPrivateGStreamer::AudioTrackPrivateGStreamer):
+ * platform/graphics/gstreamer/VideoTrackPrivateGStreamer.cpp:
+ (WebCore::VideoTrackPrivateGStreamer::VideoTrackPrivateGStreamer):
+
+2018-04-16 Thibault Saunier <tsaun...@igalia.com>
+
[GStreamer] Set TrackPrivateBaseGStreamer metadata information even if no client is avalaible
https://bugs.webkit.org/show_bug.cgi?id=184651
Modified: trunk/Source/WebCore/platform/graphics/gstreamer/AudioTrackPrivateGStreamer.cpp (230673 => 230674)
--- trunk/Source/WebCore/platform/graphics/gstreamer/AudioTrackPrivateGStreamer.cpp 2018-04-16 18:29:19 UTC (rev 230673)
+++ trunk/Source/WebCore/platform/graphics/gstreamer/AudioTrackPrivateGStreamer.cpp 2018-04-16 18:33:13 UTC (rev 230674)
@@ -49,6 +49,7 @@
, m_player(player)
{
m_id = gst_stream_get_stream_id(stream.get());
+ setActive(gst_stream_get_stream_flags(stream.get()) & GST_STREAM_FLAG_SELECT);
notifyTrackOfActiveChanged();
}
#endif
Modified: trunk/Source/WebCore/platform/graphics/gstreamer/VideoTrackPrivateGStreamer.cpp (230673 => 230674)
--- trunk/Source/WebCore/platform/graphics/gstreamer/VideoTrackPrivateGStreamer.cpp 2018-04-16 18:29:19 UTC (rev 230673)
+++ trunk/Source/WebCore/platform/graphics/gstreamer/VideoTrackPrivateGStreamer.cpp 2018-04-16 18:33:13 UTC (rev 230674)
@@ -49,6 +49,7 @@
, m_player(player)
{
m_id = gst_stream_get_stream_id(stream.get());
+ setActive(gst_stream_get_stream_flags(stream.get()) & GST_STREAM_FLAG_SELECT);
notifyTrackOfActiveChanged();
}
#endif
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
