Title: [244503] trunk/Source/WebCore
- Revision
- 244503
- Author
- s...@apple.com
- Date
- 2019-04-22 11:17:33 -0700 (Mon, 22 Apr 2019)
Log Message
Mark SVGStringList properties '[SameObject]' in the IDL files
Followup to https://bugs.webkit.org/show_bug.cgi?id=197137
Patch by Said Abou-Hallawa <s...@apple.com> on 2019-04-22
Reviewed by Darin Adler.
The SVG elements do not create tear-off wrappers for SVGStrigList DOM
objects anymore. Instead they return Ref pointers to the same RefCounted
objects. So they should be marked '[SameObject]' in their IDL files.
* svg/SVGTests.idl:
* svg/SVGViewElement.idl:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (244502 => 244503)
--- trunk/Source/WebCore/ChangeLog 2019-04-22 18:03:47 UTC (rev 244502)
+++ trunk/Source/WebCore/ChangeLog 2019-04-22 18:17:33 UTC (rev 244503)
@@ -1,3 +1,17 @@
+2019-04-22 Said Abou-Hallawa <s...@apple.com>
+
+ Mark SVGStringList properties '[SameObject]' in the IDL files
+ Followup to https://bugs.webkit.org/show_bug.cgi?id=197137
+
+ Reviewed by Darin Adler.
+
+ The SVG elements do not create tear-off wrappers for SVGStrigList DOM
+ objects anymore. Instead they return Ref pointers to the same RefCounted
+ objects. So they should be marked '[SameObject]' in their IDL files.
+
+ * svg/SVGTests.idl:
+ * svg/SVGViewElement.idl:
+
2019-04-22 Commit Queue <commit-qu...@webkit.org>
Unreviewed, rolling out r244495.
Modified: trunk/Source/WebCore/svg/SVGTests.idl (244502 => 244503)
--- trunk/Source/WebCore/svg/SVGTests.idl 2019-04-22 18:03:47 UTC (rev 244502)
+++ trunk/Source/WebCore/svg/SVGTests.idl 2019-04-22 18:17:33 UTC (rev 244503)
@@ -28,9 +28,9 @@
NoInterfaceObject,
SuppressToJSObject,
] interface SVGTests {
- readonly attribute SVGStringList requiredFeatures;
- readonly attribute SVGStringList requiredExtensions;
- readonly attribute SVGStringList systemLanguage;
+ [SameObject] readonly attribute SVGStringList requiredFeatures;
+ [SameObject] readonly attribute SVGStringList requiredExtensions;
+ [SameObject] readonly attribute SVGStringList systemLanguage;
// FIXME: Using "undefined" as default parameter value is wrong.
boolean hasExtension(optional DOMString extension = "undefined");
Modified: trunk/Source/WebCore/svg/SVGViewElement.idl (244502 => 244503)
--- trunk/Source/WebCore/svg/SVGViewElement.idl 2019-04-22 18:03:47 UTC (rev 244502)
+++ trunk/Source/WebCore/svg/SVGViewElement.idl 2019-04-22 18:17:33 UTC (rev 244503)
@@ -24,7 +24,7 @@
*/
interface SVGViewElement : SVGElement {
- readonly attribute SVGStringList viewTarget;
+ [SameObject] readonly attribute SVGStringList viewTarget;
};
SVGViewElement implements SVGExternalResourcesRequired;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
