Title: [254625] trunk
Revision
254625
Author
jbed...@apple.com
Date
2020-01-15 11:33:52 -0800 (Wed, 15 Jan 2020)

Log Message

webkitpy: Remove self assignments
https://bugs.webkit.org/show_bug.cgi?id=206294

Reviewed by Aakash Jain.

Source/_javascript_Core:

* inspector/scripts/codegen/generator.py:
(Generator.js_name_for_parameter_type):

Tools:

* Scripts/webkitpy/common/webkit_finder.py:
(WebKitFinder.webkit_base):
* Scripts/webkitpy/port/factory.py:
(_builder_options):

Modified Paths

Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (254624 => 254625)


--- trunk/Source/_javascript_Core/ChangeLog	2020-01-15 19:16:47 UTC (rev 254624)
+++ trunk/Source/_javascript_Core/ChangeLog	2020-01-15 19:33:52 UTC (rev 254625)
@@ -1,3 +1,13 @@
+2020-01-15  Jonathan Bedard  <jbed...@apple.com>
+
+        webkitpy: Remove self assignments
+        https://bugs.webkit.org/show_bug.cgi?id=206294
+
+        Reviewed by Aakash Jain.
+
+        * inspector/scripts/codegen/generator.py:
+        (Generator.js_name_for_parameter_type):
+
 2020-01-14  Commit Queue  <commit-qu...@webkit.org>
 
         Unreviewed, rolling out r254480, r254496, and r254517.

Modified: trunk/Source/_javascript_Core/inspector/scripts/codegen/generator.py (254624 => 254625)


--- trunk/Source/_javascript_Core/inspector/scripts/codegen/generator.py	2020-01-15 19:16:47 UTC (rev 254624)
+++ trunk/Source/_javascript_Core/inspector/scripts/codegen/generator.py	2020-01-15 19:33:52 UTC (rev 254625)
@@ -295,7 +295,6 @@
 
     @staticmethod
     def js_name_for_parameter_type(_type):
-        _type = _type
         if isinstance(_type, AliasedType):
             _type = _type.aliased_type  # Fall through.
         if isinstance(_type, EnumType):

Modified: trunk/Tools/ChangeLog (254624 => 254625)


--- trunk/Tools/ChangeLog	2020-01-15 19:16:47 UTC (rev 254624)
+++ trunk/Tools/ChangeLog	2020-01-15 19:33:52 UTC (rev 254625)
@@ -1,3 +1,15 @@
+2020-01-15  Jonathan Bedard  <jbed...@apple.com>
+
+        webkitpy: Remove self assignments
+        https://bugs.webkit.org/show_bug.cgi?id=206294
+
+        Reviewed by Aakash Jain.
+
+        * Scripts/webkitpy/common/webkit_finder.py:
+        (WebKitFinder.webkit_base):
+        * Scripts/webkitpy/port/factory.py:
+        (_builder_options):
+
 2020-01-15  Alicia Boya GarcĂ­a  <ab...@igalia.com>
 
         [WTF] Remove MediaTime.cpp test warning in GCC

Modified: trunk/Tools/Scripts/webkitpy/common/webkit_finder.py (254624 => 254625)


--- trunk/Tools/Scripts/webkitpy/common/webkit_finder.py	2020-01-15 19:16:47 UTC (rev 254624)
+++ trunk/Tools/Scripts/webkitpy/common/webkit_finder.py	2020-01-15 19:33:52 UTC (rev 254625)
@@ -44,7 +44,6 @@
         # (the chromium test bots, for example), might only check out subdirectories like
         # Tools/Scripts. This code will also work if there is no SCM system at all.
         if not self._webkit_base:
-            self._webkit_base = self._webkit_base
             module_path = self._filesystem.path_to_module(self.__module__)
             tools_index = module_path.rfind('Tools')
             assert tools_index != -1, "could not find location of this checkout from %s" % module_path

Modified: trunk/Tools/Scripts/webkitpy/port/factory.py (254624 => 254625)


--- trunk/Tools/Scripts/webkitpy/port/factory.py	2020-01-15 19:16:47 UTC (rev 254624)
+++ trunk/Tools/Scripts/webkitpy/port/factory.py	2020-01-15 19:33:52 UTC (rev 254625)
@@ -91,7 +91,6 @@
 def _builder_options(builder_name):
     configuration = "Debug" if re.search(r"[d|D](ebu|b)g", builder_name) else "Release"
     is_webkit2 = builder_name.find("WK2") != -1
-    builder_name = builder_name
     return optparse.Values({'builder_name': builder_name, 'configuration': configuration, 'webkit_test_runner': is_webkit2})
 
 
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to