Title: [256696] branches/safari-609-branch/Source/WebCore
- Revision
- 256696
- Author
- repst...@apple.com
- Date
- 2020-02-14 19:02:55 -0800 (Fri, 14 Feb 2020)
Log Message
Cherry-pick r256636. rdar://problem/59478734
[Web Animations] Missing call to DocumentTimeline::resumeAnimations() in Frame::resumeActiveDOMObjectsAndAnimations()
https://bugs.webkit.org/show_bug.cgi?id=207784
<rdar://problem/59251858>
Patch by Antoine Quint <grao...@webkit.org> on 2020-02-14
Reviewed by Dean Jackson.
After auditing the code, there was one call to CSSAnimationController::resumeAnimationsForDocument() that missed a matching DocumentTimeline::resumeAnimations()
call should the Web Animations flag be on.
* page/Frame.cpp:
(WebCore::Frame::resumeActiveDOMObjectsAndAnimations):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256636 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
Diff
Modified: branches/safari-609-branch/Source/WebCore/ChangeLog (256695 => 256696)
--- branches/safari-609-branch/Source/WebCore/ChangeLog 2020-02-15 03:02:52 UTC (rev 256695)
+++ branches/safari-609-branch/Source/WebCore/ChangeLog 2020-02-15 03:02:55 UTC (rev 256696)
@@ -1,5 +1,38 @@
2020-02-14 Russell Epstein <repst...@apple.com>
+ Cherry-pick r256636. rdar://problem/59478734
+
+ [Web Animations] Missing call to DocumentTimeline::resumeAnimations() in Frame::resumeActiveDOMObjectsAndAnimations()
+ https://bugs.webkit.org/show_bug.cgi?id=207784
+ <rdar://problem/59251858>
+
+ Patch by Antoine Quint <grao...@webkit.org> on 2020-02-14
+ Reviewed by Dean Jackson.
+
+ After auditing the code, there was one call to CSSAnimationController::resumeAnimationsForDocument() that missed a matching DocumentTimeline::resumeAnimations()
+ call should the Web Animations flag be on.
+
+ * page/Frame.cpp:
+ (WebCore::Frame::resumeActiveDOMObjectsAndAnimations):
+
+ git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256636 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+ 2020-02-14 Antoine Quint <grao...@webkit.org>
+
+ [Web Animations] Missing call to DocumentTimeline::resumeAnimations() in Frame::resumeActiveDOMObjectsAndAnimations()
+ https://bugs.webkit.org/show_bug.cgi?id=207784
+ <rdar://problem/59251858>
+
+ Reviewed by Dean Jackson.
+
+ After auditing the code, there was one call to CSSAnimationController::resumeAnimationsForDocument() that missed a matching DocumentTimeline::resumeAnimations()
+ call should the Web Animations flag be on.
+
+ * page/Frame.cpp:
+ (WebCore::Frame::resumeActiveDOMObjectsAndAnimations):
+
+2020-02-14 Russell Epstein <repst...@apple.com>
+
Cherry-pick r256623. rdar://problem/59478938
Ensure animations that lose their effect don't schedule an animation update
Modified: branches/safari-609-branch/Source/WebCore/page/Frame.cpp (256695 => 256696)
--- branches/safari-609-branch/Source/WebCore/page/Frame.cpp 2020-02-15 03:02:52 UTC (rev 256695)
+++ branches/safari-609-branch/Source/WebCore/page/Frame.cpp 2020-02-15 03:02:55 UTC (rev 256696)
@@ -962,7 +962,12 @@
m_doc->resumeScheduledTasks(ReasonForSuspension::PageWillBeSuspended);
// Frame::clearTimers() suspended animations and pending relayouts.
- animation().resumeAnimationsForDocument(m_doc.get());
+
+ if (RuntimeEnabledFeatures::sharedFeatures().webAnimationsCSSIntegrationEnabled()) {
+ if (auto* timeline = m_doc->existingTimeline())
+ timeline->resumeAnimations();
+ } else
+ animation().resumeAnimationsForDocument(m_doc.get());
if (m_view)
m_view->layoutContext().scheduleLayout();
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
