Title: [259019] trunk/Tools
- Revision
- 259019
- Author
- zhifei_f...@apple.com
- Date
- 2020-03-25 16:19:32 -0700 (Wed, 25 Mar 2020)
Log Message
[Timeline] A better default get label function, which fit the assumpation the label is always a string
https://bugs.webkit.org/show_bug.cgi?id=209567
Reviewed by Jonathan Bedard.
* resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (259018 => 259019)
--- trunk/Tools/ChangeLog 2020-03-25 23:19:01 UTC (rev 259018)
+++ trunk/Tools/ChangeLog 2020-03-25 23:19:32 UTC (rev 259019)
@@ -1,5 +1,14 @@
2020-03-25 Zhifei Fang <zhifei_f...@apple.com>
+ [Timeline] A better default get label function, which fit the assumpation the label is always a string
+ https://bugs.webkit.org/show_bug.cgi?id=209567
+
+ Reviewed by Jonathan Bedard.
+
+ * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
+
+2020-03-25 Zhifei Fang <zhifei_f...@apple.com>
+
[Timeline] Fix the out of bound dot index
https://bugs.webkit.org/show_bug.cgi?id=209492
Modified: trunk/Tools/resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js (259018 => 259019)
--- trunk/Tools/resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js 2020-03-25 23:19:01 UTC (rev 259018)
+++ trunk/Tools/resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js 2020-03-25 23:19:32 UTC (rev 259019)
@@ -609,7 +609,7 @@
const _onScaleEnter_ = typeof option._onScaleEnter_ === "function" ? option.onScaleEnter : null;
const _onScaleLeave_ = typeof option._onScaleLeave_ === "function" ? option.onScaleLeave : null;
const sortData = option.sortData === true ? option.sortData : false;
- const getLabel = typeof option.getLabelFunc === "function" ? option.getLabelFunc : (a) => a;
+ const getLabel = typeof option.getLabelFunc === "function" ? option.getLabelFunc : (a) => `${a}`;
const isTop = typeof option.isTop === "boolean" ? option.isTop : false;
// Get the css value, this component assume to use with webkit.css
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
