[webkit-dev] Regression fallout from change to make Frames start with an empty document

2007-05-12 Thread Maciej Stachowiak
My change to make Frames start with an empty document instead of creating one on demand caused some regressions (mostly in areas of the code that are not under automated test). I still think it is a fundamentally sound change and I'll try to fix the open regressions ASAP (hopefully I can

[webkit-dev] Fix for Qt build

2007-05-12 Thread Maciej Stachowiak
I can't check this in right now because the SVN server is temporarily out of disk, but this appears to mostly fix the Qt build, at least in QtLauncher. Rob Buis helped me test and is running layout tests now. Index: WebKitQt/ChangeLog

Re: [webkit-dev] Fix for Qt build

2007-05-12 Thread Holger Freyther
Am 12.05.2007 um 12:32 schrieb Maciej Stachowiak: I can't check this in right now because the SVN server is temporarily out of disk, but this appears to mostly fix the Qt build, at least in QtLauncher. Rob Buis helped me test and is running layout tests now. Hey, so the Gdk port

Re: [webkit-dev] Fix for Qt build

2007-05-12 Thread Holger Freyther
Am 12.05.2007 um 13:28 schrieb Holger Freyther: Am 12.05.2007 um 12:32 schrieb Maciej Stachowiak: I can't check this in right now because the SVN server is temporarily out of disk, but this appears to mostly fix the Qt build, at least in QtLauncher. Rob Buis helped me test and is

Re: [webkit-dev] Regression fallout from change to make Frames start with an empty document

2007-05-12 Thread Geoffrey Garen
I believe we should add this one to the list: rdar://problem/ 5198885 Crash or ASSERT below FrameLoader::commitProvisionalLoad when navigating away from bookmarks view Geoff On May 12, 2007, at 1:14 AM, Maciej Stachowiak wrote: My change to make Frames start with an empty document instead

Re: [webkit-dev] Fix for Qt build

2007-05-12 Thread Maciej Stachowiak
On May 12, 2007, at 7:59 AM, Holger Freyther wrote: Am 12.05.2007 um 13:28 schrieb Holger Freyther: Am 12.05.2007 um 12:32 schrieb Maciej Stachowiak: I can't check this in right now because the SVN server is temporarily out of disk, but this appears to mostly fix the Qt build, at

[webkit-dev] Patch for notImplemented() macros

2007-05-12 Thread Kevin Ollivier
Hi Darin and all, On Apr 9, 2007, at 3:12 PM, Darin Adler wrote: On Apr 8, 2007, at 3:38 PM, Kevin Ollivier wrote: One other issue I wanted to bring up that I've run into is an issue with needing the notImplementedGdk() macro to be defined even though we're not using the GDK port, as we