Re: [webkit-dev] some WebCore::String plans

2007-12-18 Thread Darin Adler
On Dec 18, 2007, at 10:56 AM, Geoffrey Garen wrote: Would you suggest the same kinds of changes to KJS::UString? Probably not. I think the issues with KJS::UString are different. Long term it would be nice to consider exactly what the differences are between two classes and how to

[webkit-dev] Re: webkit accessibility

2007-12-18 Thread David Harrison
Alexander, I misunderstood your question. VoiceOver is a client that uses them. I don't know whether there are other clients. There is currently no proposal. Largely, the accessibility interface in WebKit on the Mac reflects our work together with the VoiceOver team, as they have

Re: [webkit-dev] some WebCore::String plans

2007-12-18 Thread Maciej Stachowiak
Mostly sounds good. On Dec 18, 2007, at 10:51 AM, Darin Adler wrote: The WebCore::String class needs some work. I have some plans to improve it. Here's an outline of what I have in mind. immutability - eliminate all non-const functions from StringImpl; fixes tricky sharing semantics -

Re: [webkit-dev] some WebCore::String plans

2007-12-18 Thread Darin Adler
On Dec 18, 2007, at 6:19 PM, Maciej Stachowiak wrote: clarity - eliminate functions that return a StringImpl* from StringImpl, because it's to easy to misunderstand and think these modify the string in place - eliminate functions that return a String from String -- also easy to use wrong

Re: [webkit-dev] Webkit - Building Error

2007-12-18 Thread Darren VanBuren
Could you provide us with the log? I didn't see it attached. From what you've sent, it looks like ../../bin/QTLauncher doesn't exist on your system. It could be attempting to build for QT, which you might not have. The log would really help with finding the problem.