[webkit-dev] The tree is on fire

2010-01-22 Thread Maciej Stachowiak
Ever since this change: http://trac.webkit.org/changeset/53722 The Leopard and SnowLeopard tests have been failing fast/dom/Window/window-property-descriptors.html. Ironically, it looks like that patch landed new results in an attempt to fix that test, but it looks to me like the new results

Re: [webkit-dev] webkit team wiki page

2010-01-24 Thread Maciej Stachowiak
On Jan 24, 2010, at 2:02 PM, Adam Barth wrote: I changed it for two reasons: 1) The old format wasn't scaling to the current team size. The page as become an unwieldy wall of text. 2) The old format emphasized the industrial affiliation of the team members, which seemed counter to a

Re: [webkit-dev] webkit team wiki page

2010-01-24 Thread Maciej Stachowiak
On Jan 24, 2010, at 7:42 PM, David Kilzer wrote: On Sun, January 24, 2010 at 7:09:26 PM, Maciej Stachowiak wrote: I think deleting the areas of knowledge is a regrettable loss of information. I think it's helpful to give people at least a few starting points for their questions

Re: [webkit-dev] Showing Baseline and Container Box

2010-01-25 Thread Maciej Stachowiak
On Jan 25, 2010, at 10:01 AM, Alex Milowski wrote: For all of my MathML rendering objects I've optionally compiled in a simple override to the paint() method to provide a visual representation of the containing box's boundary and the baseline position. I've been using this to debug the

Re: [webkit-dev] changelogs: a reprise

2010-01-25 Thread Maciej Stachowiak
On Jan 25, 2010, at 10:39 PM, Eric Seidel wrote: On Mon, Jan 25, 2010 at 10:38 PM, Eric Seidel esei...@google.com wrote: Re: #1 I strongly support a wrapper around commit. That's what webkit-patch land is supposed to be. It allows us to do all sorts of pre-commit checks! The check could

Re: [webkit-dev] licensing question

2010-02-04 Thread Maciej Stachowiak
On Feb 3, 2010, at 8:25 PM, Chris Jerdonek wrote: Quick question: if we would like to check in third-party code and it is not obviously BSD-style (at least to me), what is the process for checking whether the license is okay and clearing the license? The WebKit Committer Guidelines say,

Re: [webkit-dev] Buildbot Emails

2010-02-08 Thread Maciej Stachowiak
On Feb 8, 2010, at 4:45 PM, Eric Seidel wrote: Historically build.webkit.org would email people when their changes broke the tree. This was disabled some time ago. I would very much like to see it re-enabled. Could someone point me as to how that would happen (I'm happy to code up a

Re: [webkit-dev] Buildbot Emails

2010-02-08 Thread Maciej Stachowiak
technology-based approaches before process-based approaches. Right now broken trees linger because you have to go out of your way to notice, meaning the information diffuses slowly. Regards, Maciej :DG On Mon, Feb 8, 2010 at 5:29 PM, Maciej Stachowiak m...@apple.com wrote: On Feb 8, 2010, at 4

Re: [webkit-dev] beforeinput and input events for contenteditable/designMode

2010-02-10 Thread Maciej Stachowiak
Hi Ojan, Thanks for posting about this. On Feb 10, 2010, at 4:56 PM, Ojan Vafai wrote: We'd like to implement this event and want to make sure there's no opposition before moving forward. I don't expect this to require huge rewrites to current webkit code, but it will definitely require

Re: [webkit-dev] WebKit API native coding style?

2010-02-19 Thread Maciej Stachowiak
On Feb 19, 2010, at 6:30 AM, Stephan Assmus wrote: Hi, I would like to know whether it's ok to adopt the respective platform's coding style in the WebKit API that a port exposes. I am working on the Haiku port and saw that other ports do this, but I thought I'd better ask before I

Re: [webkit-dev] run-chromium-webkit-tests

2010-02-19 Thread Maciej Stachowiak
On Feb 19, 2010, at 3:12 PM, Eric Seidel wrote: Chromium's faster, multi-threaded, python-based testing harness landed in svn.webkit.org about a week ago. On my 4 core work machine it runs all the tests in 5 minutes vs. 8 minutes with run-webkit-tests. On Dirk's 16 core machine it runs all

Re: [webkit-dev] parallel rendering in WebKit

2010-02-19 Thread Maciej Stachowiak
On Feb 19, 2010, at 7:20 PM, Leo Meyerovich wrote: We've been experimenting in our model with various modes of parallel 2D rendering (basic theme: GPU/SMP support rocks) but have a more wide open design space than WebKit's. For a not-too-painful approach, looks like Firefox is doing well,

Re: [webkit-dev] are there any known or suspected memory issues with webkit?

2010-02-21 Thread Maciej Stachowiak
On Feb 21, 2010, at 4:14 AM, Mike Marchywka wrote: The reason I ask is because I thought there were some concerns about leaks ( probably just stuff I saw skimming various google hits ) and I have seen firefox and iceweasel light up my disk on very simple things ( like typing stuff into

Re: [webkit-dev] Increasing the number of cross-platform/port expected results

2010-02-23 Thread Maciej Stachowiak
On Feb 23, 2010, at 8:14 AM, Darin Adler wrote: On Feb 23, 2010, at 8:08 AM, Ariya Hidayat wrote: When the test is run, the browser loads both files, takes snapshots, and does a pixel comparison. Thus font differences between platforms become less of an issue. Isn't it our existing

Re: [webkit-dev] Crashes during testing

2010-02-25 Thread Maciej Stachowiak
On Feb 25, 2010, at 2:46 PM, Kenneth Russell wrote: A change committed some time since yesterday evening has introduced many crashes in JSC's GC during testing. A representative stack trace is attached. If you have made changes in this area recently, can you please look into this? Thanks,

Re: [webkit-dev] The tree is on fire: a tragedy of the commons

2010-02-26 Thread Maciej Stachowiak
On Feb 26, 2010, at 9:17 AM, Dimitri Glazkov wrote: To summarize the thread: 1) We're adopting when in doubt, roll it out approach to patches that turn tree red. I think it's polite, though not mandatory, to make a reasonable effort to find the person responsible for the breakage and give

Re: [webkit-dev] The tree is on fire: a tragedy of the commons

2010-02-26 Thread Maciej Stachowiak
On Feb 26, 2010, at 1:36 AM, Adam Barth wrote: Not to point fingers, but we've been having trouble keeping build.webkit.org green these past few weeks. As I write this message, every platform is broken, again. As the project scales, polluting the build with brokenness impacts more developers

Re: [webkit-dev] The tree is on fire: a tragedy of the commons

2010-02-26 Thread Maciej Stachowiak
On Feb 26, 2010, at 9:58 AM, Alexey Proskuryakov wrote: On 26.02.2010, at 9:50, Jeremy Orlow wrote: I would re-write rule one as something like this: 1. Comment in the bugzilla bug when the build breaks. If there is no bugzilla bug, comment in #webkit. 2. 15 minutes after the

Re: [webkit-dev] The tree is on fire: a tragedy of the commons

2010-02-26 Thread Maciej Stachowiak
On Feb 26, 2010, at 9:56 AM, Alexey Proskuryakov wrote: On 26.02.2010, at 9:29, Maciej Stachowiak wrote: I'd like it if we had an IRC bot that announced build breakage on #webkit. Perhaps better yet, on #webkit-build, as buildbot used to do. In the past, no one ever joined #webkit

Re: [webkit-dev] The tree is on fire: a tragedy of the commons

2010-02-26 Thread Maciej Stachowiak
On Feb 26, 2010, at 11:08 AM, Alexey Proskuryakov wrote: On 26.02.2010, at 10:15, Jeremy Orlow wrote: I didn't even know it existed until now. Was there ever an email sent out on this? If so, I missed it. Buildbot used to announce results there, but it was a few years ago. My

Re: [webkit-dev] The tree is on fire: a tragedy of the commons

2010-02-26 Thread Maciej Stachowiak
On Feb 26, 2010, at 11:34 AM, Geoffrey Garen wrote: There is a non-trivial cost of this workflow on the rest of the team. -keeps the commit-queue from running -often results in new test failures going unnoticed because the tree is already red -we can't generally trust that all the tests

Re: [webkit-dev] The tree is on fire: a tragedy of the commons

2010-02-26 Thread Maciej Stachowiak
On Feb 26, 2010, at 11:43 AM, Simon Fraser wrote: Mozilla has (or at least had when I worked there) two additional tree rules that helped keep the tree green: 1. A sheriff was appointed at all times, and had the authority to close the tree if there was significant build or test

Re: [webkit-dev] The tree is on fire: a tragedy of the commons

2010-02-26 Thread Maciej Stachowiak
On Feb 26, 2010, at 12:11 PM, William Siegrist wrote: On Feb 26, 2010, at 9:29 AM, Maciej Stachowiak wrote: On Feb 26, 2010, at 9:17 AM, Dimitri Glazkov wrote: To summarize the thread: 1) We're adopting when in doubt, roll it out approach to patches that turn tree red. I think it's

Re: [webkit-dev] Increasing the number of cross-platform/port expected results

2010-03-01 Thread Maciej Stachowiak
On Mar 1, 2010, at 5:49 PM, Ojan Vafai wrote: On Tue, Feb 23, 2010 at 3:26 PM, Eric Seidel e...@webkit.org wrote: On Tue, Feb 23, 2010 at 2:19 PM, Darin Adler da...@apple.com wrote: But in practice pixel results are often ignored entirely. I think that reftest-style tests if done right

Re: [webkit-dev] simple layout engine

2010-03-04 Thread Maciej Stachowiak
These questions might be more appropriate to webkit-help. I'll answer the one related to WebKit development here. On Mar 4, 2010, at 5:15 AM, Patrick wrote: Hi Everyone. I am afraid I don't have the skills to contribute anything to webkit but if someone could point me in the right

Re: [webkit-dev] minimum python version to support

2010-03-04 Thread Maciej Stachowiak
On Mar 4, 2010, at 12:17 PM, Eric Seidel wrote: I think we should ignore Tiger for the purposes of this discussion. We (Apple) still need to do development on Tiger. We would strongly prefer that WebKit's tools work on Tiger. Regards, Maciej

Re: [webkit-dev] minimum python version to support

2010-03-04 Thread Maciej Stachowiak
On Mar 4, 2010, at 12:50 PM, Eric Seidel wrote: On Thu, Mar 4, 2010 at 12:39 PM, Maciej Stachowiak m...@apple.com wrote: On Mar 4, 2010, at 12:17 PM, Eric Seidel wrote: I think we should ignore Tiger for the purposes of this discussion. We (Apple) still need to do development on Tiger

Re: [webkit-dev] minimum python version to support

2010-03-07 Thread Maciej Stachowiak
On Mar 7, 2010, at 3:18 PM, Chris Jerdonek wrote: On Fri, Mar 5, 2010 at 6:43 PM, David Kilzer ddkil...@webkit.org wrote: On Thu, March 4, 2010 at 5:35:08 PM, William Siegrist wrote: Since I have a Tiger machine handy, I tested this and was able to build python 2.5.5 from MacPorts on a

Re: [webkit-dev] what is sentencegranularity?

2010-03-10 Thread Maciej Stachowiak
On Mar 10, 2010, at 1:05 PM, Ojan Vafai wrote: The topic of sentencegranularity selections came up in https://bugs.webkit.org/show_bug.cgi?id=33413 . I'm trying to understand, moving forward, how to test the correct behavior for sentencegranularity. As best I can tell, it's not a Mac

Re: [webkit-dev] WebGL test breakage on build bots

2010-03-16 Thread Maciej Stachowiak
On Mar 16, 2010, at 1:45 PM, Kenneth Russell wrote: Earlier today I landed https://bugs.webkit.org/show_bug.cgi?id=33416 by hand (because the commit queue was blocked), and unfortunately this broke some of the WebGL layout tests on the bots. These tests are passing locally, so the best guess

Re: [webkit-dev] WebGL test breakage on build bots

2010-03-16 Thread Maciej Stachowiak
On Mar 16, 2010, at 4:42 PM, Kenneth Russell wrote: We're working on the real fix (actually heuristics to detect and work around broken graphics drivers) under https://bugs.webkit.org/show_bug.cgi?id=36194 , but in the meantime to unblock the commit queue I've temporarily disabled these tests

Re: [webkit-dev] Yet another email about a broken tree

2010-03-17 Thread Maciej Stachowiak
On Mar 17, 2010, at 12:02 AM, Adam Barth wrote: Manual investigation seems to implicate http://trac.webkit.org/changeset/56074 for at least some of the brokenness in SnowLeopard Intel Release (Tests). There's a patch in https://bugs.webkit.org/show_bug.cgi?id=36194 that claims to fix things,

Re: [webkit-dev] Yet another email about a broken tree

2010-03-17 Thread Maciej Stachowiak
On Mar 17, 2010, at 1:49 AM, Kenneth Russell wrote: On Wed, Mar 17, 2010 at 12:44 AM, Maciej Stachowiak m...@apple.com wrote: On Mar 17, 2010, at 12:02 AM, Adam Barth wrote: Manual investigation seems to implicate http://trac.webkit.org/changeset/56074 for at least some of the brokenness

Re: [webkit-dev] ie test center

2010-03-17 Thread Maciej Stachowiak
On Mar 17, 2010, at 1:55 AM, Dirk Schulze wrote: Hi, Microsoft announced a new test suite, the Internet Explorer testing center together with the first preview of the upcoming ie9. http://samples.msdn.microsoft.com/ietestcenter/ In one table the current releases of the major browsers are

Re: [webkit-dev] Yet another email about a broken tree

2010-03-17 Thread Maciej Stachowiak
On Mar 17, 2010, at 2:31 AM, Kenneth Russell wrote: Our best current plan is more widespread testing. We will file a Radar bug as soon as we have more information about the nature of the failure -- by virtue of working around the bugs. If we knew the precise hardware configuration of the

Re: [webkit-dev] A mechanism for detecting red bots (was Re: Yet another email about a broken tree)

2010-03-17 Thread Maciej Stachowiak
On Mar 17, 2010, at 9:10 AM, Adam Barth wrote: On Wed, Mar 17, 2010 at 2:16 AM, Maciej Stachowiak m...@apple.com wrote: That being said, the mechanism I'd really like to see first is better notification of when the bot goes red (I suspect a number of people involved in today's redness

Re: [webkit-dev] Yet another email about a broken tree

2010-03-17 Thread Maciej Stachowiak
On Mar 17, 2010, at 12:14 PM, Kenneth Russell wrote: I think what should be done is to get the tree green by skipping these flaky tests; file high-priority bugs against the test authors to fix the flakiness; and then figure out a way the commit queue can be used for the vast majority of

Re: [webkit-dev] Web developer documentation - working with Mozilla

2010-03-17 Thread Maciej Stachowiak
On Mar 17, 2010, at 8:55 AM, henry.haveri...@nokia.com wrote: Hi everyone, I'm working for the Qt port of WebKit, and we're currently considering different ways of creating web developer documentation for our users. We don't currently have any documentation for web developers We'd like

Re: [webkit-dev] Web developer documentation - working with Mozilla

2010-03-18 Thread Maciej Stachowiak
On Mar 18, 2010, at 9:03 AM, henry.haveri...@nokia.com wrote: On Mar 17, 2010, at 10:06 PM, ext Peter Kasting wrote: On Wed, Mar 17, 2010 at 8:55 AM, henry.haveri...@nokia.com wrote: We don't currently have any documentation for web developers We'd like to start with best practice

Re: [webkit-dev] Web developer documentation - working with Mozilla

2010-03-18 Thread Maciej Stachowiak
On Mar 18, 2010, at 11:07 AM, Peter Kasting wrote: On Thu, Mar 18, 2010 at 10:38 AM, Maciej Stachowiak m...@apple.com wrote: The documentation on Google doctype has quite a few errors and doesn't seem to have been updated for a while. For example, this test claims that Safari 3 does

Re: [webkit-dev] Chromium layout test expectations coming today

2010-03-19 Thread Maciej Stachowiak
On Mar 19, 2010, at 10:35 AM, Dimitri Glazkov wrote: I agree that the idea of only pulling down expectations that you would actually need sounds great -- in fact we did try to think of ways of how this could be accomplished. So far, no great proposal materialized, but it doesn't mean the door

Re: [webkit-dev] Chromium layout test expectations coming today

2010-03-19 Thread Maciej Stachowiak
On Mar 19, 2010, at 5:30 PM, Ojan Vafai wrote: Currently we do BUG12345 for Chromium bugs. There are no WebKit bugs listed. How about we instead use CR12345 for Chromium bugs and WK12345 for WebKit bugs? Another possibility would be to use bug URLs. WebKit bugs can be referenced as

Re: [webkit-dev] file names with spaces

2010-03-22 Thread Maciej Stachowiak
On Mar 22, 2010, at 10:29 PM, Adele Peterson wrote: On Mar 22, 2010, at 10:24 PM, Chris Jerdonek wrote: I was wondering if there are any reasons we would ever need files in our repository whose file names contain spaces. The reason is that it makes shell commands slightly trickier to

Re: [webkit-dev] file names with spaces

2010-03-22 Thread Maciej Stachowiak
On Mar 22, 2010, at 10:42 PM, Chris Jerdonek wrote: Yes. I think it's to be expected that rules will occasionally need to be violated -- especially for testing purposes (e.g. tabs and trailing spaces in test files). Another possibility is landing third-party code as-is. I guess I'm asking

Re: [webkit-dev] file names with spaces

2010-03-23 Thread Maciej Stachowiak
On Mar 22, 2010, at 11:01 PM, Chris Jerdonek wrote: On Mon, Mar 22, 2010 at 10:46 PM, Maciej Stachowiak m...@apple.com wrote: The most unavoidable exceptions seem to be for test cases that are specifically testing what happens when you have a space in the filename, not for third-party

Re: [webkit-dev] Leading new-line in dataTransfer.setData

2010-03-23 Thread Maciej Stachowiak
On Mar 23, 2010, at 1:01 AM, Roland Steiner wrote: Hi all, On the topic of dataTransfer.setData, there seems to be a small inconsistency between browsers when it comes to leading new-lines. e.g., dataTransfer.setData(text/uri-list, \nhttp://foo;) followed by dataTransfer.getData(URL).

Re: [webkit-dev] Leading new-line in dataTransfer.setData

2010-03-23 Thread Maciej Stachowiak
like it. Cheers, - Roland On Tue, Mar 23, 2010 at 5:37 PM, Maciej Stachowiak m...@apple.com wrote: On Mar 23, 2010, at 1:01 AM, Roland Steiner wrote: Hi all, On the topic of dataTransfer.setData, there seems to be a small inconsistency between browsers when it comes to leading new

Re: [webkit-dev] WebKit Icon license?

2010-03-23 Thread Maciej Stachowiak
On Mar 23, 2010, at 3:25 AM, Jeremy Orlow wrote: It seems as though we should at very least change the main icon on webkit.org to match what is apparently the official webkit logo. The icons for the Mac and Windows nightlies probably needn't change since they're run within Safari anyway,

Re: [webkit-dev] Question regarding build flags for the features

2010-03-23 Thread Maciej Stachowiak
On Mar 23, 2010, at 1:22 PM, Dmitry Titov wrote: If we had a single flag for all those (ENABLE_FILE_API ?) then a port would have to implement all features at once to be able to enable it. It might be inconvenient. If the code is not shared and those flags can be enabled in any

Re: [webkit-dev] WebKit Icon license?

2010-03-23 Thread Maciej Stachowiak
On Mar 23, 2010, at 9:00 PM, Shinichiro Hamaji wrote: A related P1 issue :) http://webkit.org/b/19371 Want. Where can I obtain that shirt? - Maciej On Wed, Mar 24, 2010 at 9:28 AM, Maciej Stachowiak m...@apple.com wrote: On Mar 23, 2010, at 3:25 AM, Jeremy Orlow wrote: It seems

Re: [webkit-dev] Audio directory layout

2010-03-30 Thread Maciej Stachowiak
On Mar 30, 2010, at 7:20 PM, Chris Rogers wrote: Maciej proposed that I work in my own special branch of WebKit. Maybe it makes sense for me to check all my code (unreviewed) into my special WebKit branch using a provisional directory layout. Then people can see how all the code works

Re: [webkit-dev] The green tree era

2010-04-04 Thread Maciej Stachowiak
On Apr 4, 2010, at 8:12 AM, Adam Barth wrote: On Sat, Apr 3, 2010 at 11:30 PM, Darin Adler da...@apple.com wrote: On Apr 3, 2010, at 10:36 AM, Adam Barth wrote: Keeping the tree green will require a cultural shift in the project, but I think the near term costs of changing the culture are

Re: [webkit-dev] To start meter element implementation

2010-04-04 Thread Maciej Stachowiak
On Apr 4, 2010, at 7:23 PM, Hajime Morita wrote: Hi folks, I'm planning to work on HTML5 meter element, which is filed on https://bugs.webkit.org/show_bug.cgi?id=37074 . Although there seems no effort for that element at this time, The progress element looks similar to meter. So I'll try to

Re: [webkit-dev] Rich Text Editing Questions, Refactoring of Position Classes

2010-04-05 Thread Maciej Stachowiak
On Apr 5, 2010, at 10:30 PM, Roland Steiner wrote: One additional question on position classes: The current implementation allows for (and operates on) positions such as [img, 0] - [img, 1] or [br,0] - [br, 1]. Is there a fundamental reason to keep such positions within the internal

Re: [webkit-dev] Rich Text Editing Questions, Refactoring of Position Classes

2010-04-05 Thread Maciej Stachowiak
On Apr 1, 2010, at 10:43 PM, Roland Steiner wrote: Hi all, As I am working on WebKit rich text editing these days, there are 2 issues that I would like to address. From a brief internal discussion both seem feasible and worthwhile, but since they involve changes to current code and

Re: [webkit-dev] A post-mordem of today's tree redness

2010-04-06 Thread Maciej Stachowiak
On Apr 6, 2010, at 10:35 AM, Alexey Proskuryakov wrote: On 06.04.2010, at 10:06, Adam Barth wrote: I don't read webkit-changes, so I might not fully appreciate this use case, but the way I know when things are rolled out is because we reopen the bug and comment that patch was rolled out in

Re: [webkit-dev] A post-mordem of today's tree redness

2010-04-06 Thread Maciej Stachowiak
On Apr 6, 2010, at 11:57 AM, Adam Barth wrote: On Tue, Apr 6, 2010 at 11:43 AM, Maciej Stachowiak m...@apple.com wrote: On Apr 6, 2010, at 10:35 AM, Alexey Proskuryakov wrote: On 06.04.2010, at 10:06, Adam Barth wrote: I don't read webkit-changes, so I might not fully appreciate this use

Re: [webkit-dev] Rich Text Editing Questions, Refactoring of Position Classes

2010-04-07 Thread Maciej Stachowiak
On Apr 7, 2010, at 12:11 AM, Roland Steiner wrote: Hard to comment on this idea from such a high level view. I don't understand how EditingPosition is meant to be different from VisiblePosition. Is EditingPosition just a VisiblePosition that's also a place where you can edit? I don't

Re: [webkit-dev] Rich Text Editing Questions, Refactoring of Position Classes

2010-04-07 Thread Maciej Stachowiak
On Apr 7, 2010, at 1:59 AM, Roland Steiner wrote: On Wed, Apr 7, 2010 at 4:36 PM, Maciej Stachowiak m...@apple.com wrote: It's not clear to me how PositionIterator is the same concept as EditingPosition. The latter implies that it would only ever represent a position where you can edit

Re: [webkit-dev] [webkit-changes] [57262] trunk/JavaScriptCore

2010-04-08 Thread Maciej Stachowiak
On Apr 8, 2010, at 11:18 AM, Alexey Proskuryakov wrote: On 08.04.2010, at 10:21, Jeremy Orlow wrote: I wasn't even aware that Xcode did recognize it or that we used that convention because it does. We should probably document this somewhere. I don't know if that's the original or only

Re: [webkit-dev] Announcing WebKit2

2010-04-08 Thread Maciej Stachowiak
On Apr 8, 2010, at 5:47 PM, Xan Lopez wrote: I suppose I could wait until you land the patches and see by myself, but: - In the wiki you mention that one goal of the new framework is to provide a stable C-based API. Is this meant as a public API for WebKit, the same in all platforms (like

Re: [webkit-dev] Announcing WebKit2

2010-04-08 Thread Maciej Stachowiak
On Apr 8, 2010, at 6:19 PM, Chris Fleizach wrote: If its in a separate process, does Accessibility still work as expected? It does not yet work in this rough initial version, but it's certainly our intent to make it work. Cheers, Maciej On Apr 8, 2010, at 4:01 PM, Anders Carlsson

Re: [webkit-dev] New Qt buildbots

2010-04-09 Thread Maciej Stachowiak
On Apr 9, 2010, at 1:02 AM, Eric Seidel wrote: I'm strongly in favor of more builders. However, it would be nice if the builders on build.webkit.org's front-page were all builders we were actually supposed to keep green. Right now Windows, Qt and Gtk builders at build.webkit.org are red and

Re: [webkit-dev] Announcing WebKit2

2010-04-09 Thread Maciej Stachowiak
On Apr 9, 2010, at 3:36 AM, Jeremy Orlow wrote: I hope this post clarifies why the Chromium WebKit port is not really a viable solution for our needs as it stands today. It was _very_ helpful. Thanks for taking the time to explain it so well. (It might be worth moving some of that

Re: [webkit-dev] Announcing WebKit2

2010-04-09 Thread Maciej Stachowiak
On Apr 9, 2010, at 3:40 AM, Maciej Stachowiak wrote: On Apr 9, 2010, at 3:36 AM, Jeremy Orlow wrote: I hope this post clarifies why the Chromium WebKit port is not really a viable solution for our needs as it stands today. It was _very_ helpful. Thanks for taking the time to explain

Re: [webkit-dev] Announcing WebKit2

2010-04-09 Thread Maciej Stachowiak
On Apr 9, 2010, at 7:14 AM, Adam Treat wrote: On Friday 09 April 2010 06:24:51 am Maciej Stachowiak wrote: Given what proportion of overall maintenance work on WebKit I done by Apple, I don't think anyone is entitled to veto us adding a new API Whaa? Who is talking about veto of Apple's

Re: [webkit-dev] Announcing WebKit2

2010-04-09 Thread Maciej Stachowiak
On Apr 9, 2010, at 2:03 PM, Adam Barth wrote: On Fri, Apr 9, 2010 at 1:53 PM, Cameron Zwarich cwzwar...@webkit.org wrote: We seem to welcome pretty much any port that has an active maintainer. IMHO, that's a good thing. I wonder if we should archive ports that don't have an active

Re: [webkit-dev] Announcing WebKit2

2010-04-09 Thread Maciej Stachowiak
On Apr 9, 2010, at 2:13 PM, Adam Treat wrote: On Friday 09 April 2010 02:11:33 pm Maciej Stachowiak wrote: the new piece of tech really is just a new API layer for the Mac and Win ports. We are interested in other people being able to reuse this technology, but fundamentally

Re: [webkit-dev] Coming Soon: new-run-webkit-tests

2010-04-10 Thread Maciej Stachowiak
The reason for sampling timeouts is so that you can diagnose what happened more easily when you get an unexpected timeout. Same reason we save backtraces from crashes. Having some expected timeouts does not remove the need to diagnose regressions that manifest as a timeout. On Apr 10,

Re: [webkit-dev] Git meeting notes

2010-04-12 Thread Maciej Stachowiak
On Apr 12, 2010, at 8:15 PM, Timothy Hatcher wrote: Only the first 5-7 characters are needed to identify a single commit (enough of the hash prefix to be unique). So REGRESSION(96c3b0) vs REGRESSION(r12345). How long will 7 characters last before you hit the birthday paradox? Regards,

[webkit-dev] Recent SVG clipping change caused lots of leaks on the bot

2010-04-13 Thread Maciej Stachowiak
https://bugs.webkit.org/show_bug.cgi?id=37527 http://trac.webkit.org/changeset/57511 Regards, Maciej ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] Recent SVG clipping change caused lots of leaks on the bot

2010-04-13 Thread Maciej Stachowiak
On Apr 13, 2010, at 3:58 PM, Oliver Hunt wrote: looks like ~RenderSVGResourceClipper should be doing deleteAllValues (m_clipper); I'll try that locally once I have a debug build, if no one beats me to it. - Maciej --Oliver On Apr 13, 2010, at 3:48 PM, Maciej Stachowiak wrote

Re: [webkit-dev] Qt is now a core builder

2010-04-14 Thread Maciej Stachowiak
On Apr 13, 2010, at 11:13 PM, Eric Seidel wrote: http://trac.webkit.org/changeset/57561 Sheriff Bot will nag you when you break Qt. Commit Queue will block while any Qt builder is broken. Qt was green all day. The Qt devs @ WKCon seemed very interested in keeping their bots green. The goal

Re: [webkit-dev] Join the URL hackathon (already in progress)!

2010-04-14 Thread Maciej Stachowiak
That's very close to my notes, minor correction inline: On Apr 13, 2010, at 11:17 PM, Adam Barth wrote: I think Maciej took notes, but my recollection is as follows: 1) Convert as many of the unit tests to LayoutTests as possible. 2) Land GURL in svn.webkit.org as is. 3) Convert GURL to

Re: [webkit-dev] Join the URL hackathon (already in progress)!

2010-04-14 Thread Maciej Stachowiak
On Apr 13, 2010, at 11:55 PM, Eric Seidel wrote: Dammit. I'm not smart enough to use mailing lists. My suggestion was WTFURL. ;) WTFURLBBQ - Maciej ___ webkit-dev mailing list webkit-dev@lists.webkit.org

Re: [webkit-dev] #webkit and unregistered nicks

2010-04-14 Thread Maciej Stachowiak
On Apr 14, 2010, at 12:13 AM, Eric Seidel wrote: Is it possible to make it so that folks with unregistered nicks can talk in #webkit again? Does anyone know how? I know how to do it, but every time I do it, the setting gets reset. I'm not sure if that is being done deliberately by someone

Re: [webkit-dev] #webkit and unregistered nicks

2010-04-14 Thread Maciej Stachowiak
(if we get any). Cheers, Maciej On Wed, Apr 14, 2010 at 12:41 PM, Maciej Stachowiak m...@apple.com wrote: On Apr 14, 2010, at 12:13 AM, Eric Seidel wrote: Is it possible to make it so that folks with unregistered nicks can talk in #webkit again? Does anyone know how? I know how to do

Re: [webkit-dev] #webkit and unregistered nicks

2010-04-14 Thread Maciej Stachowiak
ops. - Maciej On Apr 14, 2010, at 4:44 AM, Maciej Stachowiak wrote: Done. We seem to have more trouble with people being mysteriously locked out than with spambots, so we should probably only restrict the channel during active spambot attacks (if we get any). — Timothy Hatcher

Re: [webkit-dev] webkit-patch and SVN

2010-04-14 Thread Maciej Stachowiak
On Apr 14, 2010, at 2:13 PM, Eric Seidel wrote: Anders brought to my attention this afternoon that webkit-patch currently does all SVN operations from the root directory instead of being current-directory aware. That behavior matches how Git operates, but does not need to be how webkit-patch

Re: [webkit-dev] Implementing the sizes attribute of the link tag from HTML5

2010-04-15 Thread Maciej Stachowiak
On Apr 15, 2010, at 2:22 PM, Aaron Boodman wrote: I would like to do it. See bug: https://bugs.webkit.org/show_bug.cgi?id=37674 Thoughts? Seems like a good idea in general. More specifically, what would the implementation do? The bug explains the syntax, but not how it would affect

Re: [webkit-dev] Implementing the sizes attribute of the link tag from HTML5

2010-04-15 Thread Maciej Stachowiak
On Apr 15, 2010, at 3:14 PM, Aaron Boodman wrote: On Thu, Apr 15, 2010 at 3:09 PM, Maciej Stachowiak m...@apple.com wrote: On Apr 15, 2010, at 2:22 PM, Aaron Boodman wrote: I would like to do it. See bug: https://bugs.webkit.org/show_bug.cgi?id=37674 Thoughts? Seems like a good idea

Re: [webkit-dev] python coding style, PEP-8, and 80-column line widths

2010-04-16 Thread Maciej Stachowiak
On Apr 16, 2010, at 1:48 PM, Eric Seidel wrote: bike-shedding I think 80 columns is a waste of time and hurts readability. Instead of being smart about when we wrap code, 80 adheres to a blanket rule, discourages long variable/function names, and needlessly expands code vertically ignoring

Re: [webkit-dev] CMake as a build system?

2010-04-16 Thread Maciej Stachowiak
On Apr 16, 2010, at 2:45 PM, Adam Treat wrote: Sure. Having Bill's and Kitware's help will hopefully make it easier to produce such a demo using CMake. I pledge to help. We can start with this: http://trac.webkit.org/log/trunk/CMakeLists.txt?rev=17853 Can CMake generate native Xcode

Re: [webkit-dev] [webkit meeting notes] build systems

2010-04-16 Thread Maciej Stachowiak
On Apr 16, 2010, at 8:09 AM, Nikolas Zimmermann wrote: Am 16.04.2010 um 16:44 schrieb Adam Treat: I am very skeptical that it is feasible to write a gyp generator that would output QMake files. There is a log of magic in those QMake files. My sense is that it would not be trivial by

Re: [webkit-dev] CMake as a build system?

2010-04-16 Thread Maciej Stachowiak
On Apr 16, 2010, at 3:25 PM, Adam Treat wrote: On Friday 16 April 2010 06:21:39 pm Maciej Stachowiak wrote: On Apr 16, 2010, at 2:45 PM, Adam Treat wrote: Sure. Having Bill's and Kitware's help will hopefully make it easier to produce such a demo using CMake. I pledge to help. We can

Re: [webkit-dev] CMake as a build system?

2010-04-16 Thread Maciej Stachowiak
On Apr 16, 2010, at 5:50 PM, Bill Hoffman wrote: On Fri, Apr 16, 2010 at 6:38 PM, Peter Kasting pkast...@google.com wrote: On Fri, Apr 16, 2010 at 3:35 PM, Maciej Stachowiak m...@apple.com wrote: I'm curious if the Chromium folks who created Gyp had any specific reason that they ruled

Re: [webkit-dev] CMake as a build system?

2010-04-16 Thread Maciej Stachowiak
On Apr 16, 2010, at 7:17 PM, Bill Hoffman wrote: On Fri, Apr 16, 2010 at 10:10 PM, Marc-Antoine Ruel mar...@chromium.org wrote: Thanks Nico for digging up the archive. As I said in the other thread, the people at the session mostly looked about reducing the number of build system, not

Re: [webkit-dev] [webkit meeting notes] build systems

2010-04-17 Thread Maciej Stachowiak
On Apr 17, 2010, at 11:11 AM, Kevin Ollivier wrote: True, but I think the real problem that we're not addressing in this discussion is that different ports have different sets of requirements, meaning their own evaluation process would lead them to choose different tools. If we want a

Re: [webkit-dev] Loader diagram from yesterday's session

2010-04-17 Thread Maciej Stachowiak
On Apr 17, 2010, at 5:22 PM, Adam Barth wrote: I took the liberty of cleaning up this diagram in sketchy: http://webblaze.org/abarth/webkit-loader.html If folks find this diagram useful, we can add it to the web site. Looks good, throw it on the wiki maybe? (You can include images on a

Re: [webkit-dev] python coding style, PEP-8, and 80-column line widths

2010-04-18 Thread Maciej Stachowiak
On Apr 18, 2010, at 12:33 PM, Chris Jerdonek wrote: I wanted to add a couple comments and a question to this discussion. On Fri, Apr 16, 2010 at 2:54 PM, Maciej Stachowiak m...@apple.com wrote: I haven't contributed to WebKit's Python code yet, but I will say that I agree with Eric's

Re: [webkit-dev] Update: new-run-webkit-tests migration

2010-04-19 Thread Maciej Stachowiak
On Apr 18, 2010, at 11:57 PM, Eric Seidel wrote: new-run-webkit-tests is getting closer for general project-wide use. If you're on a Mac and would like to experience sub-3-minute layout test runs and are willing to deal with a few bugs, try new-run-webkit-tests instead of run-webkit-tests next

Re: [webkit-dev] Update: new-run-webkit-tests migration

2010-04-19 Thread Maciej Stachowiak
On Apr 19, 2010, at 1:26 AM, Eric Seidel wrote: [snip answers to questions, which sound good to me] P.S. I would personally prefer to see at least the following bugs fixed before any bot is permanently converted to using new-run-webkit- tests:

Re: [webkit-dev] Experimental new code reviews

2010-04-19 Thread Maciej Stachowiak
I heard another group coded up a different approach to improving reviews - does anyone have a URL for that, so we can compare? Cheers, Maciej On Apr 19, 2010, at 3:35 PM, Ojan Vafai wrote: At the hackathon last Tuesday, a few of us put together mashup style rietveld integration with

Re: [webkit-dev] Implementing the sizes attribute of the link tag from HTML5

2010-04-20 Thread Maciej Stachowiak
On Apr 19, 2010, at 11:58 PM, Aaron Boodman wrote: On Mon, Apr 19, 2010 at 5:53 PM, Peter Kasting pkast...@google.com wrote: On Thu, Apr 15, 2010 at 3:41 PM, Aaron Boodman a...@chromium.org wrote: I'm not sure what the path is for fetching favicons today. Does WebCore just implicitly do

Re: [webkit-dev] MD5 in WebCore

2010-04-20 Thread Maciej Stachowiak
On Apr 20, 2010, at 3:32 AM, Fumitoshi Ukai (鵜飼文敏) wrote: I'm implementing new protocol of WebSocket ( http://www.whatwg.org/specs/web-socket-protocol/ ). Since it now requires MD5 in handshake, I wonder how I could add MD5 in WebCore. For now, there is no MD5 in WebCore. It is in

Re: [webkit-dev] MD5 in WebCore

2010-04-20 Thread Maciej Stachowiak
dependencies, perhaps we could put it in WTF. I don't know if that would help Chromium's dependency issues. Regards, Maciej On Tue, Apr 20, 2010 at 4:12 AM, Maciej Stachowiak m...@apple.com wrote: On Apr 20, 2010, at 3:32 AM, Fumitoshi Ukai (鵜飼文敏) wrote: I'm implementing new protocol

Re: [webkit-dev] MD5 in WebCore

2010-04-20 Thread Maciej Stachowiak
/, and 'base' depending on 'webkit' also doesn't work. How can we avoid replicating the code? I guess having webcore's MD5 be platform specific could help us along those lines? On Tue, Apr 20, 2010 at 4:12 AM, Maciej Stachowiak m...@apple.com wrote: On Apr 20, 2010, at 3:32 AM, Fumitoshi Ukai (鵜飼文敏

Re: [webkit-dev] Implementing HTML5 context menus

2010-04-21 Thread Maciej Stachowiak
On Apr 21, 2010, at 5:06 PM, Drew Wilson wrote: Has anyone done any work/investigation towards implementing the context menu support in HTML5 (the contextmenu attribute and menu elements with type=contextMenu) as described here:

Re: [webkit-dev] JSC String re-factorings are hosing the tree.

2010-04-22 Thread Maciej Stachowiak
On Apr 21, 2010, at 3:35 PM, Ojan Vafai wrote: On Wed, Apr 21, 2010 at 3:27 PM, Gavin Barraclough barraclo...@apple.com wrote: I believe a big problem that caused the extended periods of redness was the slowness of the Windows test queues. These can lag badly behind the builds, making

Re: [webkit-dev] Trouble reviewing patches since the experimental commenting support went into bugs.webkit.org's action=review page

2010-04-22 Thread Maciej Stachowiak
Seems like the most critical issue is that old-style review is broken. Perhaps the comment field can be cleared with a button, or we could add a button to paste the full patch. Other issues seem like iterative refinements we could do over time. - Maciej On Apr 22, 2010, at 1:09 PM,

<    1   2   3   4   5   6   7   8   9   10   >