[webkit-dev] Mozilla -moz-any() selectors extension

2010-04-24 Thread Maciej Stachowiak
Do we want a -webkit version of this? http://dbaron.org/log/20100424-any - Maciej ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] Testing changes to CodeGenerator*.pm

2010-04-29 Thread Maciej Stachowiak
On Apr 29, 2010, at 10:54 AM, Adam Barth wrote: It would be great to have a tool that generates a diff of derived sources for inspection, but making it into a test for everyone to maintain feels like unnecessary burden. I certainly would feel bad about having to maintain a test that

Re: [webkit-dev] Testing changes to CodeGenerator*.pm

2010-04-29 Thread Maciej Stachowiak
to my paragraph below: On Thu, Apr 29, 2010 at 11:05 AM, Maciej Stachowiak m...@apple.com wrote: It also strikes me as odd to do testing by doing exact comparison of the generated source. But I can also see side benefits. I think the real issue here may be one of naming. If the use model

Re: [webkit-dev] Testing changes to CodeGenerator*.pm

2010-04-29 Thread Maciej Stachowiak
On Apr 29, 2010, at 1:05 PM, Adam Barth wrote: On Thu, Apr 29, 2010 at 12:43 PM, Maciej Stachowiak m...@apple.com wrote: It seems to me a better model would be to regenerate the bindings test file automatically as part of the build. Then the changes can still be reviewed by you

Re: [webkit-dev] Python on the Tiger build bot

2010-05-10 Thread Maciej Stachowiak
On May 7, 2010, at 9:10 PM, Eric Seidel wrote: 2. Additionally, Tiger seems mostly ignored by WebKit (note examples like https://bugs.webkit.org/show_bug.cgi?id=38743). No one develops on Tiger to my knowledge (note mjs last night in #webkit noting how he had no access to a Tiger machine, I

Re: [webkit-dev] Yet another bug-less change hosed the tree.

2010-05-10 Thread Maciej Stachowiak
On May 10, 2010, at 2:05 PM, Adam Barth wrote: That's part of what motivated us to create webkit-patch, which makes creating and managing bugs and patches quite easy. Personally, I find webkit-patch upload to be an easier way to prepare a patch for review than approaches you might expect

Re: [webkit-dev] Python on the Tiger build bot

2010-05-11 Thread Maciej Stachowiak
On May 10, 2010, at 11:01 PM, Eric Seidel wrote: On Mon, May 10, 2010 at 2:25 AM, Maciej Stachowiak m...@apple.com wrote: My feeling about requiring a higher Python version for Tiger remains this: I'd prefer that we provide an easy means to do the install of Python 2.6 (ideally a single

Re: [webkit-dev] Yet another bug-less change hosed the tree.

2010-05-11 Thread Maciej Stachowiak
On May 10, 2010, at 11:45 PM, Eric Seidel wrote: As Maciej states, webkit-patch upload is pretty quick (at least for git users). I'm not a git user but I still find it more convenient than any other approach because it has fewer steps and it helps me avoid some common mistakes. I do

Re: [webkit-dev] Yet another bug-less change hosed the tree.

2010-05-11 Thread Maciej Stachowiak
On May 11, 2010, at 9:51 AM, Alexey Proskuryakov wrote: 11.05.2010, в 0:56, Maciej Stachowiak написал(а): I do think making it capable of handling subdirectories would be an improvement for SVN users. Also, I suspect it doesn't work as well as it could for people who prefer to edit

Re: [webkit-dev] Yet another bug-less change hosed the tree.

2010-05-11 Thread Maciej Stachowiak
On May 11, 2010, at 2:30 PM, Geoffrey Garen wrote: Maybe I would use webkit-patch if it really were quite easy. I tried it in earnest for a while, but I had to give it up because: * I couldn't find a ChangeLog workflow that fit its demands, so using it was actually more complicated than

Re: [webkit-dev] converting by constructor

2010-05-17 Thread Maciej Stachowiak
On May 17, 2010, at 12:39 PM, Chris Jerdonek wrote: Hi, I have a basic question. What has been WebKit's stance on the use of the explicit keyword (for higher-level objects in particular)? Do we prefer the looser API's that conversion by constructor affords, or do we more often discourage

Re: [webkit-dev] webkit-patch requests

2010-05-19 Thread Maciej Stachowiak
On May 19, 2010, at 11:04 AM, Darin Adler wrote: On May 19, 2010, at 10:52 AM, Adam Barth wrote: Thanks for the feedback. Webkit-patch already respects the EDITOR environment variable. It should be a simple change to support the CHANGE_LOG_EDIT_APPLICATION environment variable also. The

Re: [webkit-dev] WebAccessibilityRole must match AccessiblityRole enums?

2010-06-10 Thread Maciej Stachowiak
On Jun 4, 2010, at 1:32 PM, Darin Fisher wrote: On Fri, Jun 4, 2010 at 11:15 AM, Peter Kasting pkast...@google.com wrote: On Fri, Jun 4, 2010 at 11:11 AM, Darin Adler da...@apple.com wrote: If the two enum types are identical except for their names, then this doesn’t firewall the types at

Re: [webkit-dev] free functions

2010-06-10 Thread Maciej Stachowiak
On Jun 3, 2010, at 1:36 AM, Chris Jerdonek wrote: On Tue, May 25, 2010 at 10:01 AM, Darin Adler da...@apple.com wrote: On May 25, 2010, at 7:54 AM, Chris Jerdonek wrote: I sometimes come across public member functions whose implementations do not depend on private data. There is a

Re: [webkit-dev] Why does Frame.h use mutable members instead of OwnPtr?

2010-06-11 Thread Maciej Stachowiak
On Jun 10, 2010, at 4:22 PM, Eric Seidel wrote: Example. Use of a mutable member for AnimationController: https://trac.webkit.org/browser/trunk/WebCore/page/Frame.h#L346 Causes us to pull in AnimationController.h: https://trac.webkit.org/browser/trunk/WebCore/page/Frame.h#L31 Which

Re: [webkit-dev] Why does Frame.h use mutable members instead of OwnPtr?

2010-06-11 Thread Maciej Stachowiak
On Jun 11, 2010, at 6:17 PM, Eric Seidel wrote: I'm all for PLT speedups (despite it running too fast on modern hardware to be useful, it's all we got). But I'm very against build-time explosion. :( I bet we don't need to inline all of these. Would be nice to know which ones. Inlines

Re: [webkit-dev] Style question: static, protected, or public members

2010-06-12 Thread Maciej Stachowiak
On Jun 4, 2010, at 3:54 PM, Joe Mason wrote: I'm strongly in favour of g_. It seems weird and ugly to me to have prefixes for some non-local scopes but not all. And it's very helpful to be able to look at a variable reference and immediately know that it's a global, and not a local whose

Re: [webkit-dev] increase the number of tests before bailing?

2010-06-16 Thread Maciej Stachowiak
On Jun 16, 2010, at 2:04 PM, Eric Seidel wrote: We could add a separate option to DumpRenderTree to disable ReportCrash (sign up for all the crashing signals and simply exit(2) or similar). That would be useful in many instances besides the bots. Yes, --exit-after-N-failures was designed

Re: [webkit-dev] strategy for evaluating performance issues related to memory.

2010-06-21 Thread Maciej Stachowiak
On Jun 21, 2010, at 11:59 AM, Mike Marchywka wrote: I was hardly worried about who does anything as much as what would make sense to do. I have interest, motivation, and multiple copies of the code but not a lot of time to waste of bad approaches. There was a prior discussion about

Re: [webkit-dev] Tightening up smart pointer usage rules

2010-06-28 Thread Maciej Stachowiak
I like this idea. Addressing some of the side comments: - Yes, we should get rid of auto_ptr. - I can imagine a leakPtr function being more self-documenting than adoptPtr(...).releasePtr() when it appears in code, but on the other hand the greater convenience may lead to using it carelessly.

Re: [webkit-dev] Frustrated at inconsiderate behavior

2010-07-07 Thread Maciej Stachowiak
Thank you for fixing the problem. Did you try talking to Alexey directly about this? Or to someone else who may be familiar with the situation? It's usually better to try steps like that before calling someone out on the mailing list. And if you do need to bring something to wider attention,

Re: [webkit-dev] Frustrated at inconsiderate behavior

2010-07-07 Thread Maciej Stachowiak
On Jul 7, 2010, at 9:45 AM, Alexey Proskuryakov wrote: I think we can improve this by having sheriff-bot say which tests broke. I bet if you saw these tests listed, you'd have realized what was going one. That would be very useful indeed! It currently takes some effort to find out

Re: [webkit-dev] WebKit2 process model

2010-07-07 Thread Maciej Stachowiak
On Jul 7, 2010, at 4:41 AM, ARaj wrote: Hi, The latest WebKit2 Windows port creates a single process for any number of tabs that are opened. Will this be changed to something like a one-process-per-tab mode? Our short-term plans are to make the threaded and single-web-process modes of

Re: [webkit-dev] Frustrated at inconsiderate behavior

2010-07-07 Thread Maciej Stachowiak
On Jul 7, 2010, at 7:22 PM, James Robinson wrote: On Wed, Jul 7, 2010 at 7:19 PM, Oliver Hunt oli...@apple.com wrote: On Jul 7, 2010, at 7:16 PM, Tony Gentilcore wrote: On Wed, Jul 7, 2010 at 6:50 PM, Mo, Zhenyao zhen...@gmail.com wrote: Maybe I should complain this in a

Re: [webkit-dev] Frustrated at inconsiderate behavior

2010-07-07 Thread Maciej Stachowiak
On Jul 7, 2010, at 7:32 PM, Oliver Hunt wrote: webkit-patch land-safely does the job of running the tests automatically, that said if you have commit privileges you should be running the tests yourself otherwise you're wasting the reviewers time. Pushing a patch through the normal

Re: [webkit-dev] HTML5 MathML3 entities

2010-07-10 Thread Maciej Stachowiak
On Jul 10, 2010, at 3:47 AM, Sausset François wrote: I'm currently working on the MathML3 implementation and I noticed that new XML entities have been defined by the W3C: http://www.w3.org/TR/xml-entity-names/ They are supposed to be used by both HTML 5 MathML 3. I would like to

Re: [webkit-dev] HTML5 MathML3 entities

2010-07-10 Thread Maciej Stachowiak
On Jul 10, 2010, at 9:36 AM, Alexey Proskuryakov wrote: 10.07.2010, в 04:49, Maciej Stachowiak написал(а): Go with the HTML5 / MathML 3 definitions for everything. Our XHTML implementation targets XHTML5, not XHTML 1.0. I think that xml-entity-names and HTML5 made a poor choice

Re: [webkit-dev] HTML5 MathML3 entities

2010-07-10 Thread Maciej Stachowiak
On Jul 10, 2010, at 11:10 AM, Sausset François wrote: I just saw that when looking at the code by myself. What do you exactly mean by a prefix tree? The data structure commonly called a Trie is a prefix tree: http://en.wikipedia.org/wiki/Trie This data structure not only lets you tell if a

Re: [webkit-dev] Removing support for the -khtml- (and -apple-?) vendor prefixes

2010-07-12 Thread Maciej Stachowiak
The reason for these is historical. Originally, we didn't use a separate vendor prefix for WebKit, just -khtml. Later we changed to -apple. Eventually we realized WebKit would not be an Apple-specific project forever, so we switched to -webkit. The main risk to removing the old prefixes is

Re: [webkit-dev] Removing support for the -khtml- (and -apple-?) vendor prefixes

2010-07-12 Thread Maciej Stachowiak
On Jul 12, 2010, at 10:44 AM, Peter Beverloo wrote: Right now WebKit has by far the most prefixed elements[1], a significant part of which have not been standardized/drafted yet. Keeping the translation for all properties active practically triples the amount of supported vendor-specific CSS

Re: [webkit-dev] Bugzilla Question - Master Bug vs Component?

2010-07-12 Thread Maciej Stachowiak
On Jul 12, 2010, at 11:01 AM, Beth Dakin wrote: On Jul 10, 2010, at 1:17 AM, Alex Milowski wrote: I would think we'd close it when we've actually completely implemented MathML. If this is what you want the bug to represent, then it does make sense to keep all feature-implementation

Re: [webkit-dev] Bugzilla Question - Master Bug vs Component?

2010-07-12 Thread Maciej Stachowiak
On Jul 12, 2010, at 4:06 PM, Alex Milowski wrote: On Mon, Jul 12, 2010 at 7:49 PM, Maciej Stachowiak m...@apple.com wrote: I think it's fine to enable MathML soon, as long as we make sure of the following: 1) Using a MathML-enabled build shouldn't cause stability problems

Re: [webkit-dev] About bypassing caches for URLs listed in Fallback and/or Network section in a HTML5 Offline Web Application

2010-07-13 Thread Maciej Stachowiak
On Jul 13, 2010, at 8:14 AM, Lianghui Chen wrote: Hi, I have asked this same question in (wha...@lists.whatwg.org), but haven't got many responses, so I want to ask here again. In spec HTML5 for offline web application (http://www.whatwg.org/specs/web-apps/current-work/#offline) chapter

Re: [webkit-dev] SIL Open Font License and WebKit

2010-07-19 Thread Maciej Stachowiak
Apple's legal department would strongly prefer for WebKit's license terms to remain simple. We prefer everything to be licensed under LGPL or BSD terms, or at the very least a license which is clearly compatible with LGPL and BSD. Is this license LGPL-compatible for cases where the fonts are

Re: [webkit-dev] SIL Open Font License and WebKit

2010-07-19 Thread Maciej Stachowiak
On Jul 19, 2010, at 11:45 AM, Sausset François wrote: Le 19 juil. 2010 à 21:04, Maciej Stachowiak a écrit : Apple's legal department would strongly prefer for WebKit's license terms to remain simple. We prefer everything to be licensed under LGPL or BSD terms, or at the very least

Re: [webkit-dev] Adding window.layoutTestInspector

2010-07-19 Thread Maciej Stachowiak
Darin and I discussed this proposal, and we had a few thoughts to share: (1) It seems a little odd that we'll end up with two different objects that have similar names and a very similar purpose, but just differ in how they are implemented. Maybe there's a way to define layoutTestController in

Re: [webkit-dev] review queue crazy idea

2010-07-21 Thread Maciej Stachowiak
On Jul 21, 2010, at 2:40 PM, Ojan Vafai wrote: There are currently 38 (of 171 total) patches in the review queue where the bugs have not been modified in over 1 month old. I propose we have a bot that educates people about writing easy to review patches and auto-rejects any patches in

Re: [webkit-dev] review queue crazy idea

2010-07-22 Thread Maciej Stachowiak
On Jul 21, 2010, at 3:41 PM, Eric Seidel wrote: Wow. I really like this idea of helping contributors better understand what's going wrong. But, I think that even better would be to build a better front-end for reviews. Or a bot which knew how to suggest reviewers (based on annotate

Re: [webkit-dev] review queue crazy idea

2010-07-24 Thread Maciej Stachowiak
On Jul 23, 2010, at 1:10 PM, Dirk Pranke wrote: I have been thinking along these lines as well. I'm not sure how relevant touching existing lines of code is versus just other people who have hacked on the file at all or who have hacked on other files in the same directory (i.e., you'd need

Re: [webkit-dev] [HTML Editing] WebKit's implementation of removeFormat is completely different from other UAs.

2010-07-25 Thread Maciej Stachowiak
On Jul 25, 2010, at 1:03 AM, Ryosuke Niwa wrote: Are there Apple or third-party products that heavily rely on the current implementation of RemoveFormatCommand? If not, I want to completely re-implement RemoveFormat to match the behavior of other browsers. In MSDN, RemoveFormat is

Re: [webkit-dev] [HTML Editing] WebKit's implementation of removeFormat is completely different from other UAs.

2010-07-26 Thread Maciej Stachowiak
On Jul 26, 2010, at 11:46 AM, Ryosuke Niwa wrote: Thanks a lot for the feedback! On Sun, Jul 25, 2010 at 5:07 PM, Maciej Stachowiak m...@apple.com wrote: I think the key question here is what counts as as formatting. That needs to be determined empirically by testing other browsers

Re: [webkit-dev] Introducing dumpAsMarkup

2010-07-26 Thread Maciej Stachowiak
On Jul 26, 2010, at 3:06 PM, Ryosuke Niwa wrote: If tests you write only require comparing DOMs, you want to read this. We've recently added dump-as-markup. It allows your tests to be platform independent and gives output that is easier to read than render tree dumps. For example, if I

Re: [webkit-dev] [HTML Editing] WebKit's implementation of removeFormat is completely different from other UAs.

2010-07-26 Thread Maciej Stachowiak
On Jul 26, 2010, at 4:27 PM, Ryosuke Niwa wrote: On Mon, Jul 26, 2010 at 1:10 PM, Maciej Stachowiak m...@apple.com wrote: I agree. We should test and see what other browsers do in various cases. But since it's impossible for us to enumerate every possible formatting, I propose to just

Re: [webkit-dev] Introducing dumpAsMarkup

2010-07-26 Thread Maciej Stachowiak
On Jul 26, 2010, at 4:25 PM, Eric Seidel wrote: You can see many more examples of dom2string in the non-html5 results (where there are a zillion failure cases): http://trac.webkit.org/browser/trunk/LayoutTests/html5lib/runner-expected.txt dom2string.js came from

Re: [webkit-dev] Auto-injecting JavaScript with DRT (was Introducing dumpAsMarkup)

2010-07-26 Thread Maciej Stachowiak
On Jul 26, 2010, at 5:46 PM, Ojan Vafai wrote: Then again it should be possible to re-write our script-test support so that this is all you need to write: script src=script-tests.js/script script description(foo); shouldBe(foo, bar); /script script src=end-script-test.js/script

Re: [webkit-dev] Enabling the HTML5 tree builder soon

2010-07-27 Thread Maciej Stachowiak
On Jul 27, 2010, at 9:06 PM, Stephanie Lewis wrote: I measure it as a 1% win on the PLT. Might be a good idea to test HTML iBench as well. - Maciej -- Stephanie On Jul 26, 2010, at 12:36 PM, Stephanie Lewis wrote: I can do this. -- Stephanie Lewis On Jul 26, 2010, at 5:57 AM,

Re: [webkit-dev] Enabling the HTML5 tree builder soon

2010-07-29 Thread Maciej Stachowiak
++ On Thu, Jul 29, 2010 at 3:15 AM, Stephanie Lewis sle...@apple.com wrote: I believe it is somewhere, but the setup is a hassle, so I'll run it tomorrow for you. -- Stephanie On Jul 28, 2010, at 8:13 PM, Adam Barth wrote: On Wed, Jul 28, 2010 at 7:39 AM, Maciej Stachowiak m

Re: [webkit-dev] Updating the tradition for new reviewer blog posts

2010-08-02 Thread Maciej Stachowiak
On Aug 2, 2010, at 1:56 PM, Adam Barth wrote: I'd be happy to write more posts for Surfin' Safari, but I don't know if I need approval, etc. You don't need approval. - Maciej Adam On Mon, Aug 2, 2010 at 1:31 PM, Eric Seidel e...@webkit.org wrote: Woh. I think that's an awesome

Re: [webkit-dev] Updating the tradition for new reviewer blog posts

2010-08-02 Thread Maciej Stachowiak
I agree that it would be good to have more useful and interesting content. I don't think it's good to do this by forcing the task on new reviewers. Not everyone enjoys a writing exercise and it shouldn't be required to become a reviewer. However, I encourage people to post about cool WebKitty

Re: [webkit-dev] webkit editing rewrite?

2010-08-04 Thread Maciej Stachowiak
On Aug 3, 2010, at 4:38 PM, Darin Adler wrote: Inventing a new layer to rebuild editing on top could well be good. Exposing that layer itself to webpages seems like it makes the job even harder rather than easier! Hidden implementation details can be changed more easily than exposed APIs.

Re: [webkit-dev] Some new coding style rules

2010-08-04 Thread Maciej Stachowiak
On Aug 4, 2010, at 10:43 AM, Darin Adler wrote: On Aug 4, 2010, at 1:29 AM, Nikolas Zimmermann wrote: 1. namespace closing brace It was discussed in http://article.gmane.org/gmane.os.opendarwin.webkit.devel/10563, but with no real result. When writing headers, do we need the //

Re: [webkit-dev] Fwd: webkit editing rewrite?

2010-08-05 Thread Maciej Stachowiak
On Aug 4, 2010, at 6:12 PM, Ojan Vafai wrote: On Tue, Aug 3, 2010 at 5:07 PM, Geoffrey Garen gga...@apple.com wrote: -Ensures that the APIs we expose to the web are at least good enough for our own editing code I don't think this necessarily follows. Not everything exposed to the

Re: [webkit-dev] DOM Mutation Events. WAS: Fwd: webkit editing rewrite?

2010-08-11 Thread Maciej Stachowiak
On Aug 9, 2010, at 8:21 PM, Timothy Hatcher wrote: On Aug 9, 2010, at 7:52 PM, Dimitri Glazkov wrote: I am very, very tempted to just get rid of them. As Ojan indicated, the use cases for DOM Mutation events are extremely limited and to me, most of them feel like we should be solving them

Re: [webkit-dev] Why are we running Sputnik?

2010-08-11 Thread Maciej Stachowiak
On Aug 10, 2010, at 2:26 PM, Alexey Proskuryakov wrote: 10.08.2010, в 14:00, Adam Barth написал(а): A better long-term fix might be to finish new-run-webkit-tests so we can run the tests in parallel. One reason to move the tests to run-javascriptcore-tests is that people working on

Re: [webkit-dev] Build system complexity

2010-08-13 Thread Maciej Stachowiak
On Aug 12, 2010, at 2:53 AM, Jeremy Orlow wrote: Are there currently any plans for simplifying the situation regarding build systems? I haven't seen any threads for a while, which I assume means no. Is there any low hanging fruit out there? Since many of the build systems are little

Re: [webkit-dev] Throwing SECURITY_ERR on cross-origin window.location property accesses

2010-08-13 Thread Maciej Stachowiak
On Aug 12, 2010, at 8:08 PM, Mihai Parparita wrote: I was wondering if it would be a reasonable change to make accessing location.href (and other location properties) throw SECURITY_ERR when accessed across origins (https://webkit.org/b/43504). This initially was reported on the Chrome

Re: [webkit-dev] js binding: function argument type checking

2010-08-13 Thread Maciej Stachowiak
I think doing type checks in the bindings makes sense as a long-term strategy. Only the bindings level can tell actually detect wrong type errors; the C++ layer can't distinguish wrong type from a validly passed null. WebGL interfaces are not the only ones that have this problem. Here is a DOM

Re: [webkit-dev] Throwing SECURITY_ERR on cross-origin window.location property accesses

2010-08-13 Thread Maciej Stachowiak
On Aug 13, 2010, at 2:12 AM, Jeremy Orlow wrote: On Fri, Aug 13, 2010 at 8:42 AM, Maciej Stachowiak m...@apple.com wrote: On Aug 12, 2010, at 8:08 PM, Mihai Parparita wrote: I was wondering if it would be a reasonable change to make accessing location.href (and other location properties

Re: [webkit-dev] Tests that separate JS and HTML

2010-08-16 Thread Maciej Stachowiak
On Aug 16, 2010, at 12:44 PM, Ojan Vafai wrote: I agree that dealing with the script to generate tests and having the actual test content be in a different file is a significant maintenance overhead. But I also think that having standard testing code across many tests reduces the amount

Re: [webkit-dev] DeviceOrientation/Motion on Document rather than Page

2010-08-17 Thread Maciej Stachowiak
On Aug 16, 2010, at 10:52 PM, Eric Seidel wrote: Where-ever it goes, please don't put it on Document directly. :) (Feel free to tie it to Document's lifetime, just don't add to Document's 300+ methods.) The madness must stop... Document is long overdue for some weightloss... I assume

Re: [webkit-dev] Why does isLocationChange() return false for redirection?

2010-08-17 Thread Maciej Stachowiak
On Aug 16, 2010, at 10:58 PM, Eric Zhou wrote: Hi all, following is the related code. My question is why it returns false when ScheduledRedirection.type is redirection. From the name of the function, I think if the url changes, it should return true. Thus, for most of redirection, it

Re: [webkit-dev] DeviceOrientation/Motion on Document rather than Page

2010-08-17 Thread Maciej Stachowiak
On Aug 17, 2010, at 6:50 AM, Dean Jackson wrote: On 17/08/2010, at 12:22 AM, Maciej Stachowiak wrote: On Aug 16, 2010, at 10:52 PM, Eric Seidel wrote: Where-ever it goes, please don't put it on Document directly. :) (Feel free to tie it to Document's lifetime, just don't add

Re: [webkit-dev] Cleaning up Document.* (was DeviceOrientation/Motion on Document rather than Page)

2010-08-17 Thread Maciej Stachowiak
:50 AM, Dean Jackson d...@apple.com wrote: On 17/08/2010, at 12:22 AM, Maciej Stachowiak wrote: On Aug 16, 2010, at 10:52 PM, Eric Seidel wrote: Where-ever it goes, please don't put it on Document directly. :) (Feel free to tie it to Document's lifetime, just don't add to Document's 300

[webkit-dev] Six new layout tests missing expected results

2010-08-18 Thread Maciej Stachowiak
Who knows what is up with these? I'm guessing they came from the same patch. Please fix if you know what these are about. fast/table/simple_paint.html - new tables/hittesting/filltable-emptycells.html - new tables/hittesting/filltable-levels.html - new tables/hittesting/filltable-outline.html -

Re: [webkit-dev] AXObjectCache memory management?

2010-08-23 Thread Maciej Stachowiak
On Aug 23, 2010, at 12:47 AM, Eric Seidel wrote: Does anyone know why AXObjectCache is not ref counted? It has some manual scheme which seems likely to have bugs in it. http://trac.webkit.org/browser/trunk/WebCore/dom/Document.cpp#L1742 There just seems to be a lot of code in Document

Re: [webkit-dev] Can someone explain tx/ty?

2010-08-23 Thread Maciej Stachowiak
On Aug 23, 2010, at 12:51 AM, Eric Seidel wrote: I believe int tx, int ty -- which we see sprinkled around the rendering tree -- are the offset from the top left corner of the current renderer's parent to the containing block. Is that correct? In SVG we use IntSize containingBlockOffset

Re: [webkit-dev] Not enough space message when linking webkit (lots of free disk space)

2010-08-23 Thread Maciej Stachowiak
On Aug 23, 2010, at 2:38 AM, Eric Seidel wrote: SVG gets such a bad wrap. :) Wouldn't breaking WebCore into smaller libraries fix these linker problems longer-term? For example, breaking out platform into a .a, or the JS bindings? I guess we'd have to make them .dylib instead of .a if we

Re: [webkit-dev] Can someone explain tx/ty?

2010-08-23 Thread Maciej Stachowiak
On Aug 23, 2010, at 10:20 AM, David Hyatt wrote: On Aug 23, 2010, at 12:11 PM, David Hyatt wrote: (hopefully less verbose, but you get the idea). tx, ty could be named parentOffsetFromLayerCoordinates or something. This seems to be the intent of the names - that x,y is a point and

Re: [webkit-dev] Place For new Core Module

2010-08-24 Thread Maciej Stachowiak
Given your description, I'm not sure this functionality is appropriate for WebKit. We are generally reluctant to take feature patches for features that are experimental or of niche interest - we prefer to focus on technologies that are part of the standards-based Web technology stack, that are

Re: [webkit-dev] Web Audio API

2010-08-24 Thread Maciej Stachowiak
This sounds like a reasonable plan. I have no strong feelings about any of the naming options, but I like the overall idea of getting this code into trunk now, using a feature define, and separating the Web-facing parts from the platform implementation parts. - Maciej On Aug 24, 2010, at

Re: [webkit-dev] We need OwnPtrHashMap

2010-08-25 Thread Maciej Stachowiak
On Aug 25, 2010, at 1:46 PM, Geoffrey Garen wrote: Sorry for the late-night webkit-dev spam, but in deploying adoptPtr, I've noticed a number of places where have a HashMap that owns its values as OwnPtrs. Unfortunately, this very clumsy currently. Each instance of this pattern has its own

Re: [webkit-dev] Misplaced files

2010-08-27 Thread Maciej Stachowiak
On Aug 27, 2010, at 3:55 PM, Adam Barth wrote: Looking through WebCore/html I noticed the files below. I'm not sure they belong in WebCore/html because they don't appear to be HTML-specific. Rather, they seem like generic web platform APIs (e.g., they could be exposed to SVG or whatever

Re: [webkit-dev] Misplaced files

2010-08-27 Thread Maciej Stachowiak
On Aug 27, 2010, at 5:15 PM, Adam Barth wrote: On Fri, Aug 27, 2010 at 4:08 PM, Maciej Stachowiak m...@apple.com wrote: On Aug 27, 2010, at 3:55 PM, Adam Barth wrote: Looking through WebCore/html I noticed the files below. I'm not sure they belong in WebCore/html because they don't appear

Re: [webkit-dev] Misplaced files

2010-08-27 Thread Maciej Stachowiak
, Aug 27, 2010 at 6:01 PM, Maciej Stachowiak m...@apple.com wrote: On Aug 27, 2010, at 5:15 PM, Adam Barth wrote: On Fri, Aug 27, 2010 at 4:08 PM, Maciej Stachowiak m...@apple.com wrote: On Aug 27, 2010, at 3:55 PM, Adam Barth wrote: Looking through WebCore/html I noticed the files below

Re: [webkit-dev] Changes to line-by-line code reviews

2010-08-29 Thread Maciej Stachowiak
On Aug 29, 2010, at 4:39 PM, Adam Barth wrote: On Sun, Aug 29, 2010 at 4:16 PM, Maciej Stachowiak m...@apple.com wrote: I'm not sure who objects to new features being added to Review Patch, but I don't like this change: There's a tention between folks who like line-by-line comments

Re: [webkit-dev] We need OwnPtrHashMap

2010-08-29 Thread Maciej Stachowiak
On Aug 28, 2010, at 10:57 PM, Darin Adler wrote: We need VectorOwnPtr too. It has similar issues to HashMap with OwnPtr values, including the ones mentioned by Maciej. For one example, look at CSSParser::m_floatingMediaQueryExpList. VectorOwnPtr actually works[1], and I have an almost

Re: [webkit-dev] We need OwnPtrHashMap

2010-08-29 Thread Maciej Stachowiak
On Aug 29, 2010, at 9:14 PM, Maciej Stachowiak wrote: Yet another possibility is to use a hash to do the de-duping instead of sorting; I can't tell from context if the sorting is needed for any purpose other than subsequent de-duping. Turns out this doesn't work - the CSS Media Queries

Re: [webkit-dev] Misplaced files

2010-08-30 Thread Maciej Stachowiak
On Aug 30, 2010, at 8:36 AM, Darin Fisher wrote: On Mon, Aug 30, 2010 at 12:18 AM, Adam Barth aba...@webkit.org wrote: On Fri, Aug 27, 2010 at 8:12 PM, Maciej Stachowiak m...@apple.com wrote: Yes. The file-related stuff should all be in one directory, I think. Ok. I moved the files from

Re: [webkit-dev] We need OwnPtrHashMap

2010-08-30 Thread Maciej Stachowiak
On Aug 29, 2010, at 9:34 PM, Maciej Stachowiak wrote: On Aug 29, 2010, at 9:14 PM, Maciej Stachowiak wrote: Yet another possibility is to use a hash to do the de-duping instead of sorting; I can't tell from context if the sorting is needed for any purpose other than subsequent de

Re: [webkit-dev] Complex and Vector3 classes in WTF?

2010-08-31 Thread Maciej Stachowiak
On Aug 31, 2010, at 2:06 PM, Chris Marrin wrote: On Aug 31, 2010, at 11:48 AM, Kenneth Russell wrote: On Tue, Aug 31, 2010 at 11:05 AM, David Hyatt hy...@apple.com wrote: On Aug 31, 2010, at 10:36 AM, Chris Marrin wrote: Or should we get rid of Vector3, added the functionality it needs

Re: [webkit-dev] Complex and Vector3 classes in WTF?

2010-08-31 Thread Maciej Stachowiak
On Aug 31, 2010, at 3:59 PM, Chris Marrin wrote: On Aug 31, 2010, at 3:43 PM, Kenneth Russell wrote: On Tue, Aug 31, 2010 at 3:39 PM, Chris Marrin cmar...@apple.com wrote: On Aug 31, 2010, at 3:25 PM, Maciej Stachowiak wrote: On Aug 31, 2010, at 2:06 PM, Chris Marrin wrote

Re: [webkit-dev] Complex and Vector3 classes in WTF?

2010-08-31 Thread Maciej Stachowiak
On Aug 31, 2010, at 5:29 PM, Chris Marrin wrote: On Aug 31, 2010, at 5:25 PM, Kenneth Russell wrote: ...Yes, I did the Google search and you're right that the term is not in common usage (although I still maintain it's a completely reasonable term). The reason I think it's meaningful

Re: [webkit-dev] Complex and Vector3 classes in WTF?

2010-09-01 Thread Maciej Stachowiak
On Sep 1, 2010, at 11:43 AM, Chris Marrin wrote: But I agree with Maciej that all of the public API is transformation oriented. Even things like inverse() and transpose() have application in doing transforms. I think it would be a stretch to use this 4x4 matrix for general purposes. A

Re: [webkit-dev] Arena is crufty?

2010-09-01 Thread Maciej Stachowiak
On Sep 1, 2010, at 4:20 PM, Chris Marrin wrote: Ken's PODRedBlackTree patch has made me go back and take a closer look at WebKit's Arena class. Turns out it's not a class at all, just some structs and macros. That seems very un-WebKit-like to me. Ken's patch also has a PODArena class,

Re: [webkit-dev] Arena is crufty?

2010-09-01 Thread Maciej Stachowiak
On Sep 1, 2010, at 7:04 PM, David Hyatt wrote: We should just kill Arena and remove it and RenderArena both. Wasn't it still a measurable slowdown last time we tried that? - Maciej On Sep 1, 2010, at 4:20 PM, Chris Marrin wrote: Ken's PODRedBlackTree patch has made me go back and

Re: [webkit-dev] Script programming language: Perl, Python, or Ruby?

2010-09-01 Thread Maciej Stachowiak
On Sep 1, 2010, at 9:28 PM, Dirk Pranke wrote: Hi Sam, Did you see the reply I sent on this thread? There are actually decent reasons to rewrite the code into Python, to simplify and speed up the new-run-webkit-tests implementation. Given that, do you still object to the patch landing

Re: [webkit-dev] Script programming language: Perl, Python, or Ruby?

2010-09-01 Thread Maciej Stachowiak
On Sep 1, 2010, at 10:46 PM, David Levin wrote: From reading this thread and the bug, it sounds like there is one key issue installing something new on build machines. As discussed before in regards to python, there was a desire not to go above a certain version so that the tiger build

Re: [webkit-dev] Arena is crufty?

2010-09-02 Thread Maciej Stachowiak
On Sep 2, 2010, at 8:51 AM, Chris Marrin wrote: On Sep 1, 2010, at 7:20 PM, Kenneth Russell wrote: I would be happy to not add another Arena client, but the primary reason I need an arena is not just for performance but to avoid having to keep track of all of the objects I need to

Re: [webkit-dev] attached()

2010-09-09 Thread Maciej Stachowiak
On Sep 9, 2010, at 12:00 AM, Eric Seidel wrote: I'm about to remove the last non-lazy attaching element. https://bugs.webkit.org/show_bug.cgi?id=45365 I think we can now kill the whole concept of being attached. attached() does not necessarily mean you have a renderer. It just means

Re: [webkit-dev] attached()

2010-09-09 Thread Maciej Stachowiak
On Sep 9, 2010, at 1:29 AM, Eric Seidel wrote: On Thu, Sep 9, 2010 at 12:43 AM, Maciej Stachowiak m...@apple.com wrote: On Sep 9, 2010, at 12:00 AM, Eric Seidel wrote: I'm about to remove the last non-lazy attaching element. https://bugs.webkit.org/show_bug.cgi?id=45365 I think we

Re: [webkit-dev] Why is ResourceHandle.cpp in WebKit/chromium/src

2010-09-11 Thread Maciej Stachowiak
On Sep 11, 2010, at 2:49 AM, Adam Barth wrote: That makes a certain amount of sense. It seems like we have three ways for WebCore to talk to Webkit/foo: 1) Client interfaces 2) PlatformBridge 3) Header-in-WebCore, implementation-in-WebKit/foo Is there some systematic way of

Re: [webkit-dev] Use of Frame by ResourceHandle

2010-09-11 Thread Maciej Stachowiak
11, 2010 at 3:42 PM, Maciej Stachowiak m...@apple.com wrote: On Sep 11, 2010, at 2:57 AM, Adam Barth wrote: I don't mean to spam this list with design questions, but I'm trying to wrap my mind around how the loader is put together today and how we'd like it to be put together in the future

Re: [webkit-dev] Use of Frame by ResourceHandle

2010-09-12 Thread Maciej Stachowiak
I like Adam's thinking on this. ResourceHandle depending on Frame, even indirectly, is something of a layering violation. It makes more sense to factor out the bits that it does need, a la NetworkContext. Using client methods to make an association externally seems ok too, but poses more risk

Re: [webkit-dev] Why is ResourceHandle.cpp in WebKit/chromium/src

2010-09-12 Thread Maciej Stachowiak
On Sep 11, 2010, at 9:42 PM, Darin Fisher wrote: On Sat, Sep 11, 2010 at 2:49 AM, Adam Barth aba...@webkit.org wrote: If we like pattern (3), maybe we should replace PlatformBridge with (3)? Yes, perhaps we should do that. In concert with that, it would be good to create a

Re: [webkit-dev] Can node-renderer()-node() == node ever be false?

2010-09-14 Thread Maciej Stachowiak
On Sep 14, 2010, at 5:41 PM, Dimitri Glazkov wrote: Sorry, I meant node-renderer()-node() != 0. My bad. This loop will always exit in in the first iteration. It definitely is possible for renderers to have a null result from node(). I do not know for sure that it's impossible for

Re: [webkit-dev] Blob scheme implementation

2010-09-14 Thread Maciej Stachowiak
On Sep 14, 2010, at 6:02 PM, Adam Barth wrote: On Tue, Sep 14, 2010 at 5:56 PM, David Levin le...@chromium.org wrote: On Tue, Sep 14, 2010 at 5:42 PM, Adam Barth aba...@webkit.org wrote: What do you think of the idea of having a re-useable BlobCore module that all the ports can share? I

Re: [webkit-dev] Blob scheme implementation

2010-09-15 Thread Maciej Stachowiak
scheme, but one way or another, blob: needs to be special, so maybe that's ok. Regards, Maciej On Tue, Sep 14, 2010 at 6:21 PM, Maciej Stachowiak m...@apple.com wrote: On Sep 14, 2010, at 6:02 PM, Adam Barth wrote: On Tue, Sep 14, 2010 at 5:56 PM, David Levin le...@chromium.org wrote

Re: [webkit-dev] Blob scheme implementation

2010-09-15 Thread Maciej Stachowiak
On Sep 15, 2010, at 9:15 AM, Darin Fisher wrote: On Wed, Sep 15, 2010 at 8:58 AM, Alexey Proskuryakov a...@webkit.org wrote: 14.09.2010, в 22:15, Darin Fisher написал(а): I think it makes sense to extend ResourceHandle.cpp to access the BlobRegistry singleton in order to support blob

Re: [webkit-dev] Blob scheme implementation

2010-09-15 Thread Maciej Stachowiak
On Sep 15, 2010, at 1:06 PM, Darin Fisher wrote: On Wed, Sep 15, 2010 at 12:56 PM, Maciej Stachowiak m...@apple.com wrote: On Sep 15, 2010, at 9:15 AM, Darin Fisher wrote: On Wed, Sep 15, 2010 at 8:58 AM, Alexey Proskuryakov a...@webkit.org wrote: 14.09.2010, в 22:15, Darin Fisher

Re: [webkit-dev] Blob scheme implementation

2010-09-15 Thread Maciej Stachowiak
On Sep 15, 2010, at 2:05 PM, Adam Barth wrote: On Wed, Sep 15, 2010 at 1:09 PM, Darin Fisher da...@chromium.org wrote: I'm ignoring javascript: URLs because they are super weird... evaluation happens synchronously and can have side effects such as causing other navigations. It does not fit

<    2   3   4   5   6   7   8   9   10   11   >