Re: [webkit-dev] Feature announcement: canvas pixel access API additions for high-resolution backing stores

2012-04-16 Thread Maciej Stachowiak
On Apr 16, 2012, at 4:03 PM, Dirk Schulze wrote: Different developers will have different priorities. HD image data and async readback both have potential benefits in image quality and nonblocking responsiveness respectively. Here is an example of an application using getImageData which

Re: [webkit-dev] CMake for Apple's Windows port

2012-04-19 Thread Maciej Stachowiak
A lot of folks have laptops, so perhaps someone could be convinced to give you the scoop by IRC. - Maciej On Apr 19, 2012, at 10:11 PM, Patrick Gansterer wrote: I'm very interested in that discussion, but I can't be physically there. :-( Is there any any possibility for me to attend it

Re: [webkit-dev] Eliminate potential null pointer dereference?

2012-04-20 Thread Maciej Stachowiak
On Apr 19, 2012, at 10:35 PM, David Barr wrote: On Fri, Apr 20, 2012 at 3:18 PM, Alexey Proskuryakov a...@webkit.org wrote: I noticed a number of patches going in recently that add null checks, or refactor the code under the premise of eliminating potential null dereference. What does

Re: [webkit-dev] Eliminate potential null pointer dereference?

2012-04-20 Thread Maciej Stachowiak
On Apr 19, 2012, at 11:11 PM, David Levin wrote: I think this all started with a lot of effort put into fixing an issue reported by a user where they said the most popular online forum in Malaysia is broken. Then folks had to do a lot of builds (bisecting) to track down where the problem

Re: [webkit-dev] Eliminate potential null pointer dereference?

2012-04-20 Thread Maciej Stachowiak
Hi Luke, I feel like you've been put on the defensive a bit here, which is unfortunate. I do agree with the value of readable code and hackability is one of the core values of the WebKit project. Code should indeed be meaningful to programmers. One thing to keep in mind though is that, by

Re: [webkit-dev] Eliminate potential null pointer dereference?

2012-04-20 Thread Maciej Stachowiak
On Apr 20, 2012, at 12:05 PM, Kentaro Hara wrote: +1 to the idea that we should try to add a test for each change. That being said, as rniwa mentioned, it is sometimes difficult to make a test because (A) we do not come up with a test case (B) we know that the code is unreachable (e.g.

Re: [webkit-dev] Eliminate potential null pointer dereference?

2012-04-20 Thread Maciej Stachowiak
On Apr 20, 2012, at 1:48 PM, Rachel Blum wrote: I completely agree with Maciej here that if this is a reachable code, then the patch author should put a reasonable effort into creating a test case. And most importantly, these changes are clearly not code cleanup. I'm disagreeing here.

Re: [webkit-dev] Eliminate potential null pointer dereference?

2012-04-21 Thread Maciej Stachowiak
On Apr 21, 2012, at 9:45 AM, Antti Koivisto wrote: Sat, Apr 21, 2012 at 8:13 AM, John Yani van...@gmail.com wrote: 2316if (selector-relation() != CSSSelector::SubSelector) 2317break; 2318selector = selector-tagHistory(); 2319}; Now selector

Re: [webkit-dev] FYI: sub-pixel layout landing soon

2012-04-23 Thread Maciej Stachowiak
If it's a global switch that ports can't opt out of, then we have to do this at a time when it wouldn't disrupt anyone's release cycle. Let's say hypothetically a vendor was going to branch from trunk and ship in two weeks (not actually the case for us, but just to make it an extreme example).

Re: [webkit-dev] Double-Resolution (Retina) Images - Re: -webkit-image-set

2012-04-24 Thread Maciej Stachowiak
It would be more readable to use: @media screen and (min-device-pixel-ratio: 2) { … } The -webkit-image-set proposal explains why it is a useful shorthand despite the existing device pixel ratio option. Regards, Maciej On Apr 23, 2012, at 11:11 PM, Eric Seidel wrote: Assuming I'm

[webkit-dev] Bot watching and Apple bots

2012-04-25 Thread Maciej Stachowiak
Hi everyone, A while back, Apple's WebKit teams instituted a bot watching rotation to try to get the bots for our ports to get and stay green. We've managed to consistently stay around low single digits of failures, but the green doesn't seem to stick. We think some folks in the community may

Re: [webkit-dev] Bot watching and Apple bots

2012-04-25 Thread Maciej Stachowiak
On Apr 25, 2012, at 2:34 PM, Adrienne Walker e...@google.com wrote: Hi- This has been on my mind lately too, so I'm happy that you brought it up. I have a couple of questions: Would it be possible to make mac's ews warn about test failures in the same way that chromium-ews does? That's

Re: [webkit-dev] Deprecating features guideline wiki

2012-04-27 Thread Maciej Stachowiak
I think the concern is that, due to lack of clear standards, we end up not knowing when we can remove things. Thus, we end up with a lot of inconclusive and frustrating conversations, and people may shy away from even trying to remove things. BTW, the page at

Re: [webkit-dev] webkitPostMessage

2012-04-29 Thread Maciej Stachowiak
On Apr 29, 2012, at 11:01 AM, Adam Barth aba...@webkit.org wrote: I read https://trac.webkit.org/wiki/DeprecatingFeatures, but I'm still unsure how to proceed with removing webkitPostMessage and aligning postMessage with the spec. No one responded to my earlier message, so I'm inclined to

Re: [webkit-dev] Deprecating features guideline wiki

2012-04-29 Thread Maciej Stachowiak
On Apr 27, 2012, at 6:29 PM, Dirk Pranke dpra...@chromium.org wrote: BTW, the page at https://trac.webkit.org/wiki/DeprecatingFeatures seems to be using deprecate in the sense of remove entirely. Is that what is meant? If so, I think it would be helpful to change the wording to removing

Re: [webkit-dev] webkitPostMessage

2012-04-29 Thread Maciej Stachowiak
On Apr 29, 2012, at 12:53 PM, Ryosuke Niwa rn...@webkit.org wrote: On Sun, Apr 29, 2012 at 12:34 PM, Maciej Stachowiak m...@apple.com wrote: On Apr 29, 2012, at 11:01 AM, Adam Barth aba...@webkit.org wrote: I read https://trac.webkit.org/wiki/DeprecatingFeatures, but I'm still unsure how

Re: [webkit-dev] Deprecating features guideline wiki

2012-04-29 Thread Maciej Stachowiak
On Apr 29, 2012, at 1:04 PM, Ryosuke Niwa rn...@webkit.org wrote: On Sun, Apr 29, 2012 at 12:37 PM, Maciej Stachowiak m...@apple.com wrote: On Apr 27, 2012, at 6:29 PM, Dirk Pranke dpra...@chromium.org wrote: BTW, the page at https://trac.webkit.org/wiki/DeprecatingFeatures seems

Re: [webkit-dev] Deprecating features guideline wiki

2012-04-29 Thread Maciej Stachowiak
On Apr 29, 2012, at 1:18 PM, Ryosuke Niwa rn...@webkit.org wrote: On Sun, Apr 29, 2012 at 1:08 PM, Maciej Stachowiak m...@apple.com wrote: On Apr 29, 2012, at 1:04 PM, Ryosuke Niwa rn...@webkit.org wrote: On Sun, Apr 29, 2012 at 12:37 PM, Maciej Stachowiak m...@apple.com wrote: On Apr 27

Re: [webkit-dev] webkitPostMessage

2012-04-29 Thread Maciej Stachowiak
On Apr 29, 2012, at 1:35 PM, Adam Barth aba...@webkit.org wrote: There is very little cost on the WebKit project to maintain webkitPostMessage in addition to postMessage. Instead, supporting webkitPostMessage imposes a cost on the web platform at large by reducing interoperability

Re: [webkit-dev] (no subject)

2012-04-29 Thread Maciej Stachowiak
On Apr 29, 2012, at 1:25 PM, Ryosuke Niwa rn...@webkit.org wrote: I'm actually curious as to how the session participants reached this consensus (probably on a separate thread). It seems like the bar shouldn't too high for removing prefixed APIs when they are unprefixed equivalents

[webkit-dev] LayoutTestHelper

2012-04-29 Thread Maciej Stachowiak
Hi folks, new-run-webkit-tests seems to mess with the system color profile on Mac, even when not running pixel tests. Historically, I believe we did this only when running pixel tests. I noticed that this is because it launches the LayoutTestHelper tool unconditionally, and in addition to

Re: [webkit-dev] LayoutTestHelper

2012-04-29 Thread Maciej Stachowiak
On Apr 29, 2012, at 5:49 PM, Maciej Stachowiak m...@apple.com wrote: Hi folks, new-run-webkit-tests seems to mess with the system color profile on Mac, even when not running pixel tests. Historically, I believe we did this only when running pixel tests. I noticed that this is because

Re: [webkit-dev] webkitPostMessage

2012-04-29 Thread Maciej Stachowiak
On Apr 29, 2012, at 6:42 PM, Adam Barth aba...@webkit.org wrote: On Sun, Apr 29, 2012 at 2:25 PM, Maciej Stachowiak m...@apple.com wrote: On Apr 29, 2012, at 1:35 PM, Adam Barth aba...@webkit.org wrote: There is very little cost on the WebKit project to maintain webkitPostMessage

Re: [webkit-dev] webkitPostMessage

2012-04-29 Thread Maciej Stachowiak
On Apr 29, 2012, at 6:56 PM, Maciej Stachowiak m...@apple.com wrote: I think the relevant question is how much (if any) content uses webkitPostMessage (without unprefixed postMessage fallback). The fact that postMessage incorporates the new functionality doesn't answer that question

Re: [webkit-dev] Feature Announcement: Adding iframe seamless

2012-05-01 Thread Maciej Stachowiak
On May 1, 2012, at 12:20 PM, Eric Seidel e...@webkit.org wrote: Work is complete, fully working. Passing all the tests I could come up with: https://github.com/eseidel/webkit/compare/master...seamless I'm uploading and landing patches once reviewed again in bugzilla. I do not plan to

Re: [webkit-dev] Feature Announcement: Adding iframe seamless

2012-05-01 Thread Maciej Stachowiak
I'm looking for is to disable the entire feature if necessary. However, I don't expect that any ports Apple is involved with would leave it off indefinitely. I hope that answers your questions. Regards, Maciej On Tue, May 1, 2012 at 2:06 PM, Maciej Stachowiak m...@apple.com wrote: On May

Re: [webkit-dev] Feature Announcement: Adding iframe seamless

2012-05-01 Thread Maciej Stachowiak
On May 1, 2012, at 4:04 PM, Adam Barth aba...@webkit.org wrote: On Tue, May 1, 2012 at 3:50 PM, Maciej Stachowiak m...@apple.com wrote: On May 1, 2012, at 3:31 PM, Eric Seidel e...@webkit.org wrote: Is your goal to be able to disable the feature to prevent a late-known security issue

Re: [webkit-dev] Feature Announcement: Adding iframe seamless

2012-05-02 Thread Maciej Stachowiak
On May 2, 2012, at 6:14 AM, Jarred Nicholls jar...@webkit.org wrote: On Tue, May 1, 2012 at 7:39 PM, Maciej Stachowiak m...@apple.com wrote: I'm not too picky about how it's done, but I'd feel more comfortable with #ifdef protecting the code changes rather than if(). If the changes

Re: [webkit-dev] Feature Announcement: Adding iframe seamless

2012-05-02 Thread Maciej Stachowiak
On May 2, 2012, at 11:48 AM, Jarred Nicholls jar...@webkit.org wrote: On Wed, May 2, 2012 at 2:03 PM, Maciej Stachowiak m...@apple.com wrote: On May 2, 2012, at 6:14 AM, Jarred Nicholls jar...@webkit.org wrote: On Tue, May 1, 2012 at 7:39 PM, Maciej Stachowiak m...@apple.com wrote

Re: [webkit-dev] Feature Announcement: Adding iframe seamless

2012-05-02 Thread Maciej Stachowiak
On May 2, 2012, at 1:03 PM, Adam Barth aba...@webkit.org wrote: One example from this case is seamless navigation. I implemented seamless navigation in two steps: 1) Refactoring the existing codepaths to go through a common function. 2) Teaching the common function how to redirect

Re: [webkit-dev] LayoutTestHelper

2012-05-03 Thread Maciej Stachowiak
Pranke dpra...@chromium.org wrote: On Sun, Apr 29, 2012 at 6:20 PM, Maciej Stachowiak m...@apple.com wrote: On Apr 29, 2012, at 5:49 PM, Maciej Stachowiak m...@apple.com wrote: Hi folks, new-run-webkit-tests seems to mess with the system color profile on Mac, even when not running

Re: [webkit-dev] LayoutTestHelper

2012-05-03 Thread Maciej Stachowiak
On May 3, 2012, at 8:54 AM, Dirk Pranke dpra...@chromium.org wrote: On Thu, May 3, 2012 at 7:35 AM, Maciej Stachowiak m...@apple.com wrote: Better naming/documentation may help. But I think the root problem here was that the Chromium Android LayoutTestHelper does not exist in the WebKit

Re: [webkit-dev] spamming the developer console

2012-05-11 Thread Maciej Stachowiak
On May 11, 2012, at 2:21 PM, Ojan Vafai o...@chromium.org wrote: The amount of spam we throw in the developer console has grown quite a bit. spam == things logged to the console that web developers have no control over Unlike uncaught javascript exceptions (which can easily just be

Re: [webkit-dev] Simplifying syntax in test_expectations.txt (bug 86691)

2012-05-16 Thread Maciej Stachowiak
On May 16, 2012, at 9:08 PM, Ryosuke Niwa rn...@webkit.org wrote: Hi, There has been some complaints / discussions about how syntax in test_expectations.txt is confusing (and I agree with you) on webkit-dev and at contributors' meeting. So I have a patch on

Re: [webkit-dev] Simplifying syntax in test_expectations.txt (bug 86691)

2012-05-17 Thread Maciej Stachowiak
On May 16, 2012, at 10:39 PM, Dirk Pranke dpra...@chromium.org wrote: There was a semi-logical basis, in that the stuff on the right of the test clearly specified the outcome of the test (PASS, IMAGE, TEXT, etc.). The stuff on the left was less well defined: there's the bug numbers, the

Re: [webkit-dev] Simplifying syntax in test_expectations.txt (bug 86691)

2012-05-17 Thread Maciej Stachowiak
On May 17, 2012, at 11:28 AM, Ryosuke Niwa rn...@webkit.org wrote: On Thu, May 17, 2012 at 11:08 AM, Peter Kasting pkast...@google.com wrote: On Thu, May 17, 2012 at 9:26 AM, Dimitri Glazkov dglaz...@chromium.org wrote: I actually quite like the clear delineation between test modifiers and

Re: [webkit-dev] Simplifying syntax in test_expectations.txt (bug 86691)

2012-05-17 Thread Maciej Stachowiak
On May 17, 2012, at 12:53 PM, Dirk Pranke dpra...@chromium.org wrote: On Thu, May 17, 2012 at 12:47 PM, Ryosuke Niwa rn...@webkit.org wrote: I find either all-lowercase or all-caps to be much harder to read than capitalized words. They look like a blob of letters to me. We might have to

Re: [webkit-dev] Simplifying syntax in test_expectations.txt (bug 86691)

2012-05-17 Thread Maciej Stachowiak
On May 17, 2012, at 3:37 PM, Dirk Pranke dpra...@chromium.org wrote: On Thu, May 17, 2012 at 3:21 PM, Ryosuke Niwa rn...@webkit.org wrote: On Thu, May 17, 2012 at 3:01 PM, Dirk Pranke dpra...@chromium.org wrote: As I said before, I believe they increase the readability of the file. I

Re: [webkit-dev] Simplifying syntax in test_expectations.txt (bug 86691)

2012-05-17 Thread Maciej Stachowiak
On May 17, 2012, at 4:17 PM, Dirk Pranke dpra...@chromium.org wrote: On Thu, May 17, 2012 at 4:00 PM, Maciej Stachowiak m...@apple.com wrote: On May 17, 2012, at 12:53 PM, Dirk Pranke dpra...@chromium.org wrote: On Thu, May 17, 2012 at 12:47 PM, Ryosuke Niwa rn...@webkit.org wrote: I

Re: [webkit-dev] Simplifying syntax in test_expectations.txt (bug 86691)

2012-05-17 Thread Maciej Stachowiak
On May 17, 2012, at 1:42 PM, Ojan Vafai o...@chromium.org wrote: On Thu, May 17, 2012 at 1:37 PM, Peter Kasting pkast...@chromium.org wrote: On Thu, May 17, 2012 at 1:34 PM, Ojan Vafai o...@chromium.org wrote: 2. Make outcomes optional. If they are left out, then the test is skipped (unless

Re: [webkit-dev] Simplifying syntax in test_expectations.txt (bug 86691)

2012-05-17 Thread Maciej Stachowiak
On May 17, 2012, at 4:40 PM, Dirk Pranke dpra...@chromium.org wrote: On Thu, May 17, 2012 at 4:16 PM, Maciej Stachowiak m...@apple.com wrote: Let's take an example. TEXT next to a test name apparently means that the text fails. There is no way in the world I would guess that just from

Re: [webkit-dev] Merging Skipped and test_expectations.txt formats WAS: Simplifying syntax in test_expectations.txt (bug 86691)

2012-05-17 Thread Maciej Stachowiak
On May 17, 2012, at 7:27 PM, Ojan Vafai o...@chromium.org wrote: On Thu, May 17, 2012 at 4:29 PM, Maciej Stachowiak m...@apple.com wrote: On May 17, 2012, at 1:42 PM, Ojan Vafai o...@chromium.org wrote: On Thu, May 17, 2012 at 1:37 PM, Peter Kasting pkast...@chromium.org wrote: On Thu

Re: [webkit-dev] Simplifying syntax in test_expectations.txt (bug 86691)

2012-05-18 Thread Maciej Stachowiak
On May 17, 2012, at 5:39 PM, Dirk Pranke dpra...@chromium.org wrote: I probably polarized things by saying that your input was less valuable than those of people who were long-time users. I did not mean to offend, and I'm sorry. I certainly didn't mean to imply that I was not listening or

Re: [webkit-dev] Reconsidering test expectations (PASS, TEXT, IMAGE, TEXT+IMAGE, TIMEOUT, CRASH, etc...)

2012-05-18 Thread Maciej Stachowiak
On May 18, 2012, at 12:18 AM, Ryosuke Niwa rn...@webkit.org wrote: On Fri, May 18, 2012 at 12:05 AM, Maciej Stachowiak m...@apple.com wrote: On May 17, 2012, at 4:57 PM, Ojan Vafai o...@chromium.org wrote: Sure TEXT, IMAGE, etc are not very clear, but noone has actually proposed something

Re: [webkit-dev] Changes to window.focus/window.blur controlled by a setting?

2012-05-21 Thread Maciej Stachowiak
On May 21, 2012, at 12:16 PM, Andrew Wilson atwil...@google.com wrote: On Mon, May 21, 2012 at 2:17 AM, Jochen Eisinger joc...@chromium.org wrote: Hey, in https://bugs.webkit.org/show_bug.cgi?id=86969 I'm changing window.focus and window.blur to match Firefox's behavior: window.blur

Re: [webkit-dev] Deprecation of CSSStyleDeclaration - getPropertyShorthand method.

2012-05-21 Thread Maciej Stachowiak
, Internet Explorer). - There is no specification about it. - It was added in 2005 http://trac.webkit.org/changeset/11481. [...] This function was added by Dave Hyatt and reviewed by Maciej Stachowiak, maybe you guys can tell us why you added it back then (if your memory is very good as we

Re: [webkit-dev] Changes to window.focus/window.blur controlled by a setting?

2012-05-21 Thread Maciej Stachowiak
On May 21, 2012, at 12:24 PM, Andrew Wilson atwil...@google.com wrote: On Mon, May 21, 2012 at 12:21 PM, Maciej Stachowiak m...@apple.com wrote: On May 21, 2012, at 12:16 PM, Andrew Wilson atwil...@google.com wrote: On Mon, May 21, 2012 at 2:17 AM, Jochen Eisinger joc

Re: [webkit-dev] Importing W3C tests to webkit

2012-05-23 Thread Maciej Stachowiak
On May 23, 2012, at 2:16 PM, Dirk Pranke dpra...@chromium.org wrote: On Wed, May 23, 2012 at 1:41 PM, Ryosuke Niwa rn...@webkit.org wrote: The only sane argument I've heard so far to gate pixel tests is that the correctness of such tests need to be manually inspected, which requires a lot

Re: [webkit-dev] Importing W3C tests to webkit

2012-05-23 Thread Maciej Stachowiak
On May 23, 2012, at 3:13 PM, Dirk Pranke dpra...@chromium.org wrote: On Wed, May 23, 2012 at 2:30 PM, Maciej Stachowiak m...@apple.com wrote: Are you concerned just about the actual pixel results or also about keeping render tree dumps up to date? Both are more maintenance than a text

Re: [webkit-dev] Device and page scaling

2012-05-29 Thread Maciej Stachowiak
Can you explain why the target-densitydpi feature even exists? It seems ill-conceived to me, and the most straightforward fix would be to remove it. I have not heard anyone explain the use case for it. (I'm also not clear on the details of what it actually does, and neither the name nor the

Re: [webkit-dev] Device and page scaling

2012-05-29 Thread Maciej Stachowiak
On May 29, 2012, at 7:31 PM, Alexandre Elias ael...@chromium.org wrote: Thanks for looking into this, I like this naming scheme and Chrome for Android would be willing to switch to it. Another major semantic question is how deviceScaleFactor relates to the FrameView viewport size.

Re: [webkit-dev] Device and page scaling

2012-05-30 Thread Maciej Stachowiak
On May 30, 2012, at 4:24 PM, John Mellor joh...@chromium.org wrote: Maciej Stachowiak wrote: Can you explain why the target-densitydpi feature even exists? It seems ill-conceived to me, and the most straightforward fix would be to remove it. I have not heard anyone explain the use case

Re: [webkit-dev] We should rename layoutTestController to testController

2012-05-31 Thread Maciej Stachowiak
On May 31, 2012, at 3:11 PM, Ryosuke Niwa rn...@webkit.org wrote: On Thu, May 31, 2012 at 11:56 AM, Darin Adler da...@apple.com wrote: I am thinking we should rename layoutTestController to testController. Or if you don’t like that name, maybe testHarness or some even better name.

Re: [webkit-dev] testharness Wiki page added

2012-05-31 Thread Maciej Stachowiak
On May 31, 2012, at 2:18 PM, Jacob Goldstein jac...@adobe.com wrote: I added the following Wiki page to provide some information on testharness.js (the JavaScript framework from W3C recently landed in WebKit): http://trac.webkit.org/wiki/Writing%20testharness%20Tests I also updated the

Re: [webkit-dev] Renaming DumpRenderTree to WebKitTestRunner or merging those two

2012-06-03 Thread Maciej Stachowiak
Already done for the WebKit2 WebKitTestRunner. It should be straightforward to adapt its IDL compiler. - Maciej On Jun 2, 2012, at 11:03 PM, Adam Barth aba...@webkit.org wrote: We might also want to define the layoutTestController object with IDL so we don't have to hand-write bindings

Re: [webkit-dev] Renaming DumpRenderTree to WebKitTestRunner or merging those two

2012-06-03 Thread Maciej Stachowiak
, 2012, at 5:17 PM, Ryosuke Niwa rn...@webkit.org wrote: On Sun, Jun 3, 2012 at 1:45 PM, Maciej Stachowiak m...@apple.com wrote: Already done for the WebKit2 WebKitTestRunner. It should be straightforward to adapt its IDL compiler. I've considered adapting WebKitTestRunner's code generator

Re: [webkit-dev] Renaming DumpRenderTree to WebKitTestRunner or merging those two

2012-06-03 Thread Maciej Stachowiak
Sent from my iPad On Jun 3, 2012, at 8:05 PM, Ryosuke Niwa rn...@webkit.org wrote: On Sun, Jun 3, 2012 at 3:55 PM, Maciej Stachowiak m...@apple.com wrote: I am on vacation so I won't be able to review your patch in detail, but from your description it sounds less appealing to me than

Re: [webkit-dev] can we stop using Skipped files?

2012-06-11 Thread Maciej Stachowiak
On Jun 10, 2012, at 9:26 AM, Ojan Vafai o...@chromium.org wrote: On Sun, Jun 10, 2012 at 4:54 AM, Balazs Kelemen kbal...@webkit.org wrote: So the unit tests are superfluous. In particular, if I had to pick between only having unit tests or only having regression tests, I might pick unit

Re: [webkit-dev] DOM tree traversal on detached nodes

2012-06-11 Thread Maciej Stachowiak
On Jun 6, 2012, at 6:27 PM, Darin Adler da...@apple.com wrote: On Jun 6, 2012, at 6:14 PM, Kentaro Hara hara...@chromium.org wrote: IMHO, (a) would be the best semantics. I agree, and I think that the specification actually does require this. The real issue here is how to fix this bug

[webkit-dev] Rename of selfOnlyRef to guardRef - ok if I change it back? (was Re: DOM tree traversal on detached nodes)

2012-06-11 Thread Maciej Stachowiak
On Jun 11, 2012, at 6:06 PM, Maciej Stachowiak m...@apple.com wrote: not a self-only reference (at some point renamed to guardRef). BTW I was able to find where it was renamed but not a good explanation of why. I think selfOnlyRef() was a much clearer name. The history seems

[webkit-dev] Adding nonstandard features (was Re: Adding ENABLE_NAVIGATOR_BUILDTYPE to WebCore)

2012-06-11 Thread Maciej Stachowiak
On Jun 7, 2012, at 1:10 PM, Adam Barth aba...@webkit.org wrote: On Thu, Jun 7, 2012 at 1:00 PM, Ryosuke Niwa rn...@webkit.org wrote: On Wed, Jun 6, 2012 at 1:51 PM, Annie Sullivan sulli...@chromium.org wrote: I wanted to let you know that I plan to add support for navigator.buildType

Re: [webkit-dev] are fuzzer tests appropriate layout tests?

2012-06-13 Thread Maciej Stachowiak
On Jun 13, 2012, at 1:32 PM, Geoffrey Garen gga...@apple.com wrote: These tests regularly timeout on the Chromium debug bots and occasionally timeout on the Apple Lion bots. WebKit has a clear policy about this: Tests must be fast enough not to time out. We can fix this issue by making

Re: [webkit-dev] TestExpectations syntax changes, last call (for a while, at least) ...

2012-06-13 Thread Maciej Stachowiak
On Jun 13, 2012, at 3:58 PM, Darin Adler da...@apple.com wrote: On Jun 13, 2012, at 3:53 PM, Dirk Pranke dpra...@chromium.org wrote: * we use \ (backslash) as a delimiter instead of : and = Seems worse to me. When I see a backslash I assume it’s a line continuation character or a C

Re: [webkit-dev] TestExpectations syntax changes, last call (for a while, at least) ...

2012-06-14 Thread Maciej Stachowiak
On Jun 14, 2012, at 1:47 PM, Ryosuke Niwa rn...@webkit.org wrote: On Thu, Jun 14, 2012 at 1:44 PM, Peter Kasting pkast...@chromium.org wrote: On Thu, Jun 14, 2012 at 1:39 PM, Elliot Poger epo...@chromium.org wrote: Can someone please remind me why IMAGE+TEXT even exists? Wouldn't it be

Re: [webkit-dev] IMAGE+TEXT WAS: TestExpectations syntax changes, last call (for a while, at least) ...

2012-06-14 Thread Maciej Stachowiak
On Jun 14, 2012, at 9:06 PM, Adam Barth aba...@webkit.org wrote: On Thu, Jun 14, 2012 at 9:02 PM, Ojan Vafai o...@chromium.org wrote: Seems like it will be a common error to mark a reftest failure as ImageOnlyFail and then be confused why it's not working, no? Maybe that can be solved

Re: [webkit-dev] Rename of selfOnlyRef to guardRef - ok if I change it back? (was Re: DOM tree traversal on detached nodes)

2012-06-15 Thread Maciej Stachowiak
On Jun 15, 2012, at 12:12 AM, Roland Steiner rolandstei...@google.com wrote: Sorry for the late reply, this thread flew under my radar. I made the original name change, because I honestly was entirely confused about the meaning of selfOnlyRef (it's done by Node on Document, so what is

Re: [webkit-dev] Rename of selfOnlyRef to guardRef - ok if I change it back? (was Re: DOM tree traversal on detached nodes)

2012-06-15 Thread Maciej Stachowiak
On Jun 15, 2012, at 10:31 AM, Darin Adler da...@apple.com wrote: On Jun 15, 2012, at 10:15 AM, Maciej Stachowiak m...@apple.com wrote: But it's hard to explain fully in a function name w/o excess verbosity. I think my favorite excess verbosity version is refDocumentButNotOtherNodes

Re: [webkit-dev] Rename of selfOnlyRef to guardRef - ok if I change it back? (was Re: DOM tree traversal on detached nodes)

2012-06-15 Thread Maciej Stachowiak
On Jun 15, 2012, at 12:22 PM, Ryosuke Niwa rn...@webkit.org wrote: On Fri, Jun 15, 2012 at 12:14 PM, Maciej Stachowiak m...@apple.com wrote: I am not sure how to get the key points across without being accurate or misleading. A version that I think explains the complete design without

Re: [webkit-dev] SH4, MIPS, and legacy-ARM assemblers in JavaScriptCore

2012-06-22 Thread Maciej Stachowiak
Is there a way to reduce these costs other than deleting the slower-maintained JITs? For example, could we temporarily freeze the JIT (perhaps the whole JSC engine somehow) at old versions somehow for architectures that may take time to catch up? Regards, Maciej On Jun 22, 2012, at 10:52 AM,

Re: [webkit-dev] DOM tree traversal on detached nodes

2012-06-27 Thread Maciej Stachowiak
From your design document, it sounds like this approach retains guardRef/selfOnlyRef, and will not let a disconnected subtree keep the owner document's children alive. Am I understanding correctly? - Maciej On Jun 27, 2012, at 5:55 AM, Kentaro Hara hara...@chromium.org wrote: I wrote a

Re: [webkit-dev] Feature announcement: webkit-patch patches-to-review

2012-06-28 Thread Maciej Stachowiak
On Jun 28, 2012, at 6:44 AM, Thiago Marcos P. Santos tmpsan...@gmail.com wrote: Hi WebKit, webkit-patch patches-to-review was reworked [1] and now, instead of giving you the list of attachment ID of all the patches pending review, it will give you the list of bugs + description + age of

[webkit-dev] Class-level comments in the source code

2012-07-06 Thread Maciej Stachowiak
Starting a new thread, since this has wandered a fair bit off topic (and Eric had a good point that it's kind of a threadjack). On Jul 6, 2012, at 12:54 PM, Per Bothner per.both...@oracle.com wrote: The biggest annoyance I found is lack of class-level comments. For example what is an

Re: [webkit-dev] Class-level comments in the source code

2012-07-06 Thread Maciej Stachowiak
*is* and (preferably) how it relates to other objects. For some classes, yes. On Fri, Jul 6, 2012 at 2:02 PM, Maciej Stachowiak m...@apple.com wrote: On Jul 6, 2012, at 12:54 PM, Per Bothner per.both...@oracle.com wrote: The biggest annoyance I found is lack of class-level comments. For example what

Re: [webkit-dev] Class-level comments in the source code

2012-07-06 Thread Maciej Stachowiak
On Jul 6, 2012, at 2:37 PM, Per Bothner per.both...@oracle.com wrote: On 07/06/2012 02:02 PM, Maciej Stachowiak wrote: [... reasonable stuff I fully agree with - but one question ...] Documenting ownership and lifetime relationships is also useful. We have tended to do that as diagrams

Re: [webkit-dev] Parallel image decoders are up for review

2012-07-09 Thread Maciej Stachowiak
On Jul 9, 2012, at 1:30 AM, KwangYul Seo sk...@company100.net wrote: Hi, Our team at Company 100 has worked on parallel image decoders for past a few weeks and some patches are pending for review now. Here is the master bug for parallel image decoders:

Re: [webkit-dev] Comments in the code (Was Please include function-level comments in change log entries)

2012-07-12 Thread Maciej Stachowiak
On Jul 12, 2012, at 6:50 AM, John Mellor joh...@chromium.org wrote: To take an arbitrary example, lets say that while iterating through a ListHashSet something causes entries to be deleted. Intuitively it seems this needn't invalidate the iterator, as long as the entry the iterator is

Re: [webkit-dev] Comments in the code (Was Please include function-level comments in change log entries)

2012-07-12 Thread Maciej Stachowiak
On Jul 12, 2012, at 1:47 PM, Stephen Chenney schen...@chromium.org wrote: On Thu, Jul 12, 2012 at 3:44 PM, Dirk Pranke dpra...@chromium.org wrote: On Thu, Jul 12, 2012 at 10:53 AM, Ryosuke Niwa rn...@webkit.org wrote: On Thu, Jul 12, 2012 at 10:43 AM, Stephen Chenney

Re: [webkit-dev] Comments in the code (Was Please include function-level comments in change log entries)

2012-07-13 Thread Maciej Stachowiak
On Jul 13, 2012, at 5:57 AM, Stephen Chenney schen...@chromium.org wrote: I'd be happy to add a term to the cost function: Cost per year with good comments: t_maintainComments * n_patches + t_understandWithComment * n_engineersNeedingToUnderstand + t_discoverAndFixBadCommend *

Re: [webkit-dev] Comments in the code (Was Please include function-level comments in change log entries)

2012-07-13 Thread Maciej Stachowiak
On Jul 13, 2012, at 11:03 AM, Dana Jansens dan...@chromium.org wrote: On Fri, Jul 13, 2012 at 1:56 PM, Ryosuke Niwa rn...@webkit.org wrote: On Fri, Jul 13, 2012 at 5:57 AM, Stephen Chenney schen...@chromium.org wrote: I don't doubt there are poor comments, both outdated and useless.

Re: [webkit-dev] Comments in the code (Was Please include function-level comments in change log entries)

2012-07-13 Thread Maciej Stachowiak
On Jul 13, 2012, at 11:13 AM, Alec Flett alecfl...@chromium.org wrote: And yes while incorrect behavior can be observed through automated testing, automated testing does not catch all incorrect behavior, especially unexpected never-before-seen behavior. Why do you think people write

Re: [webkit-dev] Easing printf based debugging in WebKit with an helper.

2012-07-19 Thread Maciej Stachowiak
On Jul 19, 2012, at 11:01 AM, Oliver Buchtala oliver.bucht...@googlemail.com wrote: Hi, I am probably one of those people who much dislike printf-debugging. What is your problem with using a debugger? Maybe because the displayed information is not appropriate? E.g., you would like

Re: [webkit-dev] Easing printf based debugging in WebKit with an helper.

2012-07-19 Thread Maciej Stachowiak
On Jul 10, 2012, at 8:52 AM, Brady Eidson beid...@apple.com wrote: On Jul 10, 2012, at 5:25 AM, Alexis Menard alexis.men...@openbossa.org wrote: On Mon, Jul 9, 2012 at 6:53 PM, Brady Eidson beid...@apple.com wrote: On Jul 9, 2012, at 2:43 PM, Alexis Menard alexis.men...@openbossa.org

Re: [webkit-dev] WebKit memory instrumentation

2012-07-23 Thread Maciej Stachowiak
On Jul 23, 2012, at 8:09 AM, Yury Semikhatsky yu...@chromium.org wrote: First option we consider is to define a class with the same set of fields as the instrumented one, then have a compile time assert that size of the reference class equals to the size of the instrumented one. See

Re: [webkit-dev] WebKit memory instrumentation

2012-07-24 Thread Maciej Stachowiak
On Jul 24, 2012, at 12:39 AM, Yury Semikhatsky yu...@chromium.org wrote: On Tue, Jul 24, 2012 at 12:47 AM, Maciej Stachowiak m...@apple.com wrote: On Jul 23, 2012, at 8:09 AM, Yury Semikhatsky yu...@chromium.org wrote: First option we consider is to define a class with the same

Re: [webkit-dev] WebKit memory instrumentation

2012-07-25 Thread Maciej Stachowiak
On Jul 25, 2012, at 2:08 AM, Yury Semikhatsky yu...@chromium.org wrote: On Tue, Jul 24, 2012 at 10:34 PM, Maciej Stachowiak m...@apple.com wrote: On Jul 24, 2012, at 12:39 AM, Yury Semikhatsky yu...@chromium.org wrote: On Tue, Jul 24, 2012 at 12:47 AM, Maciej Stachowiak m

Re: [webkit-dev] Enable MICRODATA feature by default

2012-07-31 Thread Maciej Stachowiak
Has anything been done to verify security and stability of the feature, for example, fuzz testing? I'd like to request that before enabling for Apple's ports. - Maciej On Jul 30, 2012, at 11:35 PM, Arko Saha ngh...@motorola.com wrote: I am planning to enable MICRODATA feature by default in

Re: [webkit-dev] Add support for CSS3 text-decoration* properties

2012-08-01 Thread Maciej Stachowiak
On Aug 1, 2012, at 4:36 PM, Elliott Sprehn espr...@chromium.org wrote: On Tue, Jul 31, 2012 at 7:35 PM, Bruno Abinader brunoabina...@gmail.com wrote: Hi all :) As suggested by Ojan, I am writing a mail to you about my intention to implement all updated and missing text-decoration*

Re: [webkit-dev] We should encourage the use of httpS://svn.webkit.org

2012-08-09 Thread Maciej Stachowiak
On Aug 8, 2012, at 5:41 PM, Ryosuke Niwa rn...@webkit.org wrote: Hi, It appears that we recommend the use of non-secure HTTP connection on many webkit.org documents: e.g. https://www.webkit.org/building/checkout.html Can we move away from this and recommend the use of HTTPS instead?

Re: [webkit-dev] Status of multithreaded image decoding

2012-08-12 Thread Maciej Stachowiak
On Aug 10, 2012, at 3:47 PM, Alpha Lam hc...@chromium.org wrote: This is a very valid concern. The question you raised is one topic I want to discuss more broadly. Chromium has a separate rasterization stage so there is some time for decoders to work, synchronization can happen in

Re: [webkit-dev] Status of multithreaded image decoding

2012-08-12 Thread Maciej Stachowiak
, Aug 12, 2012 at 1:24 PM, Maciej Stachowiak m...@apple.com wrote: Why not start asynchronous decoding immediately as the image is loading, and synchronize at paint time? What is the benefit of waiting until layout time to start decoding the image data? Uninformed guess (since I haven't

Re: [webkit-dev] Status of multithreaded image decoding

2012-08-13 Thread Maciej Stachowiak
: https://bugs.webkit.org/show_bug.cgi?id=90375#c80 In the above link, Hin-Chung shows how to determine whether an image is actually painted. 2012/8/13 Maciej Stachowiak m...@apple.com: I that case, starting async decoding at layout time makes sense if and only if at layout to e you can

Re: [webkit-dev] Status of multithreaded image decoding

2012-08-13 Thread Maciej Stachowiak
images in the viewport. Alpha 2012/8/13 Maciej Stachowiak m...@apple.com The thing I'm not confident of is whether an image's position in absolute coordinates can be changed by an ancestor after RenderImage::layout completes. It would be helpful if a layout expert would weigh

Re: [webkit-dev] A proposal for handling failing layout tests and TestExpectations

2012-08-15 Thread Maciej Stachowiak
On Aug 15, 2012, at 12:27 PM, Filip Pizlo fpi...@apple.com wrote: This sounds like it's adding even more complication to an already complicated system. Given how many tests we currently have, I also don't buy that continuing to run a test that is already known to fail provides much

Re: [webkit-dev] A simpler proposal for handling failing tests WAS: A proposal for handling failing layout tests and TestExpectations

2012-08-17 Thread Maciej Stachowiak
My understanding of the current proposal is this: 1) This applies to tests that fail deterministically, for reasons other than a crash or hang. 2) If the test has a new result that you're confident is a progression (or neither better or worse), you simply update the -expected.txt file. 3) If

Re: [webkit-dev] A simpler proposal for handling failing tests WAS: A proposal for handling failing layout tests and TestExpectations

2012-08-18 Thread Maciej Stachowiak
On Aug 18, 2012, at 1:08 AM, Filip Pizlo fpi...@apple.com wrote: I like your idea of having both the result-we-currently-expect and the result-we-think-may-be-more-correct to be checked in. I still prefer Dirk's naming scheme though. I think if we had both checked in, the

Re: [webkit-dev] A simpler proposal for handling failing tests WAS: A proposal for handling failing layout tests and TestExpectations

2012-08-18 Thread Maciej Stachowiak
to -expected-failure/-unexpected-pass as a naming scheme, along with the approach of keeping both around when they are used? Regards, Maciej -Filip On Aug 18, 2012, at 2:01 PM, Maciej Stachowiak m...@apple.com wrote: On Aug 18, 2012, at 1:08 AM, Filip Pizlo fpi...@apple.com wrote: I like your

Re: [webkit-dev] A simpler proposal for handling failing tests WAS: A proposal for handling failing layout tests and TestExpectations

2012-08-21 Thread Maciej Stachowiak
On Aug 21, 2012, at 3:23 PM, Ojan Vafai o...@chromium.org wrote: On Mon, Aug 20, 2012 at 6:03 PM, Maciej Stachowiak m...@apple.com wrote: Here's how I imagine the workflow when a sheriff or just innocent bystander notices a deterministically failing test. Follow this two-step algorithm: 1

Re: [webkit-dev] Initializing String and AtomicString with literals

2012-08-24 Thread Maciej Stachowiak
What's the difference between the ASCIILiteral and ConstructFromLiteral versions? - Maciej On Aug 24, 2012, at 8:00 PM, Benjamin Poulain benja...@webkit.org wrote: Dear webkit-dev, Some recent changes improved the way we can use string classes with literals. There are 3 new

Re: [webkit-dev] Is the New XMLParser dead?

2012-08-27 Thread Maciej Stachowiak
to be had without breaking WebVTT? If so, we can think about whether removing the scaffolding and reconstructing it when needed is worthwhile. - Maciej On Thu, Mar 15, 2012 at 1:58 PM, Maciej Stachowiak m...@apple.com wrote: On Mar 15, 2012, at 1:29 PM, Eric Seidel wrote: It seems

Re: [webkit-dev] Is the New XMLParser dead?

2012-08-27 Thread Maciej Stachowiak
On Aug 27, 2012, at 3:48 PM, Adam Barth aba...@webkit.org wrote: On Mon, Aug 27, 2012 at 3:06 PM, Maciej Stachowiak m...@apple.com wrote: On Aug 27, 2012, at 2:45 PM, Eric Seidel e...@webkit.org wrote: Checking back in: Curious if this effort is still underway. Adam and I would like

<    5   6   7   8   9   10   11   12   13   14   >