Re: [webkit-dev] MathML Refresh Heads up

2019-03-15 Thread Maciej Stachowiak
> On Mar 15, 2019, at 3:33 PM, Frédéric Wang wrote: > > Hi Ryosuke and Myles, > > Thank you for your reply. First, the exact thing about what will be in MathML > Core is still open, people are welcome to join and participate to the MathML > CG [1] or comment on the GitHub tracker [2]. > >

Re: [webkit-dev] Filtering results on wpt.fyi, Safari-specific failures

2019-02-25 Thread Maciej Stachowiak
ental=chrome%5Btaskcluster%5D=firefox%5Btaskcluster%5D=safari%5Bazure%5D> > There’s definitely lots of failures that look legit. > > On Mon, Feb 25, 2019 at 8:31 PM Maciej Stachowiak <mailto:m...@apple.com>> wrote: > > Neat. > > I see some obvious areas for foc

Re: [webkit-dev] Filtering results on wpt.fyi, Safari-specific failures

2019-02-25 Thread Maciej Stachowiak
Neat. I see some obvious areas for focus, where Safari fails lots of tests that the other browser don’t. For context, I tried looking at this view, which shows all tests that Safari and Firefox pass with Safari results regardless of result:

Re: [webkit-dev] Code Style: Opinion on returning void

2019-02-20 Thread Maciej Stachowiak
It seems like `return foo();` where foo() is a void function can always be replaced with `foo(); return;` for greater clarity at the cost of one extra line break. For people who prefer the one-line style, can you say why you don’t like the other way? - Maciej > On Feb 20, 2019, at 10:33 AM,

Re: [webkit-dev] Moving to Git

2019-02-20 Thread Maciej Stachowiak
> On Feb 20, 2019, at 12:14 PM, Michael Catanzaro wrote: > > FWIW, it's not hard to enforce fast-forward merges with a git hook; that way, > we can guarantee that the history has no merge commits and is fully linear. > GitLab has built-in support to enforce this for merge requests (though

Re: [webkit-dev] Experimental features review

2019-02-14 Thread Maciej Stachowiak
> On Feb 14, 2019, at 9:01 AM, Michael Catanzaro wrote: > > On Wed, Feb 13, 2019 at 9:16 PM, Simon Fraser wrote: >> For these two, we now have them on by default because we think they are >> ready to ship. They still exist as experimental features so that people can >> turn them off for

Re: [webkit-dev] Exciting JS features (class fields) in need of review :)

2019-02-14 Thread Maciej Stachowiak
you haven’t gotten more active review, and I am glad that Saam is now giving you another review pass. Cheers, Maciej > > Cheers, > Xan > > On Thu, Feb 14, 2019 at 8:47 AM Maciej Stachowiak <mailto:m...@apple.com>> wrote: > > I left the boring review feed

Re: [webkit-dev] Exciting JS features (class fields) in need of review :)

2019-02-13 Thread Maciej Stachowiak
I left the boring review feedback that this work should be behind a feature flag. Mentioning it here because this may apply to other feature patches you have in progress. (I am not qualified to review the substance of what the patch is doing.) > On Feb 13, 2019, at 1:51 PM, ca...@igalia.com

Re: [webkit-dev] Rename Bugzilla's "WebKit2" component to "WebKit Process Model"

2019-02-06 Thread Maciej Stachowiak
> On Feb 6, 2019, at 9:48 AM, Lucas Forschler wrote: > > Thanks Ryosuke, > > I’d be in favor of adding a Bugzilla component “WebKit Process Model” > I believe Simon has also asked for a WKWebView component. (WKWebView > viewport/tiling/animated resize issues) > > Would the two of these

Re: [webkit-dev] Rename Bugzilla component "ANGLE" to "WebGL"

2019-02-01 Thread Maciej Stachowiak
ANGLE is a separate chunk of code, and one the we periodically sync with an upstream repository, so I am not sure this is a good idea. > On Feb 1, 2019, at 10:59 AM, Lucas Forschler wrote: > > I just realized we already have a WebGL Bugzilla component. So I propose > deprecating the ANGLE

Re: [webkit-dev] Rename Bugzilla Component "Media Elements" to "Media"

2019-02-01 Thread Maciej Stachowiak
Sounds good to me. > On Feb 1, 2019, at 10:52 AM, Lucas Forschler wrote: > > Hello all, > > I propose renaming the Bugzilla component “Media Elements” to “Media”. > > Are there any objections or concerns with this rename? > > Thanks, > Lucas > ___

Re: [webkit-dev] Compile error in WebGL2RenderingContext.cpp

2019-01-17 Thread Maciej Stachowiak
> On Jan 17, 2019, at 10:15 AM, Michael Catanzaro wrote: > > > > On Thu, Jan 17, 2019 at 11:12 AM, Darin Adler wrote: >> Vector’s inline capacity feature was originally created as an alternative to >> variable length arrays for most of the purposes people would want to put >> them. > >

Re: [webkit-dev] the name "AtomicString"

2018-12-20 Thread Maciej Stachowiak
> On Dec 20, 2018, at 11:24 AM, Geoffrey Garen wrote: > So hard to pronounce though! Why not UniqueString? It’s not quite as explicit but close enough. >>> >>> Wouldn’t it be confusing to use UniqueString type for a string that is >>> *common* in order to save memory? >> >> I

Re: [webkit-dev] the name "AtomicString"

2018-12-20 Thread Maciej Stachowiak
> On Dec 19, 2018, at 9:41 PM, Chris Dumez wrote: > >> >> On Dec 19, 2018, at 9:17 PM, Maciej Stachowiak > <mailto:m...@apple.com>> wrote: >> >> >> >>> On Dec 19, 2018, at 8:06 PM, Ryosuke Niwa >> <mailto:rn...@webkit.

Re: [webkit-dev] the name "AtomicString"

2018-12-19 Thread Maciej Stachowiak
> On Dec 19, 2018, at 8:06 PM, Ryosuke Niwa wrote: > > On Wed, Dec 19, 2018 at 1:13 PM Simon Fraser > wrote: > > On Dec 19, 2018, at 12:33 PM, Michael Catanzaro > > wrote: > > > > On Tue, Dec 18, 2018 at 9:31 PM, Darin Adler >

Re: [webkit-dev] Hash table empty value

2018-12-19 Thread Maciej Stachowiak
> On Dec 19, 2018, at 12:54 PM, Michael Catanzaro wrote: > > On Tue, Dec 18, 2018 at 2:31 PM, Ryosuke Niwa wrote: >> I tend to agree but then we'd come up with other numbers for the empty & >> deleted values. >> I've been thinking that we could use -1 and -2 but that's also somewhat >>

Re: [webkit-dev] the name "AtomicString"

2018-12-19 Thread Maciej Stachowiak
> On Dec 19, 2018, at 12:33 PM, Michael Catanzaro wrote: > > On Tue, Dec 18, 2018 at 9:31 PM, Darin Adler wrote: >> I’ve gotten used to the name AtomicString over the years, but I wouldn’t >> strongly object to changing it if other programmers are often confused by >> it’s similarity to the

Re: [webkit-dev] Watch out for std::optional's move constructor

2018-12-17 Thread Maciej Stachowiak
Right now, after a maybeMove type call on std::optional, you get either the original value, or a value that is officially valid but unspecified, and actually an optional that says it contains a value but doesn’t. With Chris’s proposal, you’d get a WTF::Optional with either the original value,

Re: [webkit-dev] Watch out for std::optional's move constructor

2018-12-16 Thread Maciej Stachowiak
> On Dec 16, 2018, at 8:37 PM, Chris Dumez wrote: > > >> On Dec 16, 2018, at 7:43 PM, Fujii Hironori wrote: >> >> I don't like the proposal because it encourages misuse of move. >> We can use move only for values about to be destroyed. > > Just for reference, there are close to 400 matches

Re: [webkit-dev] Watch out for std::optional's move constructor

2018-12-16 Thread Maciej Stachowiak
> On Dec 16, 2018, at 3:47 PM, Daniel Bates wrote: > > > >> On Dec 14, 2018, at 3:52 PM, Chris Dumez > > wrote: >> >> So to be clear, it is often not truly about using the value after it is >> moved. It is about expecting that the variable / member has been nulled

Re: [webkit-dev] Proposal for Device-Specific Layout Tests

2018-12-12 Thread Maciej Stachowiak
> On Dec 12, 2018, at 2:20 PM, Jonathan Bedard wrote: > >> >> On Dec 12, 2018, at 11:16 AM, Maciej Stachowiak > <mailto:m...@apple.com>> wrote: >> >> >> >>> On Dec 12, 2018, at 10:07 AM, Jonathan Bedard >> <mailto:jbed...@

Re: [webkit-dev] Proposal for Device-Specific Layout Tests

2018-12-12 Thread Maciej Stachowiak
> On Dec 12, 2018, at 10:07 AM, Jonathan Bedard wrote: > > Ryosuke and I discussed this on Monday, and in passing, Ryosuke mentioned > that he personally finds something like this: > > .html > -expected.txt > -expected-.txt > > more clear than the directory method I

Re: [webkit-dev] Unified sources have broken our #include hygiene

2018-09-13 Thread Maciej Stachowiak
> On Sep 13, 2018, at 3:49 AM, Frédéric Wang wrote: > > Hi, > > I've recently found two non-trivial issues with unified builds. They are > not missing #include but instead conflicts between C++ files: > > - Two C++ files including the same header but with a #define directive > set to

Re: [webkit-dev] Freenode spam counter-measure

2018-08-05 Thread Maciej Stachowiak
gt; But ChanServ replied: >> >>ChanServ: You are not authorized to perform this command. >> >> I wonder who is authorized!? > > Looks like the authorized people include Maciej Stachowiak and Timothy > Hatcher. >

Re: [webkit-dev] wpt survey

2018-06-20 Thread Maciej Stachowiak
Hello WebKit folks, You may be interested in this survey about Web Platform Tests. > -- Forwarded message -- > From: Simon Pieters mailto:si...@bocoup.com>> > Date: Tue, Jun 19, 2018 at 10:21 AM > Subject: Re: wpt survey > To: Jory Burson mailto:j...@bocoup.com>> > Cc: Philip

Re: [webkit-dev] Tips to build faster on Mac?

2018-03-16 Thread Maciej Stachowiak
You can also just cd to the WebCore directory and type make. > On Mar 16, 2018, at 3:24 PM, youenn fablet wrote: > > If you have a full build and made changes to WebCore, you might only need to > recompile WebCore. With make for instance, one can do: > make d -C

Re: [webkit-dev] HSTS user tracking

2018-03-01 Thread Maciej Stachowiak
> On Mar 1, 2018, at 10:44 AM, Michael Catanzaro wrote: > > On Fri, Jan 5, 2018 at 3:11 PM, Brent Fulgham wrote: >> I´m sorry we haven´t been forthcoming with details. We have wanted to put >> together a blog post explaining our fix, but have been

Re: [webkit-dev] OWNERS policy

2018-02-22 Thread Maciej Stachowiak
> On Feb 21, 2018, at 11:06 PM, Carlos Garcia Campos > wrote: > > El mié, 21-02-2018 a las 13:49 -0800, Ryosuke Niwa escribió: >> If there was any confusion, WebKit2 Owner's policy is still active >> and in effect. > > And maybe it's time to get rid of it? I never liked

Re: [webkit-dev] Buildbot upgrade on build.webkit.org

2018-01-08 Thread Maciej Stachowiak
> On Jan 8, 2018, at 1:33 PM, Aakash Jain wrote: > > Hi Everyone, > > I filed the Buildbot bug regarding Waterfall view not displaying steps > information by default: https://github.com/buildbot/buildbot/issues/3884 >

Re: [webkit-dev] HSTS user tracking

2018-01-05 Thread Maciej Stachowiak
Brent Fulgham or John Wilander would know the details. - Maciej > On Jan 5, 2018, at 8:04 AM, Michael Catanzaro wrote: > > > Hi devs, > > Any info about how to mitigate this problem would be appreciated. Thanks! > > Michael > >

Re: [webkit-dev] Hosting precompiled `jsc` binaries for Linux

2017-12-12 Thread Maciej Stachowiak
> <https://github.com/v8/v8/wiki/Handling-of-Ports> > > Or the MIPS version of NaCl? > > I agree this is the same. If I was building an installer that included these > ports, I’d prefer to get the downloads through Google/V8 too, if possible. > > On Tue, Dec 12,

Re: [webkit-dev] Hosting precompiled `jsc` binaries for Linux

2017-12-12 Thread Maciej Stachowiak
> On Dec 12, 2017, at 11:42 AM, Mathias Bynens wrote: > > On Tue, Dec 12, 2017 at 8:38 PM, JF Bastien > wrote: > > On Tue, Dec 12, 2017 at 11:27 AM Mathias Bynens > wrote: > Ideally,

Re: [webkit-dev] Upstreaming from LayoutTests to web-platform-tests, coordinating Blink+WebKit

2017-11-17 Thread Maciej Stachowiak
> On Nov 17, 2017, at 7:53 AM, Frédéric WANG <fred.w...@free.fr> wrote: > > On 17/11/2017 16:26, Maciej Stachowiak wrote: >> WebKit has a lot of tests that were regression tests for a specific >> bug fix, not as conformance tests (though they might b useful for

Re: [webkit-dev] Upstreaming from LayoutTests to web-platform-tests, coordinating Blink+WebKit

2017-11-17 Thread Maciej Stachowiak
> On Nov 17, 2017, at 7:05 AM, Frédéric WANG wrote: > > Hi Philip, > > We (at Igalia) are strong supporters of WPT tests and we've appreciated a lot > the effort made by Youenn and others to make them possible in WebKit. They > are very important for interoperability and

Re: [webkit-dev] Upstreaming from LayoutTests to web-platform-tests, coordinating Blink+WebKit

2017-11-17 Thread Maciej Stachowiak
> On Nov 17, 2017, at 7:15 AM, Konstantin Tokarev wrote: > > > > 16.11.2017, 20:10, "Alexey Proskuryakov" : >> Migrating WebKit tests seems undesirable to me, as that would make us lose >> all their modification history. As mentioned before, WPT tests are

Re: [webkit-dev] Formatting style for inline comments in Python code

2017-11-03 Thread Maciej Stachowiak
> On Nov 3, 2017, at 8:59 AM, Aakash Jain <aakash_j...@apple.com> wrote: > > > >> On Nov 2, 2017, at 8:45 PM, Maciej Stachowiak <m...@apple.com >> <mailto:m...@apple.com>> wrote: >> >> >> >>> On Nov 2, 2017, at 5:41 PM,

Re: [webkit-dev] Formatting style for inline comments in Python code

2017-11-02 Thread Maciej Stachowiak
> On Nov 2, 2017, at 5:41 PM, Aakash Jain <aakash_j...@apple.com> wrote: > > > >> On Oct 26, 2017, at 10:21 AM, Maciej Stachowiak <m...@apple.com >> <mailto:m...@apple.com>> wrote: >> >> >> >>> On Oct 26, 2017, at

Re: [webkit-dev] Formatting style for inline comments in Python code

2017-10-26 Thread Maciej Stachowiak
> On Oct 26, 2017, at 10:20 AM, Eric Carlson wrote: > > > >> On Oct 26, 2017, at 9:50 AM, Brian Burg > > wrote: >> >> >> >>> 2017/10/26 午前9:21、Alexey Proskuryakov >> >のメール: >>>

Re: [webkit-dev] Proposal: Remove ENABLE(MATHML)

2017-10-25 Thread Maciej Stachowiak
> On Oct 25, 2017, at 1:44 AM, Frédéric WANG <fred.w...@free.fr> wrote: > > On 24/10/2017 18:50, Maciej Stachowiak wrote: >> I don't have a strong opinion on whether we should support disabling >> MathML. My point is just that if we support disabling it, it sh

Re: [webkit-dev] Proposal: Remove ENABLE(MATHML)

2017-10-24 Thread Maciej Stachowiak
> On Oct 24, 2017, at 12:14 AM, Frédéric WANG <fred.w...@free.fr> wrote: > > On 23/10/2017 18:11, Maciej Stachowiak wrote: >> >> Is there any way we can convert MathML to a runtime switch? It seems >> like the main consideration is rendering quality given ava

Re: [webkit-dev] Proposal: Remove ENABLE(MATHML)

2017-10-23 Thread Maciej Stachowiak
> On Oct 23, 2017, at 9:04 AM, Konstantin Tokarev wrote: > > > > 23.10.2017, 18:43, "Frédéric WANG" >: >> Hi, >> >> There have been some discussions recently on >> https://bugs.webkit.org/show_bug.cgi?id=177744 regarding the

Re: [webkit-dev] Forward.h's Vector

2017-09-13 Thread Maciej Stachowiak
> On Sep 13, 2017, at 8:11 AM, JF Bastien wrote: > > Hello WebCritters, > > I’m moving some code around, and one particular header I have is included > everywhere in JSC so I’d like it to be lightweight and include as few other > headers as possible. It unfortunately

Re: [webkit-dev] Remove Credential Management code

2017-09-06 Thread Maciej Stachowiak
Apple's WebKit team is still interested in Credential Management. - Maciej > On Sep 6, 2017, at 9:29 AM, Sam Weinig wrote: > > Hey gang, > > I’d like to propose removing the Credential Management code from WebCore. > Work began on supporting this spec in January of this

Re: [webkit-dev] Get rid of RefPtr, replace with std::optional?

2017-09-01 Thread Maciej Stachowiak
> On Sep 1, 2017, at 10:07 AM, Brady Eidson <beid...@apple.com> wrote: > > > >> On Sep 1, 2017, at 9:46 AM, Maciej Stachowiak <m...@apple.com> wrote: >>> >>> Does RefPtr do anything for us today that std::optional doesn’t? >> &

Re: [webkit-dev] Get rid of RefPtr, replace with std::optional?

2017-09-01 Thread Maciej Stachowiak
> On Sep 1, 2017, at 9:30 AM, Brady Eidson wrote: > > I recently worked on a patch where - because of the organic refactoring of > the patch over its development - I ended up with a std::optional instead > of a RefPtr. > > A followup review after it had already landed

Re: [webkit-dev] Growing tired of long build times? Check out this awesome new way to speed up your build... soon (HINT: It's not buying a new computer)

2017-08-30 Thread Maciej Stachowiak
> On Aug 30, 2017, at 2:15 AM, Konstantin Tokarev wrote: > > > > 30.08.2017, 03:01, "Michael Catanzaro" : >> On Tue, Aug 29, 2017 at 6:20 PM, Alicia Boya García >> wrote: >>> As long as the sets are generated consistently that

Re: [webkit-dev] Growing tired of long build times? Check out this awesome new way to speed up your build... soon (HINT: It's not buying a new computer)

2017-08-29 Thread Maciej Stachowiak
> On Aug 29, 2017, at 6:40 PM, Sam Weinig <wei...@apple.com> wrote: > > > >> On Aug 29, 2017, at 6:36 PM, Maciej Stachowiak <m...@apple.com >> <mailto:m...@apple.com>> wrote: >> >> >> >>> On Aug 29, 2017, at 5:54 P

Re: [webkit-dev] Growing tired of long build times? Check out this awesome new way to speed up your build... soon (HINT: It's not buying a new computer)

2017-08-29 Thread Maciej Stachowiak
> On Aug 29, 2017, at 5:54 PM, Sam Weinig wrote: > > > >> On Aug 29, 2017, at 12:46 PM, Geoffrey Garen > > wrote: >> >>> This isn’t the scenario I find myself in most often. A much more common >>> scenario is working on a

Re: [webkit-dev] Unified source builds: A new rule for static variables

2017-08-29 Thread Maciej Stachowiak
> On Aug 29, 2017, at 11:31 AM, Darin Adler wrote: > > Sent from my iPhone > >> On Aug 29, 2017, at 11:22 AM, Keith Miller wrote: >> >> I doubt anyone is going to run such a script before they go to upload a >> patch to bugzilla. > > EWS was what

Re: [webkit-dev] Growing tired of long build times? Check out this awesome new way to speed up your build... soon (HINT: It's not buying a new computer)

2017-08-29 Thread Maciej Stachowiak
> On Aug 29, 2017, at 9:10 AM, Chris Dumez wrote: > > I worry about adopting unity build because while it makes clean builds > faster, it also slows down incremental builds. As a developer, I rarely do > clean builds, I mostly do incremental builds so this would likely make

Re: [webkit-dev] Growing tired of long build times? Check out this awesome new way to speed up your build... soon (HINT: It's not buying a new computer)

2017-08-28 Thread Maciej Stachowiak
> On Aug 28, 2017, at 9:20 PM, Daniel Bates wrote: > > Thank you for looking into speeding up the build. > > How does the speed gain with your proposed "unified source" approach compare > to using CMake + Ninja to build currently (I think builder Apple El Capitan > CMake

Re: [webkit-dev] CSS Typed OM

2017-08-21 Thread Maciej Stachowiak
I don't have a strong opinion on the spec itself, but I'd like to encourage you to do it using a runtime flag as recommend by the feature policy. - Maciej > On Aug 18, 2017, at 12:44 PM, Olmstead, Don wrote: >

Re: [webkit-dev] WEB_TIMING enabled on all ports - let's remove the flag?

2017-08-02 Thread Maciej Stachowiak
> On Aug 2, 2017, at 2:18 AM, Ryosuke Niwa wrote: > > On Tue, Aug 1, 2017 at 10:41 PM, Adrien Destugues > wrote: >>> Some others I see: >>> >>> ENABLE_GEOLOCATION >>> ENABLE_INDEXED_DATABASE >>> ENABLE_CSS_SCROLL_SNAP >>> ENABLE_WEBGL >>>

Re: [webkit-dev] WebVR on WebKit

2017-08-02 Thread Maciej Stachowiak
Though WebVR is not the most elegant API for VR, it's a least common denominator, and it seems like other browsers are on board. So I think it's worth at least experimenting with. (Other opinions may vary; this is just my personal view not an Official Apple Position or anything). I'm guessing

Re: [webkit-dev] Removing support for CSS regions

2017-08-02 Thread Maciej Stachowiak
> On Aug 2, 2017, at 2:40 AM, Andreas Kling wrote: > >> >> On 2 Aug 2017, at 01:03, Ryosuke Niwa wrote: >> >> On Mon, Jul 31, 2017 at 1:49 AM, Andreas Kling wrote: >>> Some time has passed, and it seems that adoption of CSS regions on

Re: [webkit-dev] WEB_TIMING enabled on all ports - let's remove the flag?

2017-08-01 Thread Maciej Stachowiak
> On Aug 1, 2017, at 6:55 PM, Adrian Perez de Castro <ape...@igalia.com> wrote: > > Hello, > > On Tue, 01 Aug 2017 18:11:53 -0400, Maciej Stachowiak <m...@apple.com > <mailto:m...@apple.com>> wrote: > >>> On Aug 1, 2017, at 5:55

Re: [webkit-dev] WEB_TIMING enabled on all ports - let's remove the flag?

2017-08-01 Thread Maciej Stachowiak
> On Aug 1, 2017, at 6:32 PM, Konstantin Tokarev <annu...@yandex.ru> wrote: > > > > 02.08.2017, 01:12, "Maciej Stachowiak" <m...@apple.com > <mailto:m...@apple.com>>: >>> On Aug 1, 2017, at 5:55 PM, Konstantin Tokarev <annu...@yandex

Re: [webkit-dev] WEB_TIMING enabled on all ports - let's remove the flag?

2017-08-01 Thread Maciej Stachowiak
> On Aug 1, 2017, at 5:55 PM, Konstantin Tokarev wrote: > > > > 02.08.2017, 00:49, "Sam Weinig" : >>> On Aug 1, 2017, at 6:57 AM, Dean Jackson wrote: >>> On 24 Jul 2017, at 22:44, Brian Burg wrote: Hi

Re: [webkit-dev] WEB_TIMING enabled on all ports - let's remove the flag?

2017-08-01 Thread Maciej Stachowiak
> On Aug 1, 2017, at 9:57 AM, Dean Jackson wrote: > > > >> On 24 Jul 2017, at 22:44, Brian Burg wrote: >> >> Hi WebKittens, >> >> In WebKit, the various web-exposed timing APIs–Resource Timing, User Timing, >> and Navigation Timing are guarded by the

Re: [webkit-dev] What's the rationale for not including config.h in any header files?

2017-07-31 Thread Maciej Stachowiak
> On Jul 31, 2017, at 5:04 PM, Michael Catanzaro wrote: > > On Mon, Jul 31, 2017 at 9:27 PM, Darin Adler wrote: >> I don’t think we should add lots of includes of “config.h”, though. I think >> we can come up with something better. > > Like what? The

Re: [webkit-dev] Using "auto <function()> -> returnType" breaks prepare-ChangeLog

2017-07-28 Thread Maciej Stachowiak
> On Jul 28, 2017, at 10:58 AM, Sam Weinig wrote: > > > >> On Jul 28, 2017, at 10:31 AM, JF Bastien > > wrote: >> >> >> >>> On Jul 28, 2017, at 10:29, Sam Weinig >> > wrote:

Re: [webkit-dev] NPAPI support to remain?

2017-07-14 Thread Maciej Stachowiak
> On Jul 13, 2017, at 6:23 PM, Michael Catanzaro wrote: > > Hi, > > It seems WebKit is the last modern web engine still supporting NPAPI. Is > Apple planning to continue supporting NPAPI and WebKitPluginProcess for the > foreseeable future? Or is it something that

Re: [webkit-dev] Service workers

2017-07-14 Thread Maciej Stachowiak
> On Jul 13, 2017, at 6:19 PM, Michael Catanzaro wrote: > > Hi, > > We've noticed that service worker support has more than once been a > consideration for embedded device manufacturers when choosing between WebKit > and Chromium for their products. I see the feature

Re: [webkit-dev] Intent to remove the WebCore::IconDatabase (GTK needs to make a decision)

2017-06-16 Thread Maciej Stachowiak
> On Jun 15, 2017, at 8:01 PM, Brady Eidson <beid...@apple.com> wrote: > > Slight reordering. > >> On Jun 15, 2017, at 5:27 PM, Maciej Stachowiak <m...@apple.com> wrote: >> >> >> This is slightly tangential, but a comment on the model: it

Re: [webkit-dev] Intent to remove the WebCore::IconDatabase (GTK needs to make a decision)

2017-06-15 Thread Maciej Stachowiak
This is slightly tangential, but a comment on the model: it doesn't seem like there's a way for clients to check what range of icons are available and only then choose which to load. Even though Safari may not have needed this to move over, if you wanted to do something rigorous like load the

Re: [webkit-dev] Should we ever use std::function instead of WTF::Function?

2017-06-13 Thread Maciej Stachowiak
In case it turns out not to be possible to reduce the number of concepts (besides eliminating std::function), maybe it would help to change the names and behaviors of these classes to match better. Function, SharedFunction and ScopedFunction would have a much more obvious relationship to each

Re: [webkit-dev] "ReflectOnly" IDL equivalent

2017-06-10 Thread Maciej Stachowiak
> On Jun 9, 2017, at 10:08 PM, Chris Dumez wrote: > > >>> On Jun 9, 2017, at 11:47 AM, Sam Weinig wrote: >>> >>> >>> >>> On Jun 2, 2017, at 11:32 AM, Ryosuke Niwa wrote: >>> On Fri, Jun 2, 2017 at 9:18 AM, Chris Dumez

Re: [webkit-dev] Where do we put WPT tests to be exported

2017-05-21 Thread Maciej Stachowiak
> On May 18, 2017, at 2:08 PM, Philip Jägenstedt wrote: > > On Tue, May 16, 2017 at 5:38 PM youenn fablet > wrote: > > There was a suggestion that LayoutTests/imported/w3c/web-platform-tests be > moved to a shorter path like

Re: [webkit-dev] Another WPT bite

2017-05-16 Thread Maciej Stachowiak
> On May 16, 2017, at 1:16 AM, Ryosuke Niwa wrote: > > On Mon, May 15, 2017 at 11:57 PM, Anne van Kesteren wrote: >> On Tue, May 16, 2017 at 7:29 AM, Ryosuke Niwa wrote: >>> Given we're talking about how these tests are ran inside WebKit,

Re: [webkit-dev] Where do we put WPT tests to be exported

2017-05-16 Thread Maciej Stachowiak
> On May 15, 2017, at 9:08 PM, youenn fablet wrote: > > I see two main cases: > - Writer of the patch is making sure to upstream WPT test changes at WebKit > landing time. It is ok to make the changes directly in > LayoutTests/imported/w3c/web-platform-tests/ > - Writer

Re: [webkit-dev] Another WPT bite

2017-05-14 Thread Maciej Stachowiak
> On May 13, 2017, at 5:26 PM, Michael[tm] Smith <m...@w3.org> wrote: > > Maciej Stachowiak <m...@apple.com>, 2017-05-13 14:58 -0700: >> ... From what I gather, there are a lot of tests where only the paths to >> the test harness end up requiring the

Re: [webkit-dev] Another WPT bite

2017-05-13 Thread Maciej Stachowiak
> On May 12, 2017, at 7:49 PM, a...@webkit.org wrote: > > >> 12 мая 2017 г., в 19:38, Brian Burg > > написал(а): >> >>> I think that I explained it very clearly, but let me try again. >>> >>> When there is a test failure that I need to communicate

Re: [webkit-dev] Another WPT bite

2017-05-12 Thread Maciej Stachowiak
> On May 12, 2017, at 2:39 PM, Ryosuke Niwa wrote: > > On Fri, May 12, 2017 at 12:04 PM, Alexey Proskuryakov wrote: >> >> 12 мая 2017 г., в 11:52, Ben Kelly написал(а): >> >> On Fri, May 12, 2017 at 2:26 PM, Rick Byers

[webkit-dev] Also in the tradition of massive renames

2017-05-10 Thread Maciej Stachowiak
I'd like to propose the following directory renames for consideration: Source/WebKit --> Source/WebKitLegacy (or alternately, LegacyWebKit for autocomplete happiness, but maybe not if we keep the LayoutTests name) Source/WebKit2 --> Source/WebKit Reasons: - Matches the current names of the

Re: [webkit-dev] Rename LayoutTests

2017-05-10 Thread Maciej Stachowiak
ebkit.org <mailto:rn...@webkit.org>> > wrote: >>> On Wed, May 10, 2017 at 12:02 AM, Maciej Stachowiak <m...@apple.com >>> <mailto:m...@apple.com>> wrote: >>>> IntegrationTests doesn't distinguish them from performance tests, or API >>

Re: [webkit-dev] Rename LayoutTests

2017-05-10 Thread Maciej Stachowiak
A few more coats of paint for the bike shed: > On May 9, 2017, at 10:45 PM, Ryosuke Niwa <rn...@webkit.org> wrote: > > On Tue, May 9, 2017 at 10:23 PM, Maciej Stachowiak <m...@apple.com > <mailto:m...@apple.com>> wrote: > > On May 9, 2017, at 9:0

Re: [webkit-dev] Rename LayoutTests

2017-05-10 Thread Maciej Stachowiak
> On May 9, 2017, at 10:43 PM, Dan Bernstein <m...@apple.com> wrote: > > >> On May 9, 2017, at 10:23 PM, Maciej Stachowiak <m...@apple.com >> <mailto:m...@apple.com>> wrote: >> >>> JSTests, and >> >> Could go under Jav

Re: [webkit-dev] Rename LayoutTests

2017-05-09 Thread Maciej Stachowiak
> On May 9, 2017, at 9:07 PM, Michael Catanzaro <mcatanz...@igalia.com> wrote: > > On Tue, May 9, 2017 at 11:01 PM, Maciej Stachowiak <m...@apple.com> wrote: >> How about just Tests? >> Or alternately, RegressionTests. But I like just plain Tests. > &g

Re: [webkit-dev] Rename LayoutTests

2017-05-09 Thread Maciej Stachowiak
How about just Tests? Or alternately, RegressionTests. But I like just plain Tests. > On May 9, 2017, at 8:51 PM, Michael Catanzaro wrote: > >> On Tue, May 9, 2017 at 9:23 PM, Ryosuke Niwa wrote: >> AutomatedTests - As opposed to ManualTests. > > The

Re: [webkit-dev] Idiom for functions with all return values in a switch case

2017-05-09 Thread Maciej Stachowiak
> On May 9, 2017, at 12:05 PM, Alfonso Guerra wrote: > > > > On May 9, 2017 2:07 PM, "Michael Catanzaro" > wrote: > Hi, > > Consider this function: > >        static WKAutoplayEvent

Re: [webkit-dev] Idiom for functions with all return values in a switch case

2017-05-09 Thread Maciej Stachowiak
> On May 9, 2017, at 11:35 AM, Michael Catanzaro <mcatanz...@igalia.com> wrote: > > On Tue, May 9, 2017 at 1:13 PM, Maciej Stachowiak <m...@apple.com> wrote: >> I think this second option may suppress the warning when you have forgotten >> to list one of th

Re: [webkit-dev] Idiom for functions with all return values in a switch case

2017-05-09 Thread Maciej Stachowiak
> On May 9, 2017, at 11:06 AM, Michael Catanzaro wrote: > > Hi, > > Consider this function: > > static WKAutoplayEvent toWKAutoplayEvent(WebCore::AutoplayEvent event) > { > switch (event) { > case >

Re: [webkit-dev] Another WPT bite

2017-05-09 Thread Maciej Stachowiak
> On May 9, 2017, at 8:11 AM, Geoffrey Garen wrote: > >> What we're suggesting is to give preferential treatments to >> testharness.js over js-test.js / js-test-pre.js when you were already >> planning to write a test with the latter two scripts. > > OK, I think this makes

Re: [webkit-dev] Another WPT bite

2017-05-09 Thread Maciej Stachowiak
> On May 9, 2017, at 8:44 AM, youenn fablet wrote: > > > Besides other issues mentioned, testharness tends to result in more verbose > tests compared to js-test, at least for simple cases. > > For synchronous tests, I am not sure there is any big difference one way or >

Re: [webkit-dev] Another WPT bite

2017-05-09 Thread Maciej Stachowiak
> On May 8, 2017, at 11:15 PM, Ryosuke Niwa wrote: > > On Mon, May 8, 2017 at 11:01 PM, Brady Eidson > wrote: > > On May 8, 2017, at 10:44 PM, Ryosuke Niwa < > rn...@webkit.org > > wrote: >>> On

Re: [webkit-dev] Clang tidy

2017-05-09 Thread Maciej Stachowiak
> On May 8, 2017, at 9:09 PM, Ryosuke Niwa <rn...@webkit.org> wrote: > > On Wed, May 3, 2017 at 8:31 PM, Maciej Stachowiak <m...@apple.com > <mailto:m...@apple.com>> wrote: > On May 3, > 2017, at 6:31 PM, Olmstead, Don < > don.olmst...@sony.co

Re: [webkit-dev] User agent woes

2017-05-08 Thread Maciej Stachowiak
> On May 8, 2017, at 1:30 PM, Michael Catanzaro <mcatanz...@igalia.com> wrote: > > On Mon, May 8, 2017 at 3:13 PM, Maciej Stachowiak <m...@apple.com> wrote: >> The ideal scenario would be for Google Hangouts to correctly handle WebKit >> UA strings on X1

Re: [webkit-dev] User agent woes

2017-05-08 Thread Maciej Stachowiak
> On May 7, 2017, at 8:11 PM, Michael Catanzaro wrote: > > Hi Maciej, > > I agree with basically everything you wrote, except I recommend not using OS > X as the operating system string in the default user agent except when > actually running on macOS. We tried this

Re: [webkit-dev] User agent woes

2017-05-07 Thread Maciej Stachowiak
> On May 6, 2017, at 5:19 PM, Michael Catanzaro wrote: > > Hi, > > You're probably aware that WebKitGTK+ has user agent quirks to make various > popular websites work, most notably google.com. For our list of quirks, see: > >

Re: [webkit-dev] Clang tidy

2017-05-03 Thread Maciej Stachowiak
> On May 3, 2017, at 6:31 PM, Olmstead, Don wrote: > > I took some time today to see how clang-tidy can be run on WebKit code and > openedhttps://bugs.webkit.org/show_bug.cgi?id=171632 > with some examples on how to >

Re: [webkit-dev] Heads up: ICU source compatibility breakage in 59.1 release

2017-05-02 Thread Maciej Stachowiak
I agree, better to add private cast macros (which are no-ops on the appropriate version of ICU) to convert incoming/outgoing public API types, and leave the actual public API types alone. > On May 2, 2017, at 10:40 AM, Myles C. Maxfield wrote: > > The fact that we use

Re: [webkit-dev] PAL Strategy

2017-05-01 Thread Maciej Stachowiak
> On May 1, 2017, at 1:48 PM, Brady Eidson wrote: > > >> On May 1, 2017, at 12:41 PM, Michael Catanzaro wrote: >> >> I thought the original intent for PAL was to replace WebCore/platform, so I >> assume the criterion would be "stuff currently in

Re: [webkit-dev] !!Tests for equality comparison

2017-04-28 Thread Maciej Stachowiak
Sent from my iPhone > On Apr 28, 2017, at 1:00 PM, JF Bastien <jfbast...@apple.com> wrote: > > >> On Apr 28, 2017, at 12:12, Maciej Stachowiak <m...@apple.com> wrote: >> >> >> Here's some comments in the other direction: >> >&g

Re: [webkit-dev] !!Tests for equality comparison

2017-04-28 Thread Maciej Stachowiak
I think allowing both forms is worse than mandating one form. It's true that in different situations one or the other may read better, but it's distracting to have differences that are matters of author taste rather than conveying meaningful information. "This is a numeric check, not a boolean

Re: [webkit-dev] !!Tests for equality comparison

2017-04-28 Thread Maciej Stachowiak
Here's some comments in the other direction: - If there are times we recommend x != 0 instead of !x, it should maybe be based on whether the condition is better expressed as "not zero" or "false". In the numTestsForEqualityComparison, that's clearly a "not zero" check given the naming of the

Re: [webkit-dev] Compile time increase over time

2017-04-24 Thread Maciej Stachowiak
For the macOS and iOS ports, we have the additional problem of overhead from the build system. Our make+xcodebuild based system takes a surprisingly long time even for a no-op build, or for a small incremental "just changed this one implementation file" build. There's also some indication

Re: [webkit-dev] Proposal: upstream the WPE port

2017-04-22 Thread Maciej Stachowiak
The GTK+ port has been a good WebKit citizen. And Igalia has a strong track record of WebKit contributions. So I am generally supportive of upstreaming the WPE port, as I expect it to be a net positive for the project. I can see we will need to work out issues around the API that is exposed.

Re: [webkit-dev] Proposal to limit the size of the captured exception stack

2017-03-17 Thread Maciej Stachowiak
> On Mar 17, 2017, at 11:09 AM, Mark Lam wrote: > > Thanks for the reminder to back observations up with data. I was previously > running some tests that throws StackOverflowErrors a lot (which tainted my > perspective), and I made a hasty conclusion which isn’t good.

Re: [webkit-dev] Port For Android

2017-03-07 Thread Maciej Stachowiak
Android is not a supported platforms for current WebKit and has not been in a while. You will not be able to build for Android without a major porting effort. Android WebKit was originally a fork of an old version that may not have even been fully merged back before we purged it. Recent

Re: [webkit-dev] VM::setExclusiveThread()

2017-02-28 Thread Maciej Stachowiak
Good news that it doesn't affect Speedometer. Does this have any effect on pure JS benchmarks running in the browser (e.g. JetStream)? - Maciej > On Feb 28, 2017, at 10:48 AM, Filip Pizlo wrote: > > Sounds good! > > I agree that a 20% regression on a microbenchmark of the

  1   2   3   4   5   6   7   8   9   10   >