Re: [webkit-dev] Re: [webkit-changes] [24723] trunk/WebCore

2007-07-29 Thread Maciej Stachowiak
On Jul 28, 2007, at 3:52 AM, Lars Knoll wrote: On Saturday 28 July 2007 00:26:19 Maciej Stachowiak wrote: On Jul 27, 2007, at 11:36 AM, Lars Knoll wrote: Other organizations have requested the ability to use other XML parsers as well, such as expat. Seems like in the long run we want a

Re: [webkit-dev] Re: [webkit-changes] [24723] trunk/WebCore

2007-07-29 Thread Lars Knoll
On Sunday 29 July 2007 08:47:50 Maciej Stachowiak wrote: On Jul 28, 2007, at 3:52 AM, Lars Knoll wrote: On Saturday 28 July 2007 00:26:19 Maciej Stachowiak wrote: On Jul 27, 2007, at 11:36 AM, Lars Knoll wrote: Other organizations have requested the ability to use other XML parsers as

[webkit-dev] Re: [webkit-changes] [24723] trunk/WebCore

2007-07-27 Thread Lars Knoll
On Friday 27 July 2007 16:50:01 Darin Adler wrote: I'm not happy with the code organization here. XMLTokenizer now has tons of ifdefs and two separate implementations. It's fine to have a QXmlStream implementation, but the two implementations should be in separate files, side by side, as we do

Re: [webkit-dev] Re: [webkit-changes] [24723] trunk/WebCore

2007-07-27 Thread Darin Adler
On Jul 27, 2007, at 11:36 AM, Lars Knoll wrote: 2. add a qt/XMLTokenizerQt.cpp and a libxml/XMLTokenizerLibXml.cpp and keep a common XMLTokenizer.cpp for code that is used in both. I like that option best. It's the pattern used in platform for cases like this. -- Darin

Re: [webkit-dev] Re: [webkit-changes] [24723] trunk/WebCore

2007-07-27 Thread Lars Knoll
On Friday 27 July 2007 20:50:53 Darin Adler wrote: On Jul 27, 2007, at 11:36 AM, Lars Knoll wrote: 2. add a qt/XMLTokenizerQt.cpp and a libxml/XMLTokenizerLibXml.cpp and keep a common XMLTokenizer.cpp for code that is used in both. I like that option best. It's the pattern used in platform

Re: [webkit-dev] Re: [webkit-changes] [24723] trunk/WebCore

2007-07-27 Thread Lars Knoll
On Friday 27 July 2007 21:05:00 Darin Adler wrote: On Jul 27, 2007, at 11:53 AM, Lars Knoll wrote: I'm fine with moving to this approach (even though it'll still lead to some code duplication if we do it the easy way without refactoring). I don't think we should insist on doing it without

Re: [webkit-dev] Re: [webkit-changes] [24723] trunk/WebCore

2007-07-27 Thread Lars Knoll
On Friday 27 July 2007 21:15:27 Lars Knoll wrote: On Friday 27 July 2007 21:05:00 Darin Adler wrote: On Jul 27, 2007, at 11:53 AM, Lars Knoll wrote: I'm fine with moving to this approach (even though it'll still lead to some code duplication if we do it the easy way without