[webkit-dev] ResourceHandle and the Frame parameter

2007-06-12 Thread Morgan L
Congrats on the windows launch! :-) Now, on to my question... There is a comment in ResourceHandle.h about the Frame parameter to ResourceHandle's static create function. The comment suggests that the Frame parameter might be removed in the future or that it at least shouldn't be there. I

Re: [webkit-dev] ResourceHandle and the Frame parameter

2007-06-12 Thread Christopher Brichford
It is important for the ResourceHandle in the apollo port to have access to WebView state. We can live with a pointer to the Frame, FrameLoader, Page, or any other object that allows us to walk back to our WebView. We could add a factory method on FrameLoaderClient to construct

Re: [webkit-dev] ResourceHandle and the Frame parameter

2007-06-12 Thread Morgan L
In the meantime, will you accept a patch to add a Frame pointer to loadResourceSynchronously? --- Darin Adler [EMAIL PROTECTED] wrote: I think we'll have to rethink this. ResourceHandle is intended to be a low level networking layer, and so it doesn't make sense to have higher level

Re: [webkit-dev] ResourceHandle and the Frame parameter

2007-06-12 Thread Morgan L
I went ahead and filed a bug for this issue: http://bugs.webkit.org/show_bug.cgi?id=14106 --- Morgan L [EMAIL PROTECTED] wrote: In the meantime, will you accept a patch to add a Frame pointer to loadResourceSynchronously? --- Darin Adler [EMAIL PROTECTED] wrote: I think we'll have

Re: [webkit-dev] ResourceHandle and the Frame parameter

2007-06-12 Thread Maciej Stachowiak
On Jun 12, 2007, at 2:33 PM, Darin Adler wrote: I think we'll have to rethink this. ResourceHandle is intended to be a low level networking layer, and so it doesn't make sense to have higher level concepts like a Frame*, but clearly we'll need to make a design change so there's a higher

Re: [webkit-dev] ResourceHandle and the Frame parameter

2007-06-12 Thread Maciej Stachowiak
On Jun 12, 2007, at 5:22 PM, Maciej Stachowiak wrote: On Jun 12, 2007, at 2:33 PM, Darin Adler wrote: I think we'll have to rethink this. ResourceHandle is intended to be a low level networking layer, and so it doesn't make sense to have higher level concepts like a Frame*, but clearly

Re: [webkit-dev] ResourceHandle and the Frame parameter

2007-06-12 Thread Morgan L
--- Maciej Stachowiak [EMAIL PROTECTED] wrote: On Jun 12, 2007, at 5:22 PM, Maciej Stachowiak wrote: On Jun 12, 2007, at 2:33 PM, Darin Adler wrote: I think we'll have to rethink this. ResourceHandle is intended to be a low level networking layer, and so it doesn't make sense

Re: [webkit-dev] ResourceHandle and the Frame parameter

2007-06-12 Thread Maciej Stachowiak
On Jun 12, 2007, at 5:41 PM, Morgan L wrote: --- Maciej Stachowiak [EMAIL PROTECTED] wrote: On Jun 12, 2007, at 5:22 PM, Maciej Stachowiak wrote: On Jun 12, 2007, at 2:33 PM, Darin Adler wrote: I think we'll have to rethink this. ResourceHandle is intended to be a low level