Re: [webkit-dev] to reitveld or not to reitveld

2009-06-06 Thread Ojan Vafai
On Sun, Jun 7, 2009 at 7:51 AM, Mark Rowe wrote: > On 2009-06-06, at 15:02, Peter Kasting wrote: > > On Sat, Jun 6, 2009 at 1:48 AM, Mark Rowe wrote: > >> Of the issues that Ojan mentioned in his original email, I see three that >> would need to be addressed before we could consider adopting Rie

Re: [webkit-dev] to reitveld or not to reitveld

2009-06-06 Thread Mark Rowe
On 2009-06-06, at 15:02, Peter Kasting wrote: On Sat, Jun 6, 2009 at 1:48 AM, Mark Rowe wrote: Per Ojan's original email it is not as simple as adding a few URLs to some scripts, code changes would be needed to make it suitable for our purposes. Let's try and avoid hyperbole: it makes it

Re: [webkit-dev] to reitveld or not to reitveld

2009-06-06 Thread Peter Kasting
Clarifications: On Sat, Jun 6, 2009 at 3:02 PM, Peter Kasting wrote: > I'm not trying to be hyperbolic. > On the other hand, I could simply be flat-out wrong. Although I did re-read Ojan's email and I don't I see him as saying there'd be a lot of actual coding needed to try Rietveld. - Doesn'

Re: [webkit-dev] to reitveld or not to reitveld

2009-06-06 Thread Peter Kasting
On Sat, Jun 6, 2009 at 1:48 AM, Mark Rowe wrote: > Per Ojan's original email it is not as simple as adding a few URLs to some > scripts, code changes would be needed to make it suitable for our purposes. > Let's try and avoid hyperbole: it makes it difficult to have a reasonable > discussion. >

[webkit-dev] Expected behavior of Mutex.lock()

2009-06-06 Thread Drew Wilson
I can't seem to find any documentation as to what the expected behavior of Mutex.lock() is with regard to calling lock() recursively on the same thread. Looking at the pthreads implementation, it appears that when we create the mutex we pass null as the attributes, which gives us the default behavi

Re: [webkit-dev] to reitveld or not to reitveld

2009-06-06 Thread Mark Rowe
On 2009-06-06, at 00:17, Peter Kasting wrote: On Fri, Jun 5, 2009 at 11:43 PM, Mark Rowe wrote: Dropping our existing practice of using Bugzilla for patch reviews is one way of addressing this. Folding the more useful features of Rietveld in to Bugzilla to improve Bugzilla-based patch rev

Re: [webkit-dev] to reitveld or not to reitveld

2009-06-06 Thread Eric Seidel
> This something of a non-sequiter, since it is trivial to create a script to > do the same with Bugzilla. I've heard mentions of a git-send-bugzilla > script that does most of this already, and I'm sure it could easily be > adapted for those preferring SVN. https://bugs.webkit.org/show_bug.cgi?i

Re: [webkit-dev] to reitveld or not to reitveld

2009-06-06 Thread Peter Kasting
On Fri, Jun 5, 2009 at 11:43 PM, Mark Rowe wrote: > Dropping our existing practice of using Bugzilla for patch reviews is one > way of addressing this. Folding the more useful features of Rietveld in to > Bugzilla to improve Bugzilla-based patch reviews is another. We all seem to > be in agreem