Re: [webkit-dev] Please do not commit-queue+ changes to ChromiumBridge.h

2009-09-04 Thread David Levin
Even better if the person submitting the patch marks it as commit-queue- when they do the r? (as Jian does for example) to prevent this from happening. Just do this for any patch that you want to be in control of landing. dave On Fri, Sep 4, 2009 at 11:04 AM, Darin Fisher da...@chromium.org

[webkit-dev] window.open issues in DRT?

2009-09-04 Thread Dmitry Titov
One (quite old) change - http://trac.webkit.org/changeset/25793 - has changed tests using window.open to use iframes instead, apparently because of some difficulty in DRT with closing windows... I'm finding myself creating tests using window.open(). Can anybody remember if those difficulties were

[webkit-dev] User Stylesheets changes I'd like to make

2009-09-04 Thread David Hyatt
Right now the user stylesheet location is stored as a URL. This is based off ancient history, namely that we happened to store the preference this way on Mac. Even though Safari only allows you to pick local files from its UI for user stylesheets, the preference itself is a URL. Because

Re: [webkit-dev] User Stylesheets changes I'd like to make

2009-09-04 Thread Tor Arne Vestbø
On 9/4/09 9:47 PM, David Hyatt wrote: Right now the user stylesheet location is stored as a URL. This is based off ancient history, namely that we happened to store the preference this way on Mac. Even though Safari only allows you to pick local files from its UI for user stylesheets, the

Re: [webkit-dev] User Stylesheets changes I'd like to make

2009-09-04 Thread David Hyatt
A second change I would like to make is to eliminate the liveness of the sheet.. With support coming online for both injected user scripts and user stylesheets, I expect that a better way to deal with this is to have a Develop menu item (or inspector item) to reload all user content.