Hi webkit-dev!
Trying to add ASSERTS to RefCounted objects (
https://bugs.webkit.org/show_bug.cgi?id=31639) I've added some more calls to
WTF::currentThread() and started to get a lot of assertions here:
static ThreadIdentifier establishIdentifierForPthreadHandle(pthread_t&
pthreadHandle)
{
A
On Thu, Dec 10, 2009 at 1:09 PM, Dmitry Titov wrote:
> On Thu, Dec 10, 2009 at 11:09 AM, Eric Uhrhane wrote:
>>
>> On Wed, Dec 9, 2009 at 6:55 PM, Dmitry Titov wrote:
>> > Thanks for the link to the prototype code!
>> > If I understand it right and the DatabaseManager can not have any other
>> >
On Thu, Dec 10, 2009 at 11:09 AM, Eric Uhrhane wrote:
> On Wed, Dec 9, 2009 at 6:55 PM, Dmitry Titov wrote:
> > Thanks for the link to the prototype code!
> > If I understand it right and the DatabaseManager can not have any other
> > relationship with ScriptExecutionContext but 1-1 and their li
On Thursday 10 December 2009 03:16:51 pm Peter Kasting wrote:
> Yeah, I'm not sold. But oh well. I think I was getting too irked, when
> really we're just both giving our opinions on how we want the style guide
> to work. There's nothing wrong with having opinions, or disagreeing.
>
> Besides, I
On Thu, Dec 10, 2009 at 11:55 AM, Adam Treat wrote:
> But I think I've been clear?!
>
It is always possible that my confusion is due to my own
ignorance/misreading/stupidity. Maybe my brain is just slow today.
I believe I've given good examples of why. You disagree?
>
Yeah, I'm not sold. Bu
On Thursday 10 December 2009 02:35:38 pm Peter Kasting wrote:
> On Thu, Dec 10, 2009 at 11:28 AM, Adam Treat wrote:
> > both are confusing and in my mind call for exercising reviewer
> > discretion over the style guide.
> >
> > And I *do not* think the
> > style guide is wrong for the *guide* to p
On Thu, Dec 10, 2009 at 11:28 AM, Adam Treat wrote:
> both are confusing and in my mind call for exercising reviewer
> discretion over the style guide.
>
> And I *do not* think the
> style guide is wrong for the *guide* to prefer "!foo" over "foo == 0"!
>
OK. Then I have no idea what your stand
> not clear to me what benefit could be had by effectively splitting a
class in two
Perhaps more easily worked on by multiple hands in parallel with fewer
conflicts. Various bits of "database stuff" are better encapsulated in
database specific classes (so maybe easier to learn how the system work
On Thursday 10 December 2009 01:34:12 pm Peter Kasting wrote:
> But if "!color.green()" is potentially confusing, then certainly it is just
> as confusing (in fact moreso) without the surrounding "color.blue()" and
> "color.red()" tests in Adam's example. Yet Adam cited "consistency with
> surroun
On Wed, Dec 9, 2009 at 6:55 PM, Dmitry Titov wrote:
> Thanks for the link to the prototype code!
> If I understand it right and the DatabaseManager can not have any other
> relationship with ScriptExecutionContext but 1-1 and their lifetime is the
> same then it's not clear to me what benefit coul
On Thu, Dec 10, 2009 at 7:57 AM, Joe Mason wrote:
> > Off the top of my head as a reviewer I'd accept:
> >
> > if (color.red() == 255 && color.green() == 0 && color.blue() ==
> > 255) // pink!
> >
> > over
> >
> > if (color.red() == 255 && !color.green() && color.blue() == 255)
> > //
Let's try this again now that I've resubscribed with the correct email
address:
> On Wednesday 09 December 2009 07:52:22 pm Peter Kasting wrote:
> > You haven't really said why. The closest you got was the vague "It
> is also
> > true that the current style guidelines if
> > practiced pedanticall
On Wednesday 09 December 2009 07:52:22 pm Peter Kasting wrote:
> You haven't really said why. The closest you got was the vague "It is also
> true that the current style guidelines if
> practiced pedantically in every case can lead to potential bugs." Bugs
> like what? Perhaps if there are some,
13 matches
Mail list logo
