Re: [webkit-dev] ARM JIT for WinCE

2010-01-08 Thread Zoltan Herczeg
Hi, the dateProtoFuncGetTimezoneOffset does not use the argList argument, while functionPrint does. Perhaps passing this argument is still not yet WinCE compatible. ArgList contains a pointer to the arguments (JSValue pointers), and the length of the arguments. This structure is 8 bytes on 32 bit

[webkit-dev] File::Spec-tmpdir() on Leopard and Snow Leopard bots

2010-01-08 Thread Andras Becsi
Hello, in the process of making it possible to run more than one instance of run-webkit-tests at the same time (https://bugs.webkit.org/show_bug.cgi?id=33153), I'm trying to make the handling of running httpd processes more platform independent. My tries failed only on the Leopard bots.

Re: [webkit-dev] Did I break the build?

2010-01-08 Thread Tor Arne Vestbø
Eric Seidel wrote: http://build.webkit.org/console Will let you know. I love the console, thanks for adding this! tor arne ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] Did I break the build?

2010-01-08 Thread Tor Arne Vestbø
Eric Seidel wrote: The Chromium developers, notably Nicolas Sylvain added /console. Mark Rowe is our kind BuildBot admin who updated our copy to the latest BuildBot version including this new feature. I was not involved. :) Then great thanks to both Nicolas and Mark!! :) tor arne

Re: [webkit-dev] Question about PopupMenuClient

2010-01-08 Thread Kenneth Christiansen
Maybe add a virtual like: virtual PlatformPopupMenu platformPopupMenu() const = 0; to HostWindow.h ? That is an option but I do not know if that is the purpose of HostWindow. Much like Qt already returns QWebPageClient for 'platformPageClient()' ? Maybe you can even re-use this

Re: [webkit-dev] Question about PopupMenuClient

2010-01-08 Thread Kenneth Christiansen
Thanks for the hints. I took a look at the code, and this seems easy to implement. Kenneth On Thu, Jan 7, 2010 at 7:51 PM, Darin Fisher da...@chromium.org wrote: Chromium actually does something like this. See ChromeClientChromium. In our case, we have two modes: one where the embedder

Re: [webkit-dev] [webkit-changes] [52980] trunk/LayoutTests

2010-01-08 Thread Alexey Proskuryakov
08.01.2010, в 02:22, e...@webkit.org написал(а): * platform/mac/Skipped: Add http/tests/uri/escaped-entity.html to Skipped list since it affects later tests. I think that having this particular test enabled is much more important than having the patch it was affecting landed. Also,

Re: [webkit-dev] File::Spec-tmpdir() on Leopard and Snow Leopard bots

2010-01-08 Thread David Kilzer
On Fri, January 8, 2010 at 12:39:41 AM, Andras Becsi wrote: in the process of making it possible to run more than one instance of run-webkit-tests at the same time (https://bugs.webkit.org/show_bug.cgi?id=33153), I'm trying to make the handling of running httpd processes more platform

Re: [webkit-dev] [webkit-changes] [52980] trunk/LayoutTests

2010-01-08 Thread Osztrogonac Csaba
Hi, The r52976 revealed this strange sideeffect bug, we filed some bug on it. We skipped these tests, because commit-queue doesn't work if one of the core builder is red. I don't think it is a good idea to land different, platform dependent expected files with false data. On the one hand layout

Re: [webkit-dev] postProgressFinishedNotification

2010-01-08 Thread Darin Adler
That’s not a question about development of WebKit. The place to ask is the webkit-help mailing list http://webkit.org/contact.html. -- Darin ___ webkit-dev mailing list webkit-dev@lists.webkit.org

Re: [webkit-dev] Running pixel tests on build.webkit.org

2010-01-08 Thread Pam Greene
And one very quick, short-term solution: 3. Generate new pixel results to match the current behavior, and check them in as hypothetically correct. And of course if someone notices an existing problem and fixes it, they check in corrected images then. It doesn't help find current problems, but

Re: [webkit-dev] Did I break the build?

2010-01-08 Thread Chris Jerdonek
Date: Thu, 7 Jan 2010 16:21:49 -0800 From: Eric Seidel e...@webkit.org http://build.webkit.org/console Will let you know. If possible, it might be good to add this link to the http://build.webkit.org/ home page. Is it linked elsewhere? It doesn't look like the home page is stored in

Re: [webkit-dev] Running pixel tests on build.webkit.org

2010-01-08 Thread Jeremy Orlow
Plan 3 seems like the best (and simplest) one until the infrastructure for the others (and/or a champion for fixing currently failing tests) is available. What would it take to go with plan 3? I guess someone needs to rebaseline everything that's currently failing, check them in, and then

Re: [webkit-dev] [webkit-changes] [52980] trunk/LayoutTests

2010-01-08 Thread Darin Adler
On Jan 8, 2010, at 8:15 AM, Osztrogonac Csaba wrote: I don't think it is a good idea to land different, platform dependent expected files with false data. This is where I think the difference comes in. I don’t think these different expected files are accurately characterized as “false data”.

[webkit-dev] Scrolling / redraw issue on WinCE platform

2010-01-08 Thread Jason Rukman
I'm working on a port of webKit to WinCE, and am currently encountering what appears to be a redraw/paint issue when scrolling (horizontally, in this case) to a widget that is originally partially off-screen (an input button in a form). The text all appears to scroll just fine, and the image of

Re: [webkit-dev] Language Bindings

2010-01-08 Thread Kevin Ollivier
Hi, On Jan 7, 2010, at 5:15 PM, AS wrote: Hello I'm looking into adding bindings for Python to the webkit DOM objects. Ideally, what I would like to create is WebKit based application that can use Python for DHTML manipulation. From the code, I can see how there are perl scripts

Re: [webkit-dev] [webkit-changes] [52980] trunk/LayoutTests

2010-01-08 Thread Alexey Proskuryakov
On 08.01.2010, at 8:15, Osztrogonac Csaba wrote: I hope fixing the bug ASAP is much more important than paper over the problem with rolling out a good and working patch which only revealed the bug. Do you have a plan for re-enabling the skipped test? The failures were mysterious, and

Re: [webkit-dev] [webkit-changes] [52980] trunk/LayoutTests

2010-01-08 Thread Eric Seidel
On Fri, Jan 8, 2010 at 7:37 AM, Alexey Proskuryakov a...@webkit.org wrote: * platform/mac/Skipped: Add http/tests/uri/escaped-entity.html to Skipped list since it affects later tests. I think that having this particular test enabled is much more important than having the patch it was

Re: [webkit-dev] [webkit-changes] [52980] trunk/LayoutTests

2010-01-08 Thread Eric Seidel
Two things which could very quickly resolve this issue is if these commands fail on their respective platforms or not: run-webkit-tests --skipped=ignore platform/mac/editing/input/devanagari-ligature.html run-webkit-testsw --skipped=ignore platform/mac/svg/W3C-SVG-1.1/filters-conv-01-f.svg I

Re: [webkit-dev] [webkit-changes] [52980] trunk/LayoutTests

2010-01-08 Thread Alexey Proskuryakov
On 08.01.2010, at 11:56, Eric Seidel wrote: I think that having this particular test enabled is much more important than having the patch it was affecting landed. Agreed. But, I think it's inexcusable for a test to affect later results. I skipped it more on those grounds than that the

Re: [webkit-dev] [webkit-changes] [52980] trunk/LayoutTests

2010-01-08 Thread Eric Seidel
On Fri, Jan 8, 2010 at 12:14 PM, Alexey Proskuryakov a...@webkit.org wrote: It's not clear where the bug is though. If there is an uninitialized memory read in a later test, then earlier tests that randomly affect it can be perfectly correct. The fact that on other platforms the problem was

Re: [webkit-dev] Running pixel tests on build.webkit.org

2010-01-08 Thread Dirk Pranke
On Thu, Jan 7, 2010 at 8:18 PM, Darin Fisher da...@chromium.org wrote: On Thu, Jan 7, 2010 at 5:17 PM, Ojan Vafai o...@chromium.org wrote: Do we really need a separate set of bots for pixel tests? Lets just turn the pixel tests on for the current bots. The only thing stopping us doing that is

[webkit-dev] how does webkit handle special layout requirement

2010-01-08 Thread Fei Wang
I am just curious how des webkit rendering engine handle the special layout format? For example, I do not want to have horizontal scroll and I have a fixed width widnow. But inside a html page, I have a image which size is bigger than the fixed width, how does webkit handle that case? Can we

[webkit-dev] Status bubbles and you

2010-01-08 Thread Adam Barth
If you've been using bugs.webkit.org today, you might have noticed some new status indicators in the attachments list. These status bubbles show how the patch fared when it was run through the various review bots. Here's what the different colors mean: * Green. Everything went great! You

[webkit-dev] Upstreaming an OpenVG graphics backend

2010-01-08 Thread Jakob Petsovits
Hi list, with help from Adam Treat, Eli Fidler, Yong Li and Genevieve Mak, I've implemented a graphics backend for native OpenVG. Now is (finally) the time to upstream that stuff, and for now I've started with two patches: https://bugs.webkit.org/show_bug.cgi?id=33403