[webkit-dev] Determining platform in LayoutTests

2010-03-28 Thread Martin Robinson
Apologies in advance if this has been hashed out before, but a cursory search of the list history didn't turn anything up. It seems that in LayoutTests platform specific behavior is generally handled by examining the user agent. I'm currently in the process of fixing

Re: [webkit-dev] Determining platform in LayoutTests

2010-03-28 Thread Sam Weinig
I am not sure which tests you are referring to that use the user-agent to change behavior, but that is not the way it is supposed to be done. Instead, tests that test a platform specific behavior should go in the LayoutTest/YOURPLATFORM directory. If it is just a platform specific result, the

Re: [webkit-dev] Determining platform in LayoutTests

2010-03-28 Thread Dan Bernstein
On Mar 28, 2010, at 7:08 PM, Sam Weinig wrote: I am not sure which tests you are referring to that use the user-agent to change behavior, but that is not the way it is supposed to be done. Instead, tests that test a platform specific behavior should go in the LayoutTest/YOURPLATFORM

Re: [webkit-dev] Determining platform in LayoutTests

2010-03-28 Thread Sam Weinig
On Sun, Mar 28, 2010 at 7:14 PM, Dan Bernstein m...@apple.com wrote: On Mar 28, 2010, at 7:08 PM, Sam Weinig wrote: I am not sure which tests you are referring to that use the user-agent to change behavior, but that is not the way it is supposed to be done. Instead, tests that test a

Re: [webkit-dev] Determining platform in LayoutTests

2010-03-28 Thread Alexey Proskuryakov
28.03.2010, в 19:26, Sam Weinig написал(а): One alternative, where applicable, is to make the behavior a runtime setting, and thus enable testing it on all platforms. Performance could get in the way of this. That's how we've been doing it for some selection-related tests, and that's